mirror of
https://github.com/tiennm99/DocsGPT.git
synced 2026-10-03 22:13:01 +00:00
The backend import package is now docsgpt, the name it will carry on PyPI; application was far too generic to install into anyone's site-packages. git mv plus a mechanical rewrite of every import, dotted string and path reference: 734 Python files, the compose files, Dockerfile, workflows, docs, setup scripts, devcontainer, k8s manifests, vscode config, pytest and coverage config, .gitignore. Behaviour is unchanged. Kept for one release: - A top-level application package whose meta-path finder resolves application.x.y to the already-imported docsgpt.x.y object, so old imports and entry points (celery -A application.app.celery, uvicorn application.asgi:asgi_app) keep working with a FutureWarning. - Celery registers every application.* task name as an alias of its docsgpt.* task on start-up, so messages queued by the previous release still run. The redbeat key prefix moves to redbeat:docsgpt:v2: so schedule entries the previous release wrote are left unread instead of firing twice. The backend image builds from the repository root (docker build -f docsgpt/Dockerfile .) so it can ship the alias package; a root .dockerignore allow-lists docsgpt/ and application/ and keeps caches, local data, .env files, the sample index files and the Dockerfile out. Compose and the image workflows point at the new context.
186 lines
6.4 KiB
Python
186 lines
6.4 KiB
Python
from unittest.mock import MagicMock, patch
|
|
|
|
import pytest
|
|
|
|
from docsgpt.parser.remote.crawler_loader import CrawlerLoader
|
|
from docsgpt.parser.schema.base import Document
|
|
|
|
|
|
class DummyResponse:
|
|
def __init__(self, text: str) -> None:
|
|
self.text = text
|
|
|
|
def raise_for_status(self) -> None:
|
|
return None
|
|
|
|
|
|
def _mock_validate_url(url):
|
|
"""Mock validate_url that allows test URLs through."""
|
|
from urllib.parse import urlparse
|
|
if not urlparse(url).scheme:
|
|
url = "http://" + url
|
|
return url
|
|
|
|
|
|
@patch("docsgpt.parser.remote.crawler_loader.validate_url", side_effect=_mock_validate_url)
|
|
@patch("docsgpt.parser.remote.crawler_loader.pinned_request")
|
|
def test_load_data_crawls_same_domain_links(mock_pinned_request, mock_validate_url):
|
|
responses = {
|
|
"http://example.com": DummyResponse(
|
|
"""
|
|
<html>
|
|
<body>
|
|
<a href='/about'>About</a>
|
|
<a href='https://external.com/news'>External</a>
|
|
</body>
|
|
</html>
|
|
"""
|
|
),
|
|
"http://example.com/about": DummyResponse("<html><body>About page</body></html>"),
|
|
}
|
|
|
|
def response_side_effect(_method: str, url: str, timeout=30):
|
|
if url not in responses:
|
|
raise AssertionError(f"Unexpected request for URL: {url}")
|
|
return responses[url]
|
|
|
|
mock_pinned_request.side_effect = response_side_effect
|
|
|
|
crawler = CrawlerLoader(limit=5)
|
|
|
|
result = crawler.load_data("http://example.com")
|
|
|
|
assert len(result) == 2
|
|
assert all(isinstance(doc, Document) for doc in result)
|
|
|
|
sources = {doc.extra_info.get("source") for doc in result}
|
|
assert sources == {"http://example.com", "http://example.com/about"}
|
|
|
|
paths = {doc.extra_info.get("file_path") for doc in result}
|
|
assert paths == {"index.md", "about.md"}
|
|
|
|
texts = {doc.text for doc in result}
|
|
assert texts == {"About\nExternal", "About page"}
|
|
|
|
assert mock_pinned_request.call_count == 2
|
|
|
|
|
|
@patch("docsgpt.parser.remote.crawler_loader.validate_url", side_effect=_mock_validate_url)
|
|
@patch("docsgpt.parser.remote.crawler_loader.pinned_request")
|
|
def test_load_data_accepts_list_input_and_adds_scheme(mock_pinned_request, mock_validate_url):
|
|
mock_pinned_request.return_value = DummyResponse("<html><body>No links here</body></html>")
|
|
crawler = CrawlerLoader()
|
|
|
|
result = crawler.load_data(["example.com", "unused.com"])
|
|
|
|
mock_pinned_request.assert_called_once_with("GET", "http://example.com", timeout=30)
|
|
|
|
assert len(result) == 1
|
|
assert result[0].text == "No links here"
|
|
assert result[0].extra_info == {
|
|
"source": "http://example.com",
|
|
"file_path": "index.md",
|
|
}
|
|
|
|
|
|
@patch("docsgpt.parser.remote.crawler_loader.validate_url", side_effect=_mock_validate_url)
|
|
@patch("docsgpt.parser.remote.crawler_loader.pinned_request")
|
|
def test_load_data_respects_limit(mock_pinned_request, mock_validate_url):
|
|
responses = {
|
|
"http://example.com": DummyResponse(
|
|
"""
|
|
<html>
|
|
<body>
|
|
<a href='/about'>About</a>
|
|
</body>
|
|
</html>
|
|
"""
|
|
),
|
|
"http://example.com/about": DummyResponse("<html><body>About</body></html>"),
|
|
}
|
|
|
|
mock_pinned_request.side_effect = lambda _method, url, timeout=30: responses[url]
|
|
|
|
crawler = CrawlerLoader(limit=1)
|
|
|
|
result = crawler.load_data("http://example.com")
|
|
|
|
assert len(result) == 1
|
|
assert result[0].text == "About"
|
|
assert mock_pinned_request.call_count == 1
|
|
|
|
|
|
@patch("docsgpt.parser.remote.crawler_loader.validate_url", side_effect=_mock_validate_url)
|
|
@patch("docsgpt.parser.remote.crawler_loader.logging")
|
|
@patch("docsgpt.parser.remote.crawler_loader.pinned_request")
|
|
def test_load_data_logs_and_skips_on_request_error(mock_pinned_request, mock_logging, mock_validate_url):
|
|
mock_pinned_request.side_effect = Exception("load failure")
|
|
crawler = CrawlerLoader()
|
|
|
|
result = crawler.load_data("http://example.com")
|
|
|
|
assert result == []
|
|
mock_pinned_request.assert_called_once_with("GET", "http://example.com", timeout=30)
|
|
|
|
mock_logging.error.assert_called_once()
|
|
message, = mock_logging.error.call_args.args
|
|
assert "Error processing URL http://example.com" in message
|
|
assert mock_logging.error.call_args.kwargs.get("exc_info") is True
|
|
|
|
|
|
@patch("docsgpt.parser.remote.crawler_loader.validate_url")
|
|
def test_load_data_returns_empty_on_ssrf_validation_failure(mock_validate_url):
|
|
"""Test that SSRF validation failure returns empty list."""
|
|
from docsgpt.core.url_validation import SSRFError
|
|
mock_validate_url.side_effect = SSRFError("Access to private IP not allowed")
|
|
|
|
crawler = CrawlerLoader()
|
|
result = crawler.load_data("http://192.168.1.1")
|
|
|
|
assert result == []
|
|
mock_validate_url.assert_called_once()
|
|
|
|
|
|
def test_url_to_virtual_path_variants():
|
|
crawler = CrawlerLoader()
|
|
|
|
assert crawler._url_to_virtual_path("https://docs.docsgpt.cloud/") == "index.md"
|
|
assert (
|
|
crawler._url_to_virtual_path("https://docs.docsgpt.cloud/guides/setup")
|
|
== "guides/setup.md"
|
|
)
|
|
assert (
|
|
crawler._url_to_virtual_path("https://docs.docsgpt.cloud/guides/setup/")
|
|
== "guides/setup.md"
|
|
)
|
|
assert crawler._url_to_virtual_path("https://example.com/page.html") == "page.md"
|
|
|
|
|
|
# =====================================================================
|
|
# Coverage gap tests (lines 41-43)
|
|
# =====================================================================
|
|
|
|
|
|
@pytest.mark.unit
|
|
class TestCrawlerLoaderGaps:
|
|
def test_pinned_fetch_builds_document_without_webbase_loader(self):
|
|
"""The crawler should index the response body it already fetched."""
|
|
from docsgpt.parser.remote.crawler_loader import CrawlerLoader
|
|
|
|
loader = CrawlerLoader(limit=5)
|
|
with patch(
|
|
"docsgpt.parser.remote.crawler_loader.validate_url",
|
|
return_value="https://example.com",
|
|
):
|
|
with patch(
|
|
"docsgpt.parser.remote.crawler_loader.pinned_request"
|
|
) as mock_pinned_request:
|
|
mock_response = MagicMock()
|
|
mock_response.status_code = 200
|
|
mock_response.text = "<html><body>test</body></html>"
|
|
mock_response.raise_for_status.return_value = None
|
|
mock_pinned_request.return_value = mock_response
|
|
|
|
result = loader.load_data("https://example.com")
|
|
assert result[0].text == "test"
|