mirror of
https://github.com/tiennm99/DocsGPT.git
synced 2026-10-03 17:11:24 +00:00
81b6ee5daa
* feat: postgres tests * feat: mongo cutoff * feat: mongo cutoff * feat: adjust docs and compose files * fix: mini code mongo removals * fix: tests and k8s mongo stuff * feat: test fixes * fix: ruff * fix: vale * Potential fix for pull request finding 'CodeQL / Clear-text logging of sensitive information' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * fix: mini suggestions * vale lint fix 2 * fix: codeql columns thing * fix: test mongo * fix: tests coverage * feat: better tests 4 * feat: more tests * feat: decent coverage * fix: ruff fixes * fix: remove mongo mock * feat: enhance workflow engine and API routes; add document retrieval and source handling * feat: e2e tests * fix: mcp, mongo and more * fix: mini codeql warning * fix: agent chunk view * fix: mini issues * fix: more pg fixes * feat: postgres prep on start * feat: qa tests * fix: mini improvements * fix: tests --------- Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Co-authored-by: Siddhant Rai <siddhant.rai.5686@gmail.com>
628 lines
20 KiB
Python
628 lines
20 KiB
Python
import datetime
|
|
import uuid
|
|
from unittest.mock import Mock, patch
|
|
|
|
import pytest
|
|
from flask import Flask
|
|
|
|
pytestmark = pytest.mark.skip(
|
|
reason="Asserts Mongo-era agent_folders_collection call shapes; needs PG repository-based "
|
|
"rewrite. Tracked as migration debt."
|
|
)
|
|
|
|
|
|
@pytest.fixture
|
|
def app():
|
|
app = Flask(__name__)
|
|
return app
|
|
|
|
|
|
@pytest.mark.unit
|
|
class TestAgentFoldersGet:
|
|
|
|
def test_returns_folders(self, app):
|
|
from application.api.user.agents.folders import AgentFolders
|
|
|
|
now = datetime.datetime(2024, 6, 15, tzinfo=datetime.timezone.utc)
|
|
folder_id = uuid.uuid4().hex
|
|
mock_collection = Mock()
|
|
mock_collection.find.return_value = [
|
|
{
|
|
"_id": folder_id,
|
|
"name": "My Folder",
|
|
"parent_id": None,
|
|
"created_at": now,
|
|
"updated_at": now,
|
|
}
|
|
]
|
|
|
|
with patch(
|
|
"application.api.user.agents.folders.agent_folders_collection",
|
|
mock_collection,
|
|
):
|
|
with app.test_request_context("/api/agents/folders/", method="GET"):
|
|
from flask import request
|
|
|
|
request.decoded_token = {"sub": "user1"}
|
|
response = AgentFolders().get()
|
|
|
|
assert response.status_code == 200
|
|
folders = response.json["folders"]
|
|
assert len(folders) == 1
|
|
assert folders[0]["id"] == str(folder_id)
|
|
assert folders[0]["name"] == "My Folder"
|
|
|
|
def test_returns_401_unauthenticated(self, app):
|
|
from application.api.user.agents.folders import AgentFolders
|
|
|
|
with app.test_request_context("/api/agents/folders/", method="GET"):
|
|
from flask import request
|
|
|
|
request.decoded_token = None
|
|
response = AgentFolders().get()
|
|
|
|
assert response.status_code == 401
|
|
|
|
|
|
@pytest.mark.unit
|
|
class TestAgentFoldersCreate:
|
|
|
|
def test_creates_folder(self, app):
|
|
from application.api.user.agents.folders import AgentFolders
|
|
|
|
inserted_id = uuid.uuid4().hex
|
|
mock_collection = Mock()
|
|
mock_collection.insert_one.return_value = Mock(inserted_id=inserted_id)
|
|
|
|
with patch(
|
|
"application.api.user.agents.folders.agent_folders_collection",
|
|
mock_collection,
|
|
):
|
|
with app.test_request_context(
|
|
"/api/agents/folders/",
|
|
method="POST",
|
|
json={"name": "New Folder"},
|
|
):
|
|
from flask import request
|
|
|
|
request.decoded_token = {"sub": "user1"}
|
|
response = AgentFolders().post()
|
|
|
|
assert response.status_code == 201
|
|
assert response.json["id"] == str(inserted_id)
|
|
assert response.json["name"] == "New Folder"
|
|
|
|
def test_returns_400_missing_name(self, app):
|
|
from application.api.user.agents.folders import AgentFolders
|
|
|
|
with app.test_request_context(
|
|
"/api/agents/folders/",
|
|
method="POST",
|
|
json={},
|
|
):
|
|
from flask import request
|
|
|
|
request.decoded_token = {"sub": "user1"}
|
|
response = AgentFolders().post()
|
|
|
|
assert response.status_code == 400
|
|
|
|
def test_validates_parent_folder_exists(self, app):
|
|
from application.api.user.agents.folders import AgentFolders
|
|
|
|
mock_collection = Mock()
|
|
mock_collection.find_one.return_value = None
|
|
|
|
with patch(
|
|
"application.api.user.agents.folders.agent_folders_collection",
|
|
mock_collection,
|
|
):
|
|
with app.test_request_context(
|
|
"/api/agents/folders/",
|
|
method="POST",
|
|
json={"name": "Sub", "parent_id": str(uuid.uuid4().hex)},
|
|
):
|
|
from flask import request
|
|
|
|
request.decoded_token = {"sub": "user1"}
|
|
response = AgentFolders().post()
|
|
|
|
assert response.status_code == 404
|
|
|
|
|
|
@pytest.mark.unit
|
|
class TestAgentFolderGet:
|
|
|
|
def test_returns_folder_with_agents_and_subfolders(self, app):
|
|
from application.api.user.agents.folders import AgentFolder
|
|
|
|
folder_id = uuid.uuid4().hex
|
|
agent_id = uuid.uuid4().hex
|
|
subfolder_id = uuid.uuid4().hex
|
|
mock_folders = Mock()
|
|
mock_folders.find_one.return_value = {
|
|
"_id": folder_id,
|
|
"name": "Folder",
|
|
"parent_id": None,
|
|
}
|
|
mock_folders.find.return_value = [
|
|
{"_id": subfolder_id, "name": "Subfolder"}
|
|
]
|
|
mock_agents = Mock()
|
|
mock_agents.find.return_value = [
|
|
{"_id": agent_id, "name": "Agent 1", "description": "Desc"}
|
|
]
|
|
|
|
with patch(
|
|
"application.api.user.agents.folders.agent_folders_collection",
|
|
mock_folders,
|
|
), patch(
|
|
"application.api.user.agents.folders.agents_collection",
|
|
mock_agents,
|
|
):
|
|
with app.test_request_context(
|
|
f"/api/agents/folders/{folder_id}", method="GET"
|
|
):
|
|
from flask import request
|
|
|
|
request.decoded_token = {"sub": "user1"}
|
|
response = AgentFolder().get(str(folder_id))
|
|
|
|
assert response.status_code == 200
|
|
assert response.json["name"] == "Folder"
|
|
assert len(response.json["agents"]) == 1
|
|
assert len(response.json["subfolders"]) == 1
|
|
|
|
def test_returns_404_not_found(self, app):
|
|
from application.api.user.agents.folders import AgentFolder
|
|
|
|
mock_collection = Mock()
|
|
mock_collection.find_one.return_value = None
|
|
|
|
with patch(
|
|
"application.api.user.agents.folders.agent_folders_collection",
|
|
mock_collection,
|
|
):
|
|
with app.test_request_context(
|
|
f"/api/agents/folders/{uuid.uuid4().hex}", method="GET"
|
|
):
|
|
from flask import request
|
|
|
|
request.decoded_token = {"sub": "user1"}
|
|
response = AgentFolder().get(str(uuid.uuid4().hex))
|
|
|
|
assert response.status_code == 404
|
|
|
|
|
|
@pytest.mark.unit
|
|
class TestAgentFolderUpdate:
|
|
|
|
def test_updates_folder_name(self, app):
|
|
from application.api.user.agents.folders import AgentFolder
|
|
|
|
folder_id = uuid.uuid4().hex
|
|
mock_collection = Mock()
|
|
mock_collection.update_one.return_value = Mock(matched_count=1)
|
|
|
|
with patch(
|
|
"application.api.user.agents.folders.agent_folders_collection",
|
|
mock_collection,
|
|
):
|
|
with app.test_request_context(
|
|
f"/api/agents/folders/{folder_id}",
|
|
method="PUT",
|
|
json={"name": "Renamed"},
|
|
):
|
|
from flask import request
|
|
|
|
request.decoded_token = {"sub": "user1"}
|
|
response = AgentFolder().put(str(folder_id))
|
|
|
|
assert response.status_code == 200
|
|
assert response.json["success"] is True
|
|
|
|
def test_prevents_self_parent(self, app):
|
|
from application.api.user.agents.folders import AgentFolder
|
|
|
|
folder_id = str(uuid.uuid4().hex)
|
|
|
|
with app.test_request_context(
|
|
f"/api/agents/folders/{folder_id}",
|
|
method="PUT",
|
|
json={"parent_id": folder_id},
|
|
):
|
|
from flask import request
|
|
|
|
request.decoded_token = {"sub": "user1"}
|
|
response = AgentFolder().put(folder_id)
|
|
|
|
assert response.status_code == 400
|
|
assert "own parent" in response.json["message"]
|
|
|
|
def test_returns_404_when_not_found(self, app):
|
|
from application.api.user.agents.folders import AgentFolder
|
|
|
|
mock_collection = Mock()
|
|
mock_collection.update_one.return_value = Mock(matched_count=0)
|
|
|
|
with patch(
|
|
"application.api.user.agents.folders.agent_folders_collection",
|
|
mock_collection,
|
|
):
|
|
with app.test_request_context(
|
|
f"/api/agents/folders/{uuid.uuid4().hex}",
|
|
method="PUT",
|
|
json={"name": "X"},
|
|
):
|
|
from flask import request
|
|
|
|
request.decoded_token = {"sub": "user1"}
|
|
response = AgentFolder().put(str(uuid.uuid4().hex))
|
|
|
|
assert response.status_code == 404
|
|
|
|
|
|
@pytest.mark.unit
|
|
class TestAgentFolderDelete:
|
|
|
|
def test_deletes_folder_and_unsets_references(self, app):
|
|
from application.api.user.agents.folders import AgentFolder
|
|
|
|
folder_id = str(uuid.uuid4().hex)
|
|
mock_folders = Mock()
|
|
mock_folders.delete_one.return_value = Mock(deleted_count=1)
|
|
mock_agents = Mock()
|
|
|
|
with patch(
|
|
"application.api.user.agents.folders.agent_folders_collection",
|
|
mock_folders,
|
|
), patch(
|
|
"application.api.user.agents.folders.agents_collection",
|
|
mock_agents,
|
|
):
|
|
with app.test_request_context(
|
|
f"/api/agents/folders/{folder_id}", method="DELETE"
|
|
):
|
|
from flask import request
|
|
|
|
request.decoded_token = {"sub": "user1"}
|
|
response = AgentFolder().delete(folder_id)
|
|
|
|
assert response.status_code == 200
|
|
mock_agents.update_many.assert_called_once()
|
|
mock_folders.update_many.assert_called_once()
|
|
mock_folders.delete_one.assert_called_once()
|
|
|
|
def test_returns_404_not_found(self, app):
|
|
from application.api.user.agents.folders import AgentFolder
|
|
|
|
mock_folders = Mock()
|
|
mock_folders.delete_one.return_value = Mock(deleted_count=0)
|
|
mock_agents = Mock()
|
|
|
|
with patch(
|
|
"application.api.user.agents.folders.agent_folders_collection",
|
|
mock_folders,
|
|
), patch(
|
|
"application.api.user.agents.folders.agents_collection",
|
|
mock_agents,
|
|
):
|
|
with app.test_request_context(
|
|
f"/api/agents/folders/{uuid.uuid4().hex}", method="DELETE"
|
|
):
|
|
from flask import request
|
|
|
|
request.decoded_token = {"sub": "user1"}
|
|
response = AgentFolder().delete(str(uuid.uuid4().hex))
|
|
|
|
assert response.status_code == 404
|
|
|
|
|
|
@pytest.mark.unit
|
|
class TestMoveAgentToFolder:
|
|
|
|
def test_moves_agent_to_folder(self, app):
|
|
from application.api.user.agents.folders import MoveAgentToFolder
|
|
|
|
agent_id = uuid.uuid4().hex
|
|
folder_id = uuid.uuid4().hex
|
|
mock_agents = Mock()
|
|
mock_agents.find_one.return_value = {"_id": agent_id, "user": "user1"}
|
|
mock_folders = Mock()
|
|
mock_folders.find_one.return_value = {"_id": folder_id}
|
|
|
|
with patch(
|
|
"application.api.user.agents.folders.agents_collection",
|
|
mock_agents,
|
|
), patch(
|
|
"application.api.user.agents.folders.agent_folders_collection",
|
|
mock_folders,
|
|
):
|
|
with app.test_request_context(
|
|
"/api/agents/folders/move_agent",
|
|
method="POST",
|
|
json={
|
|
"agent_id": str(agent_id),
|
|
"folder_id": str(folder_id),
|
|
},
|
|
):
|
|
from flask import request
|
|
|
|
request.decoded_token = {"sub": "user1"}
|
|
response = MoveAgentToFolder().post()
|
|
|
|
assert response.status_code == 200
|
|
mock_agents.update_one.assert_called_once()
|
|
|
|
def test_removes_agent_from_folder(self, app):
|
|
from application.api.user.agents.folders import MoveAgentToFolder
|
|
|
|
agent_id = uuid.uuid4().hex
|
|
mock_agents = Mock()
|
|
mock_agents.find_one.return_value = {"_id": agent_id, "user": "user1"}
|
|
|
|
with patch(
|
|
"application.api.user.agents.folders.agents_collection",
|
|
mock_agents,
|
|
):
|
|
with app.test_request_context(
|
|
"/api/agents/folders/move_agent",
|
|
method="POST",
|
|
json={"agent_id": str(agent_id), "folder_id": None},
|
|
):
|
|
from flask import request
|
|
|
|
request.decoded_token = {"sub": "user1"}
|
|
response = MoveAgentToFolder().post()
|
|
|
|
assert response.status_code == 200
|
|
call_args = mock_agents.update_one.call_args
|
|
assert "$unset" in call_args[0][1]
|
|
|
|
def test_returns_404_agent_not_found(self, app):
|
|
from application.api.user.agents.folders import MoveAgentToFolder
|
|
|
|
mock_agents = Mock()
|
|
mock_agents.find_one.return_value = None
|
|
|
|
with patch(
|
|
"application.api.user.agents.folders.agents_collection",
|
|
mock_agents,
|
|
):
|
|
with app.test_request_context(
|
|
"/api/agents/folders/move_agent",
|
|
method="POST",
|
|
json={"agent_id": str(uuid.uuid4().hex)},
|
|
):
|
|
from flask import request
|
|
|
|
request.decoded_token = {"sub": "user1"}
|
|
response = MoveAgentToFolder().post()
|
|
|
|
assert response.status_code == 404
|
|
|
|
def test_returns_400_missing_agent_id(self, app):
|
|
from application.api.user.agents.folders import MoveAgentToFolder
|
|
|
|
with app.test_request_context(
|
|
"/api/agents/folders/move_agent",
|
|
method="POST",
|
|
json={},
|
|
):
|
|
from flask import request
|
|
|
|
request.decoded_token = {"sub": "user1"}
|
|
response = MoveAgentToFolder().post()
|
|
|
|
assert response.status_code == 400
|
|
|
|
|
|
@pytest.mark.unit
|
|
class TestBulkMoveAgents:
|
|
|
|
def test_bulk_moves_to_folder(self, app):
|
|
from application.api.user.agents.folders import BulkMoveAgents
|
|
|
|
folder_id = uuid.uuid4().hex
|
|
agent_ids = [str(uuid.uuid4().hex), str(uuid.uuid4().hex)]
|
|
mock_agents = Mock()
|
|
mock_folders = Mock()
|
|
mock_folders.find_one.return_value = {"_id": folder_id}
|
|
|
|
with patch(
|
|
"application.api.user.agents.folders.agents_collection",
|
|
mock_agents,
|
|
), patch(
|
|
"application.api.user.agents.folders.agent_folders_collection",
|
|
mock_folders,
|
|
):
|
|
with app.test_request_context(
|
|
"/api/agents/folders/bulk_move",
|
|
method="POST",
|
|
json={"agent_ids": agent_ids, "folder_id": str(folder_id)},
|
|
):
|
|
from flask import request
|
|
|
|
request.decoded_token = {"sub": "user1"}
|
|
response = BulkMoveAgents().post()
|
|
|
|
assert response.status_code == 200
|
|
mock_agents.update_many.assert_called_once()
|
|
|
|
def test_bulk_removes_from_folders(self, app):
|
|
from application.api.user.agents.folders import BulkMoveAgents
|
|
|
|
agent_ids = [str(uuid.uuid4().hex)]
|
|
mock_agents = Mock()
|
|
|
|
with patch(
|
|
"application.api.user.agents.folders.agents_collection",
|
|
mock_agents,
|
|
):
|
|
with app.test_request_context(
|
|
"/api/agents/folders/bulk_move",
|
|
method="POST",
|
|
json={"agent_ids": agent_ids},
|
|
):
|
|
from flask import request
|
|
|
|
request.decoded_token = {"sub": "user1"}
|
|
response = BulkMoveAgents().post()
|
|
|
|
assert response.status_code == 200
|
|
call_args = mock_agents.update_many.call_args
|
|
assert "$unset" in call_args[0][1]
|
|
|
|
def test_returns_400_missing_agent_ids(self, app):
|
|
from application.api.user.agents.folders import BulkMoveAgents
|
|
|
|
with app.test_request_context(
|
|
"/api/agents/folders/bulk_move",
|
|
method="POST",
|
|
json={},
|
|
):
|
|
from flask import request
|
|
|
|
request.decoded_token = {"sub": "user1"}
|
|
response = BulkMoveAgents().post()
|
|
|
|
assert response.status_code == 400
|
|
|
|
def test_returns_404_folder_not_found(self, app):
|
|
from application.api.user.agents.folders import BulkMoveAgents
|
|
|
|
mock_folders = Mock()
|
|
mock_folders.find_one.return_value = None
|
|
|
|
with patch(
|
|
"application.api.user.agents.folders.agent_folders_collection",
|
|
mock_folders,
|
|
):
|
|
with app.test_request_context(
|
|
"/api/agents/folders/bulk_move",
|
|
method="POST",
|
|
json={
|
|
"agent_ids": [str(uuid.uuid4().hex)],
|
|
"folder_id": str(uuid.uuid4().hex),
|
|
},
|
|
):
|
|
from flask import request
|
|
|
|
request.decoded_token = {"sub": "user1"}
|
|
response = BulkMoveAgents().post()
|
|
|
|
assert response.status_code == 404
|
|
|
|
|
|
# =====================================================================
|
|
# Coverage gap tests (lines 64, 90-91, 100, 125-126, 132, 136)
|
|
# =====================================================================
|
|
|
|
|
|
@pytest.mark.unit
|
|
class TestAgentFoldersGaps:
|
|
|
|
def test_create_folder_no_auth(self, app):
|
|
"""Cover line 64: post returns 401 when no decoded_token."""
|
|
from application.api.user.agents.folders import AgentFolders
|
|
|
|
with app.test_request_context(
|
|
"/api/agents/folders/",
|
|
method="POST",
|
|
json={"name": "Test"},
|
|
):
|
|
from flask import request
|
|
|
|
request.decoded_token = None
|
|
response = AgentFolders().post()
|
|
assert response.status_code == 401
|
|
|
|
def test_create_folder_exception(self, app):
|
|
"""Cover lines 90-91: exception during insert_one returns 400."""
|
|
from application.api.user.agents.folders import AgentFolders
|
|
|
|
mock_folders = Mock()
|
|
mock_folders.find_one.return_value = None
|
|
mock_folders.insert_one.side_effect = Exception("db error")
|
|
|
|
with patch(
|
|
"application.api.user.agents.folders.agent_folders_collection",
|
|
mock_folders,
|
|
):
|
|
with app.test_request_context(
|
|
"/api/agents/folders/",
|
|
method="POST",
|
|
json={"name": "Test"},
|
|
):
|
|
from flask import request
|
|
|
|
request.decoded_token = {"sub": "user1"}
|
|
response = AgentFolders().post()
|
|
assert response.status_code == 400
|
|
|
|
def test_get_folder_no_auth(self, app):
|
|
"""Cover line 100: get specific folder returns 401 when no auth."""
|
|
from application.api.user.agents.folders import AgentFolder
|
|
|
|
with app.test_request_context(
|
|
"/api/agents/folders/abc",
|
|
method="GET",
|
|
):
|
|
from flask import request
|
|
|
|
request.decoded_token = None
|
|
response = AgentFolder().get("abc")
|
|
assert response.status_code == 401
|
|
|
|
def test_get_folder_exception(self, app):
|
|
"""Cover lines 125-126: exception during find returns 400."""
|
|
from application.api.user.agents.folders import AgentFolder
|
|
|
|
mock_folders = Mock()
|
|
mock_folders.find_one.side_effect = Exception("db error")
|
|
|
|
with patch(
|
|
"application.api.user.agents.folders.agent_folders_collection",
|
|
mock_folders,
|
|
):
|
|
with app.test_request_context(
|
|
"/api/agents/folders/" + str(uuid.uuid4().hex),
|
|
method="GET",
|
|
):
|
|
from flask import request
|
|
|
|
request.decoded_token = {"sub": "user1"}
|
|
response = AgentFolder().get(str(uuid.uuid4().hex))
|
|
assert response.status_code == 400
|
|
|
|
def test_update_folder_no_auth(self, app):
|
|
"""Cover line 132: put returns 401 when no decoded_token."""
|
|
from application.api.user.agents.folders import AgentFolder
|
|
|
|
with app.test_request_context(
|
|
"/api/agents/folders/abc",
|
|
method="PUT",
|
|
json={"name": "Updated"},
|
|
):
|
|
from flask import request
|
|
|
|
request.decoded_token = None
|
|
response = AgentFolder().put("abc")
|
|
assert response.status_code == 401
|
|
|
|
def test_update_folder_no_data(self, app):
|
|
"""Cover line 136: put with no data returns 400."""
|
|
from application.api.user.agents.folders import AgentFolder
|
|
|
|
with app.test_request_context(
|
|
"/api/agents/folders/abc",
|
|
method="PUT",
|
|
content_type="application/json",
|
|
data="null",
|
|
):
|
|
from flask import request
|
|
|
|
request.decoded_token = {"sub": "user1"}
|
|
response = AgentFolder().put("abc")
|
|
assert response.status_code == 400
|