Source access control --------------------- `active_docs` is client-supplied and reached the retriever unchecked, and the retriever queries `WHERE source_id = <id>` with no owner predicate — so any caller could pass any source id to /stream or /api/answer and have another tenant's documents quoted back, while /api/sources/<id>/search correctly refused the same id. Gate it through `can_access`, the helper the guarded endpoints already use, and filter `self.source` down to the authorized set. Fails closed: no principal, or a check that errors, drops the source. Three sibling paths had the same gap: - workflow agent nodes: `AgentNodeConfig.sources` is written verbatim from client JSON at save time and nothing validated it, so a node could name any tenant's source. Gate against the workflow owner, so shared workflows keep reading their owner's sources like shared agents do. - /api/share: `_resolve_source_pg_id` resolved any id with no ownership predicate and baked it into the agent the share creates; /api/search then searched it. Authorize before attaching. - search_service: re-resolve the ids stored on an agent row instead of trusting them, so a row written by any future path with the same gap cannot be read back. Team grantees previously lost their source's retrieval config: the post-check read was still owner-scoped, so it missed and fell back to defaults (an `agentic_tool` source was bulk-prefetched for every grantee). Read unscoped after `can_access` passes. Retrieval --------- `PGVectorStore._ensure_table_exists` created an IVFFlat index on the empty table it had just created. IVFFlat computes centroids at build time, so those centroids were random, and combined with the `source_id` post-filter a source with hundreds of embedded chunks returned zero rows — retrieval reported no documents, the model answered from memory, and nothing was logged. Stop creating the index (exact search is correct and fast well past the sizes most deployments reach); raise `ivfflat.probes` to sqrt(lists) where an index still exists; and re-run a short indexed search exactly, since post-filtering means no index setting can guarantee a full result. `graphrag` had the same empty-table index with no fallback at all. Also: bound `chunks` to 0-500 on both the request and agent paths (0 still means "skip retrieval"), let a source's configured `retrieval.chunks` outrank the request body, and cap ClassicRAG's per-source floor at max(top_k, n_sources) so attaching sources cannot inflate the result set. Silent failures --------------- An empty retrieval was invisible to both the model and the client: the `source` event was suppressed when the list was empty, so "searched and found nothing" looked identical to "no source attached", and the prompt said nothing at all. Emit the event always, and tell the model when a search ran and returned nothing. A file that parses to nothing now fails ingest with a message naming the cause instead of storing an embedding of the empty string. `score_threshold` returns warnings when the active store or retriever cannot honour it. Prompt structure ---------------- Retrieved documents move from the system prompt into the user turn, with the injection guard restated next to them: they change every turn (defeating prefix caching), they are third-party text that should not carry system authority, and routing them through the query budget makes them truncatable rather than silently crowding it out. Documents are shed lowest-ranked-first before the question is touched. The six chat presets (3 tones x 2 retrieval modes) differed only in their Answering section; they are now composed from single-source fragments at load time, not through Jinja inheritance, which would have opened a file-read surface in the template sandbox and broken the tool-prefetch parser. Per-tool guidance moves out of the prompt into tool schemas, so it travels with the tool and cannot render when the tool is absent. A plain-text custom prompt is staged as a persona value inside the skeleton instead of replacing it wholesale — it used to silently lose the injection guard, platform block, memory and attachments, and its braces are now inert. Other fixes ----------- - agents/base: an oversized system prompt drove the query budget negative and dispatched a full-price request with an empty question; raise instead. - llm/anthropic: migrate off the retired Text Completions API. It flattened history to first+last message and ignored tools entirely. Adds the missing Anthropic handler, without which every tool call was silently dropped. - sources/upload: `sitemap` had no branch, so every sitemap ingest died on a TypeError; `validate_url` now rejects a falsy URL cleanly. - workflow nodes: retrieved documents never reached the node agent, so a classic node with a source and an ordinary prompt answered "I have no documents" while the run reported completed. - parser/bulk: copy the metadata dict, or every chunk reports the last chunk's token_count. - crawler_loader: carry the page title, or citations render the whole chunk body as the label.
Model catalogs
Each *.yaml file in this directory declares one provider's model
catalog. The registry loads every YAML at boot and joins it to the
matching provider plugin under application/llm/providers/.
To add or edit models, you almost always only touch a YAML here — no Python code required.
Add a model to an existing provider
Open the provider's YAML (e.g. anthropic.yaml) and append two lines
under models::
models:
- id: claude-3-7-sonnet
display_name: Claude 3.7 Sonnet
Capabilities default to the provider's defaults: block. Override
per-model only when needed:
- id: claude-3-7-sonnet
display_name: Claude 3.7 Sonnet
context_window: 500000
Restart the app. The new model appears in /api/models.
The model
idis what gets stored in agent / workflow records. Once users start picking the model, don't rename it — agent and workflow rows reference it as a free-form string and silently fall back to the system default if the id disappears.
Add an OpenAI-compatible provider (zero Python)
Drop a YAML in this directory (or in your MODELS_CONFIG_DIR) that uses
the openai_compatible plugin. Set the env var named in api_key_env
and you're done — no Python, no settings.py edit, no LLMCreator change:
# mistral.yaml
provider: openai_compatible
display_provider: mistral # shown in /api/models response
api_key_env: MISTRAL_API_KEY # env var the plugin reads at boot
base_url: https://api.mistral.ai/v1
defaults:
supports_tools: true
context_window: 128000
models:
- id: mistral-large-latest
display_name: Mistral Large
- id: mistral-small-latest
display_name: Mistral Small
MISTRAL_API_KEY=sk-... ; restart — Mistral models appear in
/api/models with provider: "mistral". They route through the OpenAI
wire format (it's OpenAILLM under the hood) but with Mistral's
endpoint and key.
Multiple openai_compatible YAMLs coexist: each file is one logical
endpoint with its own api_key_env and base_url. Drop in
together.yaml, fireworks.yaml, etc. side by side. If an env var
isn't set, that catalog is silently skipped at boot (logged at INFO) —
no error.
Working example: examples/mistral.yaml.example. Files inside
examples/ aren't loaded by the registry; the glob only picks up
*.yaml at the top level.
Add a provider with its own SDK
For a provider that doesn't speak OpenAI's wire format, add one Python
file to application/llm/providers/<name>.py:
from application.llm.providers.base import Provider
from application.llm.my_provider import MyLLM
class MyProvider(Provider):
name = "my_provider"
llm_class = MyLLM
def get_api_key(self, settings):
return settings.MY_PROVIDER_API_KEY
Register it in application/llm/providers/__init__.py (one line in
ALL_PROVIDERS), add MY_PROVIDER_API_KEY to settings.py, and create
my_provider.yaml here with the model catalog.
Schema reference
provider: <string, required> # matches the Provider plugin's `name`
# openai_compatible only — required for that provider, ignored for others
display_provider: <string> # label shown in /api/models response
api_key_env: <string> # name of the env var carrying the key
base_url: <string> # endpoint URL
defaults: # optional, applied to every model below
supports_tools: bool # default false
supports_structured_output: bool # default false
supports_streaming: bool # default true
attachments: [<alias-or-mime>, ...] # default []
context_window: int # default 128000
input_cost_per_token: float # default null
output_cost_per_token: float # default null
reasoning_effort: <string> # default null; none|minimal|low|medium|high|xhigh (subset is model-dependent)
api_flavor: <string> # chat_completions (default) or responses
models: # required
- id: <string, required> # unique registry key; persisted in agent records
display_name: <string> # default: id
description: <string> # default: ""
enabled: bool # default true; false hides from /api/models
base_url: <string> # optional custom endpoint for this model
upstream_model_id: <string> # default: id; the name actually sent to the provider
# All `defaults:` fields above can be overridden here per-model.
Reasoning effort, and one model at multiple efforts
reasoning_effort is forwarded to the provider for OpenAI reasoning
models. Accepted values are none, minimal, low, medium, high,
and xhigh, but the subset each model accepts varies (older o-series
take only low/medium/high; GPT-5.5 adds xhigh) — check the model
page. Set it per-model; sending it to a non-reasoning model is rejected
by the API:
- id: gpt-5.4-mini
display_name: GPT-5.4 Mini
reasoning_effort: medium
To expose the same upstream model at two efforts, give each entry a
distinct id and point both at one upstream_model_id. The id is the
unique registry key (and what's stored in agent records); the
upstream_model_id is the name actually sent to the provider, defaulting
to id when omitted:
- id: gpt-5.4-mini-low
display_name: GPT-5.4 Mini (Low Reasoning)
upstream_model_id: gpt-5.4-mini
reasoning_effort: low
- id: gpt-5.4-mini-high
display_name: GPT-5.4 Mini (High Reasoning)
upstream_model_id: gpt-5.4-mini
reasoning_effort: high
Both call gpt-5.4-mini on the wire; token usage is attributed to the
distinct ids, so cost dashboards split by reasoning level.
Attachment aliases
The attachments: list can mix human-readable aliases with raw MIME
types. Aliases are defined in _defaults.yaml:
| Alias | Expands to |
|---|---|
image |
image/png, image/jpeg, image/jpg, image/webp, image/gif |
pdf |
application/pdf |
audio |
audio/mpeg, audio/wav, audio/ogg |
Use raw MIME types when you need surgical control:
attachments: [image/png, image/webp] # only these two
Operator-supplied YAMLs (MODELS_CONFIG_DIR)
Set the MODELS_CONFIG_DIR env var (or .env entry) to a directory
path. Every *.yaml in that directory is loaded after the built-in
catalog under application/core/models/. Operators use this to:
- Add new
openai_compatibleproviders (Mistral, Together, Fireworks, Ollama, ...) without forking the repo. - Extend an existing provider's catalog with extra models — append
models under
provider: anthropicand they show up alongside the built-ins. - Override a built-in model's capabilities — declare the same
idwith different fields (e.g. a highercontext_window). Later wins; the override is logged as aWARNINGso you can audit it.
Things you cannot do via MODELS_CONFIG_DIR:
- Add a brand-new non-OpenAI provider — that needs a Python plugin
under
application/llm/providers/(see "Add a provider with its own SDK" above). Operator YAMLs may only target aprovider:value that already has a registered plugin.
Example: Docker
Mount your model YAMLs into the container and point the env var at the mount path:
# docker-compose.yml
services:
app:
image: arc53/docsgpt
environment:
MODELS_CONFIG_DIR: /etc/docsgpt/models
MISTRAL_API_KEY: ${MISTRAL_API_KEY}
volumes:
- ./my-models:/etc/docsgpt/models:ro
Then ./my-models/mistral.yaml (the file from
examples/mistral.yaml.example) gets picked up at boot.
Example: Kubernetes
Mount a ConfigMap containing your YAMLs at a known path and set
MODELS_CONFIG_DIR on the deployment. The same examples/mistral.yaml.example
becomes a key in the ConfigMap.
Misconfiguration
If MODELS_CONFIG_DIR is set but the path doesn't exist (or isn't a
directory), the app logs a WARNING at boot and continues with just
the built-in catalog. The app does not fail to start — operators can
ship config drift without taking down the service — but the warning is
loud enough to surface in any reasonable log aggregator.
Validation
YAMLs are parsed with Pydantic at boot. The app fails to start with a clear error message if:
- a top-level key is unknown
- a model is missing
id - an attachment alias isn't defined
- the
provider:value isn't registered as a plugin
This is intentional — silent fallbacks would mean users don't notice their model picks broke until they hit the API.
Reserved fields (not yet implemented)
aliases:on a model — old IDs that resolve to this model. Reserved for future renames; the schema accepts the field but it is not yet acted on.