From 045fc932857bdc9c52fa7573ec1bbd81a951b6a0 Mon Sep 17 00:00:00 2001
From: Tam Nhu Tran <kaitran.ntt@gmail.com>
Date: Mon, 29 Jun 2026 12:58:38 -0400
Subject: [PATCH] test(glmt): align thinking signature coverage

---
 .../unit/glmt/test-thinking-signature-race.js  | 18 +++++++++---------
 .../sse-stream-transformer.test.ts             |  1 +
 2 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/tests/unit/glmt/test-thinking-signature-race.js b/tests/unit/glmt/test-thinking-signature-race.js
index c9a7b40f..1537ceb5 100755
--- a/tests/unit/glmt/test-thinking-signature-race.js
+++ b/tests/unit/glmt/test-thinking-signature-race.js
@@ -12,6 +12,9 @@
 
 const GlmtTransformer = require('../../../dist/glmt/glmt-transformer').default;
 const { DeltaAccumulator } = require('../../../dist/glmt/delta-accumulator');
+const { ResponseBuilder } = require('../../../dist/glmt/pipeline');
+
+const responseBuilder = new ResponseBuilder(false);
 
 // Test runner
 class TestRunner {
@@ -59,7 +62,6 @@ function assert(condition, message) {
 
 // Test 1: Signature not generated for empty thinking block
 runner.test('Signature not generated for empty thinking block', () => {
-  const transformer = new GlmtTransformer({ verbose: false });
   const accumulator = new DeltaAccumulator({ thinking: true });
 
   // Start thinking block but add no content
@@ -67,7 +69,7 @@ runner.test('Signature not generated for empty thinking block', () => {
   const block = accumulator.startBlock('thinking');
 
   // Try to generate signature for empty block
-  const signatureEvent = transformer._createSignatureDeltaEvent(block);
+  const signatureEvent = responseBuilder.createSignatureDeltaEvent(block);
 
   // Should return null for empty block (fix for race condition)
   assert(signatureEvent === null, 'Expected null for empty thinking block');
@@ -75,7 +77,6 @@ runner.test('Signature not generated for empty thinking block', () => {
 
 // Test 2: Signature generated correctly after content accumulated
 runner.test('Signature generated correctly after content accumulated', () => {
-  const transformer = new GlmtTransformer({ verbose: false });
   const accumulator = new DeltaAccumulator({ thinking: true });
 
   // Start thinking block and add content
@@ -85,15 +86,14 @@ runner.test('Signature generated correctly after content accumulated', () => {
   accumulator.addDelta('Second thinking delta.');
 
   // Generate signature
-  const signatureEvent = transformer._createSignatureDeltaEvent(block);
+  const signatureEvent = responseBuilder.createSignatureDeltaEvent(block);
 
   // Should return valid signature event
   assert(signatureEvent !== null, 'Expected signature event for non-empty block');
   assert(signatureEvent.event === 'content_block_delta', 'Expected content_block_delta event');
   assert(signatureEvent.data.delta.type === 'thinking_signature_delta', 'Expected thinking_signature_delta type');
+  assert(typeof signatureEvent.data.delta.signature === 'string', 'Expected signature string');
   assert(signatureEvent.data.delta.signature.length > 0, 'Expected signature length > 0');
-  assert(signatureEvent.data.delta.signature.hash, 'Expected signature hash');
-  assert(signatureEvent.data.delta.signature.hash.length === 16, 'Expected 16-char hash');
 });
 
 // Test 3: transformDelta skips signature for empty thinking blocks
@@ -179,8 +179,8 @@ runner.test('transformDelta generates signature for non-empty thinking blocks',
 
   // Verify signature structure
   const sig = signatureEvents[0].data.delta.signature;
-  assert(sig.hash && sig.hash.length === 16, 'Expected valid 16-char hash');
-  assert(sig.length > 0, 'Expected content length > 0');
+  assert(typeof sig === 'string', 'Expected signature string');
+  assert(sig.length > 0, 'Expected signature length > 0');
 });
 
 // Test 5: Loop detection handles empty thinking blocks
@@ -217,7 +217,7 @@ runner.test('Loop detection handles empty thinking blocks without signature', ()
 
   const currentBlock = accumulator.getCurrentBlock();
   if (currentBlock && currentBlock.type === 'thinking') {
-    const signatureEvent = transformer._createSignatureDeltaEvent(currentBlock);
+    const signatureEvent = responseBuilder.createSignatureDeltaEvent(currentBlock);
     // Should return null for empty block
     assert(signatureEvent === null, 'Expected null signature for empty thinking block during loop detection');
   }
diff --git a/tests/unit/proxy/transformers/sse-stream-transformer.test.ts b/tests/unit/proxy/transformers/sse-stream-transformer.test.ts
index 61d99223..6a946d78 100644
--- a/tests/unit/proxy/transformers/sse-stream-transformer.test.ts
+++ b/tests/unit/proxy/transformers/sse-stream-transformer.test.ts
@@ -170,5 +170,6 @@ describe('proxy SSE stream transformer', () => {
       typeof signature,
       `expected non-empty string signature, received ${JSON.stringify(signature)}`
     ).toBe('string');
+    expect((signature as string).length).toBeGreaterThan(0);
   });
 });