fix: redact OAuth trace error messages

This commit is contained in:
Kai (Tam Nhu) Tran
2026-05-30 15:28:32 -04:00
committed by GitHub
parent 62a4d44b58
commit 14da76abae
4 changed files with 38 additions and 11 deletions
+7 -4
View File
@@ -82,6 +82,7 @@ import { generateSessionId } from './project-selection-handler';
import { createFileSink } from './oauth-trace/sink-file';
import { createOAuthTraceRecorder, OAuthTracePhase, type OAuthTraceRecorder } from './oauth-trace';
import { diagnoseFailure, formatErrorMessage } from './oauth-trace/diagnose-failure';
import { redactString } from './oauth-trace/redactor';
interface PasteCallbackStartData {
url?: string;
@@ -889,8 +890,9 @@ export async function handlePasteCallbackMode(
if (!callbackResponse.ok || callbackData.status === 'error') {
const callbackError =
callbackData.error || `OAuth callback failed with status ${callbackResponse.status}`;
console.log(fail(callbackError));
warnPossible403Ban(provider, callbackError);
const redactedCallbackError = redactString(callbackError);
console.log(fail(redactedCallbackError));
warnPossible403Ban(provider, redactedCallbackError);
trace.record(
OAuthTracePhase.Error,
{ status: callbackResponse.status },
@@ -915,8 +917,9 @@ export async function handlePasteCallbackMode(
);
if (tokenWaitError) {
console.log(fail(tokenWaitError));
warnPossible403Ban(provider, tokenWaitError);
const redactedTokenWaitError = redactString(tokenWaitError);
console.log(fail(redactedTokenWaitError));
warnPossible403Ban(provider, redactedTokenWaitError);
trace.record(
OAuthTracePhase.Error,
{},