From 26c1393c161a7dfbe7bae7c5c9aff59a0447a002 Mon Sep 17 00:00:00 2001 From: Tam Nhu Tran Date: Fri, 31 Jul 2026 10:32:32 -0400 Subject: [PATCH] ci(review): configure explicit reasoning effort --- .github/workflows/ai-review.yml | 11 ++++++----- CONTRIBUTING.md | 2 +- tests/unit/scripts/github/ai-review-workflow.test.ts | 1 + 3 files changed, 8 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ai-review.yml b/.github/workflows/ai-review.yml index ed6d044d..77db4250 100644 --- a/.github/workflows/ai-review.yml +++ b/.github/workflows/ai-review.yml @@ -99,11 +99,12 @@ jobs: contents: read env: OPENAI_KEY: ${{ secrets.AI_REVIEW_API_KEY }} - "OPENAI.API_BASE": ${{ vars.AI_REVIEW_BASE_URL }} - "config.model": ${{ vars.AI_REVIEW_MODEL }} - "github_action_config.auto_review": "true" - "github_action_config.auto_describe": "false" - "github_action_config.auto_improve": "false" + 'OPENAI.API_BASE': ${{ vars.AI_REVIEW_BASE_URL }} + 'config.model': ${{ vars.AI_REVIEW_MODEL }} + 'config.reasoning_effort': ${{ vars.AI_REVIEW_REASONING_EFFORT }} + 'github_action_config.auto_review': 'true' + 'github_action_config.auto_describe': 'false' + 'github_action_config.auto_improve': 'false' steps: - name: Generate App Token diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 1eb654e0..b8f376bc 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -115,7 +115,7 @@ CCS PR review no longer depends on `anthropics/claude-code-action`. The reposito - Use `/review` on the PR when you need a fresh pass after follow-up commits. - Only the trusted `/review` comment path is enabled. - Keep repository-level reviewer instructions in the root `.pr_agent.toml`. -- Keep runtime wiring and defaults in `ai-review.yml`, which still maps the existing `AI_REVIEW_BASE_URL`, `AI_REVIEW_MODEL`, and `AI_REVIEW_API_KEY` integrations onto PR-Agent's `OPENAI.*` and `config.*` settings. +- Keep runtime wiring and defaults in `ai-review.yml`, which maps the existing `AI_REVIEW_BASE_URL`, `AI_REVIEW_MODEL`, `AI_REVIEW_REASONING_EFFORT`, and `AI_REVIEW_API_KEY` integrations onto PR-Agent's `OPENAI.*` and `config.*` settings. - If you change review defaults, update the workflow or `.pr_agent.toml` alongside the contributor or architecture docs in the same PR. Example: diff --git a/tests/unit/scripts/github/ai-review-workflow.test.ts b/tests/unit/scripts/github/ai-review-workflow.test.ts index e454aea8..45c4ea02 100644 --- a/tests/unit/scripts/github/ai-review-workflow.test.ts +++ b/tests/unit/scripts/github/ai-review-workflow.test.ts @@ -34,6 +34,7 @@ describe('PR-Agent review lane migration', () => { expect(workflow).toContain('OPENAI_KEY'); expect(workflow).toContain('vars.AI_REVIEW_BASE_URL'); expect(workflow).toContain('vars.AI_REVIEW_MODEL'); + expect(workflow).toContain('vars.AI_REVIEW_REASONING_EFFORT'); expect(workflow).toContain('secrets.AI_REVIEW_API_KEY'); expect(workflow).toContain('github_action_config.auto_review'); expect(workflow).toContain("github.event.comment.body == '/review'");