tiennm99/ccs
1
0
Fork 0
mirror of https://github.com/tiennm99/ccs.git synced 2026-09-03 18:16:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(bar): probe IPv6 loopback when detecting a running CCS server

Browse Source 
'ccs config' starts the web-server on host 'localhost', which macOS
resolves to ::1, so a reuse probe limited to 127.0.0.1 missed the most
common already-running server and launch started a redundant second
instance. Each candidate port is now probed on 127.0.0.1 first and then
[::1]; an IPv6 hit writes the bracketed-literal baseUrl into bar.json,
which URLSession in the Swift app resolves correctly.
This commit is contained in:
Tam Nhu Tran
2026-06-10 12:04:10 -04:00
parent db1d125f83
commit 3569297b6d
2 changed files with 97 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/commands/bar/launch-subcommand.ts
+32 -12
View File
@@ -77,21 +77,26 @@ export function resolveBarPort(ccsDir: string): number | null {
// ---------------------------------------------------------------------------
/**
* Probe candidate ports for a running CCS server on 127.0.0.1.
* Probe candidate ports for a running CCS server.
*
* Both IPv4 (127.0.0.1) and IPv6 (::1) loopback addresses are probed for
* each port. This is necessary because `ccs config` starts the server with
* host 'localhost', which macOS resolves to ::1 — an IPv4-only probe would
* miss that server and start a redundant second instance.
*
* Probe order per port: 127.0.0.1 first, then [::1]. First 200 wins.
* The bar.json port (if present) is checked first so a previously-used port
* gets priority. Short timeouts prevent hanging the launch flow.
*/
export async function defaultFindRunningServer(ccsDir: string): Promise<DashboardInfo | null> {
const { request } = await import('undici');
const barJsonPort = resolveBarPort(ccsDir);
const base = [3000, 3001, 3002, 8000, 8080];
const candidates: number[] =
barJsonPort !== null ? [barJsonPort, ...base.filter((p) => p !== barJsonPort)] : base;
for (const port of candidates) {
/**
* Probe a single URL. Returns true on HTTP 200, false on any other status
* or error (connection refused, timeout, etc.).
*/
async function probe(url: string): Promise<boolean> {
try {
const url = `http://127.0.0.1:${port}/api/bar/summary`;
const { statusCode, body } = await request(url, {
method: 'GET',
headersTimeout: 1500,
@@ -101,11 +106,26 @@ export async function defaultFindRunningServer(ccsDir: string): Promise<Dashboar
// body.dump() is not available in Bun's undici shim; body.text() works
// cross-runtime and fully consumes the response stream.
await body.text();
if (statusCode === 200) {
return { port, baseUrl: `http://127.0.0.1:${port}` };
}
return statusCode === 200;
} catch {
// Connection refused, timeout, or any other error → try next candidate.
return false;
}
}
const barJsonPort = resolveBarPort(ccsDir);
const base = [3000, 3001, 3002, 8000, 8080];
const candidates: number[] =
barJsonPort !== null ? [barJsonPort, ...base.filter((p) => p !== barJsonPort)] : base;
for (const port of candidates) {
// Probe IPv4 loopback first (common for explicitly-bound servers).
if (await probe(`http://127.0.0.1:${port}/api/bar/summary`)) {
return { port, baseUrl: `http://127.0.0.1:${port}` };
}
// Probe IPv6 loopback — `ccs config` binds 'localhost' which resolves to
// ::1 on macOS, so this is the common case for a running CCS server.
if (await probe(`http://[::1]:${port}/api/bar/summary`)) {
return { port, baseUrl: `http://[::1]:${port}` };
}
}
return null;