From 572b18422076f03d2d8ccbfce802740148a5fe36 Mon Sep 17 00:00:00 2001 From: Tam Nhu Tran Date: Wed, 22 Apr 2026 15:41:35 -0400 Subject: [PATCH] fix(ci): address reviewer follow-up findings --- CLAUDE.md | 9 ++++++++- docs/project-roadmap.md | 25 +++++-------------------- scripts/run-test-bucket.js | 4 ---- 3 files changed, 13 insertions(+), 25 deletions(-) diff --git a/CLAUDE.md b/CLAUDE.md index f55cc489..c7ce2d33 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -53,7 +53,8 @@ AI MUST NOT declare a task done, close a session, or move to the next task while - `Push CI` is the post-merge quality signal for `dev`. - `Dev Release` publishes the `@dev` package after `dev` changes land. - A red `Dev Release` does **not** automatically mean contributor code failed. Check `Push CI` first. -- `dev-release.yml` currently pushes with `PAT_TOKEN` because `dev` is protected by required status checks (`typecheck`, `lint`, `format`, `build`, `test`). Do not switch it back to `github.token` unless branch protection changes with it. +- Verified on `2026-04-22` via `gh api repos/kaitranntt/ccs/branches/dev/protection`: `dev` currently requires `typecheck`, `lint`, `format`, `build`, and `test`, has no branch restrictions, and has no required PR-review gate. +- `dev-release.yml` currently pushes with `PAT_TOKEN` because `dev` is protected by those required status checks. Do not switch it back to `github.token` unless branch protection changes with it. ## Core Function @@ -277,6 +278,12 @@ bun run validate # Step 3: Final check (must pass) - husky `pre-push` runs the full `bun run validate:ci-parity` gate on `main`/`dev`/hotfix branches - husky `pre-push` runs a faster feature-branch gate (`typecheck` + `lint` + `format:check` + `test:fast`) plus targeted checks based on changed files +### Maintainability Gate Status + +- The historical maintainability baseline gate is retired from the active CCS workflow. +- `validate`, `validate:ci-parity`, PR `CI`, `Push CI`, and release workflows do **not** invoke `maintainability:check`. +- Older roadmap references to `maintainability:baseline` / `maintainability:check` are historical context, not current repo commands. + ## Critical Constraints (NEVER VIOLATE) 1. **NO EMOJIS in CLI output** - Terminal output uses ASCII only: [OK], [!], [X], [i] diff --git a/docs/project-roadmap.md b/docs/project-roadmap.md index 0cb616b3..6b76df05 100644 --- a/docs/project-roadmap.md +++ b/docs/project-roadmap.md @@ -242,28 +242,13 @@ All criteria achieved: - [x] Clear domain boundaries - [x] Consistent naming conventions -## Maintainability Gate (Issue #539 Foundation) +## Historical Maintainability Gate (Retired) -- Baseline metrics artifact: `docs/metrics/maintainability-baseline.json` -- Branch-aware gate wrapper: `scripts/maintainability-check.js` -- Generate or refresh baseline: - - `bun run maintainability:baseline` - - `npm run maintainability:baseline` -- Run regression check gate: - - `bun run maintainability:check` - - `npm run maintainability:check` - - `bun run maintainability:check:strict` (force strict locally) +This section is preserved as historical context from the original Issue `#539` work. -The baseline/check scripts enumerate git-tracked files under `src` for deterministic results and fail fast if git file listing is unavailable. - -Default gate behavior: -- strict mode on protected branches (`main`, `dev`, `hotfix/*`, `kai/hotfix-*`) -- warning mode on PR CI and non-protected branches (parallel PR friendly) - -The check mode supports a maintainability regression gate that blocks increases in: -- `process.exit` references -- synchronous fs API references -- TypeScript files over 350 LOC +- The maintainability baseline gate is no longer part of the active CCS workflow. +- Current contributor and CI gates are documented in `CLAUDE.md`, `CONTRIBUTING.md`, and the GitHub workflow files. +- Do not assume `maintainability:baseline` or `maintainability:check` exist unless they are reintroduced in a future follow-up. --- diff --git a/scripts/run-test-bucket.js b/scripts/run-test-bucket.js index 5c02ec75..0f3c0212 100644 --- a/scripts/run-test-bucket.js +++ b/scripts/run-test-bucket.js @@ -59,10 +59,6 @@ const forceSlow = discovered.filter((file) => { return true; } - if (/\.(c|m)?js$/.test(file)) { - return true; - } - return readsBuiltDist(file); }); const slowSet = new Set([...slowTests, ...forceSlow]);