fix(codex): restore version context for override failures

This commit is contained in:
Tam Nhu Tran
2026-03-29 16:32:11 -04:00
parent c0f0f173e0
commit 643bd2a5ac
3 changed files with 78 additions and 4 deletions
+14 -2
View File
@@ -14,6 +14,7 @@ import {
codexBinarySupportsConfigOverrides,
detectCodexCli,
getCodexBinaryInfo,
readCodexVersion,
} from './codex-detector';
const CODEX_RUNTIME_PROVIDER_ID = 'ccs_runtime';
@@ -35,6 +36,17 @@ function buildConfigOverrideSupportError(binaryInfo?: TargetBinaryInfo): Error {
);
}
function hydrateCodexBinaryVersion(binaryInfo?: TargetBinaryInfo): TargetBinaryInfo | undefined {
if (!binaryInfo || binaryInfo.version || !binaryInfo.path) {
return binaryInfo;
}
return {
...binaryInfo,
version: readCodexVersion(binaryInfo.path),
};
}
function findDisallowedCodexManagedFlags(args: string[]): string[] {
const disallowed = new Set<string>();
@@ -99,7 +111,7 @@ export class CodexAdapter implements TargetAdapter {
if (profileType === 'default') {
if (reasoningOverride) {
if (!codexBinarySupportsConfigOverrides(options?.binaryInfo)) {
throw buildConfigOverrideSupportError(options?.binaryInfo);
throw buildConfigOverrideSupportError(hydrateCodexBinaryVersion(options?.binaryInfo));
}
return [
...buildConfigOverrideArgs([
@@ -112,7 +124,7 @@ export class CodexAdapter implements TargetAdapter {
}
if (!codexBinarySupportsConfigOverrides(options?.binaryInfo)) {
throw buildConfigOverrideSupportError(options?.binaryInfo);
throw buildConfigOverrideSupportError(hydrateCodexBinaryVersion(options?.binaryInfo));
}
if (!creds?.baseUrl?.trim() || !creds.apiKey?.trim()) {
+1 -1
View File
@@ -45,7 +45,7 @@ function runCodexProbe(codexPath: string, args: string[]): string | undefined {
}
}
function readCodexVersion(codexPath: string): string | undefined {
export function readCodexVersion(codexPath: string): string | undefined {
return runCodexProbe(codexPath, ['--version'])?.trim();
}