diff --git a/.github/workflows/ai-review.yml b/.github/workflows/ai-review.yml index eaac91d5..50b0553f 100644 --- a/.github/workflows/ai-review.yml +++ b/.github/workflows/ai-review.yml @@ -101,25 +101,26 @@ jobs: ## Review Focus Areas - 1. **Security** - OWASP Top 10, injection, auth bypass, secrets exposure - 2. **Correctness** - Logic errors, edge cases, error handling - 3. **Architecture** - Coupling, cohesion, API contracts, backward compatibility - 4. **Testing** - Coverage, edge cases, test quality - 5. **Performance** - Algorithm complexity, memory leaks, query efficiency - 6. **Maintainability** - Naming, complexity, consistency with codebase + 1. ๐Ÿ”’ **Security** - OWASP Top 10, injection, auth bypass, secrets exposure + 2. โœ… **Correctness** - Logic errors, edge cases, error handling + 3. ๐Ÿ—๏ธ **Architecture** - Coupling, cohesion, API contracts, backward compatibility + 4. ๐Ÿงช **Testing** - Coverage, edge cases, test quality + 5. โšก **Performance** - Algorithm complexity, memory leaks, query efficiency + 6. ๐Ÿ“– **Maintainability** - Naming, complexity, consistency with codebase ## Output Structure - Use visual hierarchy with `---` separators between major sections: - - Summary (2-3 sentences) - - Strengths (numbered, with file:line references) - - Observations & Suggestions (with code examples) - - Security Considerations (โœ…/โŒ checklist) - - Code Quality Checklist (โœ…/โŒ format) - - Recommendations (Priority: High/Medium/Low) - - Overall Assessment (APPROVED/APPROVED WITH NOTES/CHANGES REQUESTED) + Use visual hierarchy with emojis and `---` separators between major sections: + - ๐Ÿ“‹ **Summary** (2-3 sentences) + - โœ… **Strengths** (numbered, with file:line references, use โญ for exceptional items) + - ๐Ÿ” **Observations & Suggestions** (with code examples, priority tags) + - ๐Ÿ”’ **Security Considerations** (โœ…/โŒ checklist table) + - ๐Ÿ“Š **Code Quality Checklist** (โœ…/โŒ table format) + - ๐Ÿ’ก **Recommendations** (๐Ÿ”ด High / ๐ŸŸก Medium / ๐ŸŸข Low priority) + - ๐ŸŽฏ **Overall Assessment** (โœ… APPROVED / โš ๏ธ APPROVED WITH NOTES / โŒ CHANGES REQUESTED) Be thorough but concise. Skip empty sections. Include code examples for non-trivial suggestions. + Use tables for checklists. Bold important terms. Make the review visually scannable. End your review with: > ๐Ÿค– Reviewed by `${{ env.REVIEW_MODEL }}`