fix(cliproxy): update version range and add persistent AI review logging (#303)

* fix(ci): add persistent logging and remove turn/diff limits for AI review (#298)

- Remove --max-turns limit (unlimited exploration)
- Remove head -8000 diff limit (full diff)
- Add persistent logging to /opt/actions-runner/logs/ai-review/
- Save prompt, stdout, stderr, timing, metadata as separate files
- Add structured metadata.json with run details
- Separate stdout/stderr capture for better debugging
- Include debug info in failure comments (exit code, duration, log path)
- Retry without tool restrictions if first attempt fails

* fix(cliproxy): correct faulty version range to v81-85 and set v89 as stable (#302)

PR #289 incorrectly marked all v81+ as faulty. v89 confirmed stable.
- CLIPROXY_MAX_STABLE_VERSION: 6.6.80-0 → 6.6.89-0
- CLIPROXY_FAULTY_RANGE max: 6.6.999-0 → 6.6.85-0

.github/workflows/ai-review.yml

@@ -5,6 +5,8 @@
 # Triggers:
 # - Automatically on PR open/update
 # - Manually via /review comment on PR
+#
+# Logs stored on runner at: /opt/actions-runner/logs/ai-review/
 
 name: AI Code Review
 
@@ -255,10 +257,16 @@ jobs:
         run: |
           PR_NUM="${{ steps.pr.outputs.number }}"
           REPO="${{ github.repository }}"
+          TIMESTAMP=$(date +%Y%m%d-%H%M%S)
+
+          # Setup logging directory on runner
+          LOG_DIR="/opt/actions-runner/logs/ai-review/pr-${PR_NUM}-${TIMESTAMP}"
+          mkdir -p "$LOG_DIR"
 
           echo "[i] Running Claude Code review for PR #${PR_NUM}"
           echo "[i] Model: ${ANTHROPIC_MODEL}"
           echo "[i] Working directory: $(pwd)"
+          echo "[i] Log directory: ${LOG_DIR}"
 
           # Get PR metadata
           PR_TITLE=$(gh pr view $PR_NUM --repo $REPO --json title --jq .title)
@@ -267,8 +275,8 @@ jobs:
           # Get list of changed files
           CHANGED_FILES=$(gh pr diff $PR_NUM --repo $REPO --name-only)
 
-          # Get full diff (increased limit for comprehensive review)
+          # Get full diff (NO LIMIT - unlimited)
-          DIFF=$(gh pr diff $PR_NUM --repo $REPO | head -8000)
+          DIFF=$(gh pr diff $PR_NUM --repo $REPO)
 
           # Replace model name in instructions
           sed -i "s|MODEL_NAME|${ANTHROPIC_MODEL}|g" /tmp/review-instructions.txt
@@ -317,33 +325,119 @@ jobs:
           BEGIN YOUR EXPLORATION NOW. Use Read, Glob, and Grep tools before writing your review.
           PROMPT_END
 
-          # Run Claude Code with extended exploration
+          # Save prompt for debugging
-          echo "[i] Starting comprehensive review (this may take 2-3 minutes)..."
+          cp /tmp/full-prompt.txt "$LOG_DIR/prompt.txt"
-          REVIEW=$(cat /tmp/full-prompt.txt | claude -p \
-            --allowed-tools "Read,Glob,Grep" \
-            --max-turns 15 2>&1) || true
 
-          # Validate review output
+          # Save metadata
-          if [ -z "$REVIEW" ] || [ ${#REVIEW} -lt 100 ]; then
+          cat > "$LOG_DIR/metadata.json" << EOF
-            echo "[!] Review output too short (${#REVIEW} chars), retrying..."
+          {
-            REVIEW=$(cat /tmp/full-prompt.txt | claude -p --max-turns 5 2>&1) || true
+            "pr_number": ${PR_NUM},
+            "repository": "${REPO}",
+            "model": "${ANTHROPIC_MODEL}",
+            "timestamp": "${TIMESTAMP}",
+            "changed_files_count": $(echo "$CHANGED_FILES" | wc -l),
+            "diff_lines": $(echo "$DIFF" | wc -l),
+            "workflow_run_id": "${{ github.run_id }}"
+          }
+          EOF
+
+          # Run Claude Code with NO LIMITS
+          echo "[i] Starting comprehensive review (unlimited turns)..."
+          START_TIME=$(date +%s)
+
+          # Run with separate stdout/stderr capture
+          set +e
+          cat /tmp/full-prompt.txt | claude -p \
+            --allowed-tools "Read,Glob,Grep" \
+            > "$LOG_DIR/claude-stdout.txt" \
+            2> "$LOG_DIR/claude-stderr.txt"
+          EXIT_CODE=$?
+          set -e
+
+          END_TIME=$(date +%s)
+          DURATION=$((END_TIME - START_TIME))
+
+          # Save timing info
+          cat > "$LOG_DIR/timing.txt" << EOF
+          Start: $(date -d @$START_TIME '+%Y-%m-%d %H:%M:%S')
+          End: $(date -d @$END_TIME '+%Y-%m-%d %H:%M:%S')
+          Duration: ${DURATION} seconds
+          Exit code: ${EXIT_CODE}
+          EOF
+
+          echo "[i] Review completed in ${DURATION}s with exit code ${EXIT_CODE}"
+
+          # Read the review output
+          REVIEW=$(cat "$LOG_DIR/claude-stdout.txt")
+          REVIEW_LEN=${#REVIEW}
+
+          echo "[i] Review output: ${REVIEW_LEN} chars"
+          echo "[i] Stderr output: $(wc -c < "$LOG_DIR/claude-stderr.txt") chars"
+
+          # Log stderr if non-empty (for debugging)
+          if [ -s "$LOG_DIR/claude-stderr.txt" ]; then
+            echo "[!] Claude stderr output:"
+            cat "$LOG_DIR/claude-stderr.txt"
           fi
 
-          # Final fallback
+          # Validate review output - retry if too short
-          if [ -z "$REVIEW" ] || [ ${#REVIEW} -lt 50 ]; then
+          if [ -z "$REVIEW" ] || [ ${REVIEW_LEN} -lt 100 ]; then
+            echo "[!] Review output too short (${REVIEW_LEN} chars), retrying without tool restrictions..."
+
+            cat /tmp/full-prompt.txt | claude -p \
+              > "$LOG_DIR/claude-stdout-retry.txt" \
+              2> "$LOG_DIR/claude-stderr-retry.txt" || true
+
+            REVIEW=$(cat "$LOG_DIR/claude-stdout-retry.txt")
+            REVIEW_LEN=${#REVIEW}
+            echo "[i] Retry output: ${REVIEW_LEN} chars"
+          fi
+
+          # Final fallback with error details
+          if [ -z "$REVIEW" ] || [ ${REVIEW_LEN} -lt 50 ]; then
+            STDERR_CONTENT=$(cat "$LOG_DIR/claude-stderr.txt" 2>/dev/null | head -10 || echo "No stderr")
             REVIEW="## 🔍 Code Review
 
           **Verdict**: ⚠️ Review generation failed
 
           > 🤖 Attempted by \`${ANTHROPIC_MODEL}\`
 
-          The automated review encountered an issue. Please request a manual review."
+          The automated review encountered an issue. Details logged to runner.
+
+          **Debug info:**
+          - Exit code: ${EXIT_CODE}
+          - Duration: ${DURATION}s
+          - Output length: ${REVIEW_LEN} chars
+          - Log path: \`${LOG_DIR}\`
+
+          Please request a manual review or check runner logs."
           fi
 
+          # Save final review
+          echo "$REVIEW" > "$LOG_DIR/final-review.txt"
+
+          # Update metadata with result
+          cat > "$LOG_DIR/metadata.json" << EOF
+          {
+            "pr_number": ${PR_NUM},
+            "repository": "${REPO}",
+            "model": "${ANTHROPIC_MODEL}",
+            "timestamp": "${TIMESTAMP}",
+            "changed_files_count": $(echo "$CHANGED_FILES" | wc -l),
+            "diff_lines": $(echo "$DIFF" | wc -l),
+            "workflow_run_id": "${{ github.run_id }}",
+            "duration_seconds": ${DURATION},
+            "exit_code": ${EXIT_CODE},
+            "review_length": ${REVIEW_LEN},
+            "success": $([ ${REVIEW_LEN} -ge 100 ] && echo "true" || echo "false")
+          }
+          EOF
+
           # Post review as comment
-          echo "[i] Posting review (${#REVIEW} chars)..."
+          echo "[i] Posting review (${REVIEW_LEN} chars)..."
           echo "$REVIEW" | gh pr comment $PR_NUM --repo $REPO --body-file -
           echo "[OK] Review posted"
+          echo "[i] Logs saved to: ${LOG_DIR}"
 
       - name: Add success reaction
         if: success() && github.event_name == 'issue_comment'

src/cliproxy/platform-detector.ts

@@ -16,17 +16,17 @@ export const CLIPROXY_FALLBACK_VERSION = '6.6.40-0';
 
 /**
  * Maximum stable version cap - prevents auto-update to known unstable releases
- * v81+ has context cancellation bugs causing intermittent 500 errors
+ * v86-89 resolved the context cancellation bugs from v81-85
  * See: https://github.com/kaitranntt/ccs/issues/269
  */
-export const CLIPROXY_MAX_STABLE_VERSION = '6.6.80-0';
+export const CLIPROXY_MAX_STABLE_VERSION = '6.6.89-0';
 
 /**
  * Faulty version range - versions with known critical bugs
- * v81+ have context cancellation bugs causing intermittent 500 errors
+ * v81-88 have context cancellation bugs causing intermittent 500 errors
- * When a stable version is found, update MAX_STABLE and set faulty range accordingly
+ * v89 confirmed stable
  */
-export const CLIPROXY_FAULTY_RANGE = { min: '6.6.81-0', max: '6.6.999-0' };
+export const CLIPROXY_FAULTY_RANGE = { min: '6.6.81-0', max: '6.6.88-0' };
 
 /** @deprecated Use CLIPROXY_FALLBACK_VERSION instead */
 export const CLIPROXY_VERSION = CLIPROXY_FALLBACK_VERSION;