tiennm99/ccs
1
0
Fork 0
mirror of https://github.com/tiennm99/ccs.git synced 2026-09-03 04:17:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(docker): address review findings — PID guard, deleteBinary guard, blocked fallback

Browse Source 
- Guard child.pid falsy in bootstrap (PID 0 creates immortal phantom lock)
- Add ETXTBSY/EBUSY guard to deleteBinary() (same vuln as downloadAndInstall)
- Fix error message to suggest container restart (not circular ccs docker update)
- Tighten status.blocked guard to handle missing blocker gracefully
This commit is contained in:
Tam Nhu Tran
2026-03-28 18:12:18 -04:00
parent 5eac9c584a
commit 7d410b26d0
3 changed files with 21 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/docker/docker-bootstrap.ts
+3 -2
View File
@@ -37,8 +37,9 @@ async function runCliproxy(): Promise<number> {
// Register session lock so dashboard can detect the running proxy
let sessionId: string | undefined;
child.on('spawn', () => {
const version = getInstalledCliproxyVersion() ?? undefined;
sessionId = registerSession(CLIPROXY_DEFAULT_PORT, child.pid ?? 0, version, 'plus');
if (!child.pid) return;
const version = getInstalledCliproxyVersion();
sessionId = registerSession(CLIPROXY_DEFAULT_PORT, child.pid, version, 'plus');
});
child.on('error', reject);