tiennm99/ccs
1
0
Fork 0
mirror of https://github.com/tiennm99/ccs.git synced 2026-08-24 08:29:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

docs: remove maintainer-only runner info from contributor docs

Browse Source 
Self-hosted runner troubleshooting (`ssh docker`, `systemctl status
actions-runner`, `cliproxy` runner label) is maintainer infra. External
contributors have no access to that host and the guidance was noise.

- CLAUDE.md: drop "Self-Hosted Runner Awareness" subsection.
- CONTRIBUTING.md: rewrite queued-runner note as generic "maintainer
  infrastructure issue; leave a comment". Remove `cliproxy` runner label
  mentions from AI Review Lane.

Equivalent maintainer runbook now lives in the monorepo root CLAUDE.md,
where it's actually actionable.
This commit is contained in:
Tam Nhu Tran
2026-04-22 16:20:35 -04:00
parent 6d4dcc1174
commit a3f5aff45d
2 changed files with 2 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
CLAUDE.md
-6
View File
@@ -41,12 +41,6 @@ gh pr checks <n>
### Absolute rule ### Absolute rule
AI MUST NOT declare a task done, close a session, or move to the next task while CI is red or still running. Leaving a PR red and moving on is the primary failure mode this protocol prevents. AI MUST NOT declare a task done, close a session, or move to the next task while CI is red or still running. Leaving a PR red and moving on is the primary failure mode this protocol prevents.
### Self-Hosted Runner Awareness
- If `gh pr checks` or `gh run watch` stays queued for more than 10 minutes, assume the self-hosted runner is offline.
- Confirm on the maintainer host with `ssh docker "systemctl status actions-runner"`.
- Treat runner outages as infrastructure issues, not code failures. Do not blindly rerun local commands and hope the queue clears.
### Dev Release vs Push CI ### Dev Release vs Push CI
- `CI` is the pull-request quality gate for contributor branches. - `CI` is the pull-request quality gate for contributor branches.
CONTRIBUTING.md
+2 -3
View File
@@ -86,7 +86,7 @@ CCS now uses three separate automation lanes:
If `Dev Release` is red but your PR checks were green, check `Push CI` before assuming the merged code is broken. If `Dev Release` is red but your PR checks were green, check `Push CI` before assuming the merged code is broken.
If `CI` or `Push CI` stays queued for more than 10 minutes, the self-hosted runner is probably offline. That is a maintainer issue, not a contributor mistake. If `CI` or `Push CI` stays queued for a long time, it is a maintainer infrastructure issue, not a contributor mistake. Leave a comment on your PR and a maintainer will address it.
## AI Agent Rules ## AI Agent Rules
@@ -97,9 +97,8 @@ If `CI` or `Push CI` stays queued for more than 10 minutes, the self-hosted runn
CCS PR review no longer depends on `anthropics/claude-code-action`. The repository review lane is self-hosted PR-Agent: CCS PR review no longer depends on `anthropics/claude-code-action`. The repository review lane is self-hosted PR-Agent:
- The retained `.github/workflows/ai-review.yml` runs PR-Agent in GitHub Actions. - The retained `.github/workflows/ai-review.yml` runs PR-Agent in GitHub Actions.
- PR-Agent reviews run on the existing self-hosted `cliproxy` runner.
- Use `/review` on the PR when you need a fresh pass after follow-up commits. - Use `/review` on the PR when you need a fresh pass after follow-up commits.
- Only the trusted `/review` comment path is enabled on the privileged self-hosted runner. - Only the trusted `/review` comment path is enabled.
- Keep repository-level reviewer instructions in the root `.pr_agent.toml`. - Keep repository-level reviewer instructions in the root `.pr_agent.toml`.
- Keep runtime wiring and defaults in `ai-review.yml`, which still maps the existing `AI_REVIEW_BASE_URL`, `AI_REVIEW_MODEL`, and `AI_REVIEW_API_KEY` integrations onto PR-Agent's `OPENAI.*` and `config.*` settings. - Keep runtime wiring and defaults in `ai-review.yml`, which still maps the existing `AI_REVIEW_BASE_URL`, `AI_REVIEW_MODEL`, and `AI_REVIEW_API_KEY` integrations onto PR-Agent's `OPENAI.*` and `config.*` settings.
- If you change review defaults, update the workflow or `.pr_agent.toml` alongside the contributor or architecture docs in the same PR. - If you change review defaults, update the workflow or `.pr_agent.toml` alongside the contributor or architecture docs in the same PR.