From a8c46cc8ed6743f3cfb07bbe621b644c9b2d6830 Mon Sep 17 00:00:00 2001 From: kaitranntt Date: Sun, 25 Jan 2026 21:33:29 -0500 Subject: [PATCH] fix(config): persist setup_completed flag to YAML file Critical fix: setup_completed was set in memory but never written to disk. - Add setup_completed to generateYamlWithComments() for YAML serialization - Add setup_completed to mergeWithDefaults() to preserve during config merge Without these changes, the flag was lost on save/reload, causing first-time notice to reappear. Addresses critical code review feedback on PR #372. --- src/config/unified-config-loader.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/config/unified-config-loader.ts b/src/config/unified-config-loader.ts index a495b7e3..4cf39d60 100644 --- a/src/config/unified-config-loader.ts +++ b/src/config/unified-config-loader.ts @@ -139,6 +139,7 @@ function mergeWithDefaults(partial: Partial): UnifiedConfig { const defaults = createEmptyUnifiedConfig(); return { version: partial.version ?? defaults.version, + setup_completed: partial.setup_completed, default: partial.default ?? defaults.default, accounts: partial.accounts ?? defaults.accounts, profiles: partial.profiles ?? defaults.profiles, @@ -326,6 +327,9 @@ function generateYamlWithComments(config: UnifiedConfig): string { // Version lines.push(`version: ${config.version}`); + if (config.setup_completed !== undefined) { + lines.push(`setup_completed: ${config.setup_completed}`); + } lines.push(''); // Default