From b63943eb450b335bbce00946dfd71f2535538cc4 Mon Sep 17 00:00:00 2001 From: "Kai (Tam Nhu) Tran" <61256810+kaitranntt@users.noreply.github.com> Date: Sat, 23 May 2026 21:55:02 -0400 Subject: [PATCH] fix(browser): track explicit devtools_port from config (#1383) #1369 unconditionally set hasExplicitDevtoolsPort=false for config-attach, which broke users who explicitly set devtools_port in config. Now track whether config.claude.devtools_port was actually provided. --- src/utils/browser/browser-settings.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/utils/browser/browser-settings.ts b/src/utils/browser/browser-settings.ts index 7bf45d03..edc6b383 100644 --- a/src/utils/browser/browser-settings.ts +++ b/src/utils/browser/browser-settings.ts @@ -230,6 +230,7 @@ export function getEffectiveClaudeBrowserAttachConfig( const override = getBrowserAttachOverride(env); const configUserDataDir = resolveBrowserUserDataDir(config.claude.user_data_dir) ?? getRecommendedBrowserUserDataDir(); + const configHasExplicitPort = config.claude.devtools_port !== undefined; const configPort = normalizeDevtoolsPort(config.claude.devtools_port); const configEvalMode = config.claude.eval_mode ?? 'readonly'; const envEvalMode = parseBrowserEvalMode(env.CCS_BROWSER_EVAL_MODE); @@ -253,7 +254,7 @@ export function getEffectiveClaudeBrowserAttachConfig( overrideActive: false, userDataDir: configUserDataDir, devtoolsPort: configPort, - hasExplicitDevtoolsPort: false, + hasExplicitDevtoolsPort: configHasExplicitPort, evalMode: effectiveEvalMode, }; }