tiennm99/ccs
1
0
Fork 0
mirror of https://github.com/tiennm99/ccs.git synced 2026-07-19 20:17:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(cliproxy): handle edge cases in thinking validation

Browse Source 
- model-catalog: add null guard and trim for modelId lookup
- thinking-validator: add 100 char length limit, accept "8192.0" format
- cliproxy-executor: error on empty --thinking= value
- use-thinking-config: handle HTML error pages, return cleanup fn
This commit is contained in:
kaitranntt
2026-01-21 17:52:16 -05:00
parent 299d96c011
commit ca490a9f4e
4 changed files with 42 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ui/src/pages/settings/hooks/use-thinking-config.ts
+16 -1
View File
@@ -37,7 +37,14 @@ export function useThinkingConfig() {
setError(null);
const res = await fetch('/api/thinking', { signal: controller.signal });
clearTimeout(timeoutId);
if (!res.ok) throw new Error('Failed to load Thinking config');
if (!res.ok) {
// Handle HTML error pages gracefully
const contentType = res.headers.get('content-type');
if (contentType?.includes('text/html')) {
throw new Error(`Server error (${res.status})`);
}
throw new Error('Failed to load Thinking config');
}
const data = await res.json();
setConfig(data.config || DEFAULT_THINKING_CONFIG);
// W4: Store lastModified for optimistic locking
@@ -53,6 +60,9 @@ export function useThinkingConfig() {
} finally {
setLoading(false);
}
// Return cleanup function for AbortController
return () => controller.abort();
}, []);
const saveConfig = useCallback(
@@ -84,6 +94,11 @@ export function useThinkingConfig() {
clearTimeout(timeoutId);
if (!res.ok) {
// Handle HTML error pages gracefully
const contentType = res.headers.get('content-type');
if (contentType?.includes('text/html')) {
throw new Error(`Server error (${res.status})`);
}
const data = await res.json();
// W4: Handle conflict (409) with user-friendly message
if (res.status === 409) {