tiennm99/ccs
1
0
Fork 0
mirror of https://github.com/tiennm99/ccs.git synced 2026-07-17 04:17:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: use getCcsDir() instead of os.homedir() for test isolation

Browse Source 
GlmtTransformer and Beta Channel tests used hardcoded os.homedir()
paths which fail when CCS_HOME is set by other tests in full suite.
This commit is contained in:
Tam Nhu Tran
2026-02-13 05:23:23 +07:00
parent 27badb2584
commit ca7bb23970
2 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/unit/glmt/glmt-transformer.test.js
+3 -3
View File
@@ -202,11 +202,11 @@ describe('GlmtTransformer', () => {
delete process.env.CCS_DEBUG; delete process.env.CCS_DEBUG;
}); });
it('uses ~/.ccs/logs by default', () => { it('uses getCcsDir()/logs by default', () => {
const transformer = new GlmtTransformer(); const transformer = new GlmtTransformer();
const os = require('os');
const path = require('path'); const path = require('path');
const expectedPath = path.join(os.homedir(), '.ccs', 'logs'); const { getCcsDir } = require('../../../dist/utils/config-manager');
const expectedPath = path.join(getCcsDir(), 'logs');
assert.strictEqual(transformer.debugLogDir, expectedPath); assert.strictEqual(transformer.debugLogDir, expectedPath);
}); });
}); });
tests/unit/utils/update-checker-beta-channel.test.js
+7 -7
View File
@@ -14,7 +14,7 @@ const assert = require('assert');
const fs = require('fs'); const fs = require('fs');
const path = require('path'); const path = require('path');
const https = require('https'); const https = require('https');
const os = require('os'); const { getCcsDir } = require('../../../dist/utils/config-manager');
describe('Beta Channel Implementation (Phase 3)', function () { describe('Beta Channel Implementation (Phase 3)', function () {
let updateCheckerModule; let updateCheckerModule;
@@ -268,7 +268,7 @@ describe('Beta Channel Implementation (Phase 3)', function () {
latest_version: null, latest_version: null,
dismissed_version: null dismissed_version: null
}; };
mockFileSystem[path.join(os.homedir(), '.ccs', 'cache', 'update-check.json')] = JSON.stringify(cacheData); mockFileSystem[path.join(getCcsDir(), 'cache', 'update-check.json')] = JSON.stringify(cacheData);
}); });
it('should use latest tag when targetTag is "latest"', async function () { it('should use latest tag when targetTag is "latest"', async function () {
@@ -355,7 +355,7 @@ describe('Beta Channel Implementation (Phase 3)', function () {
await updateCheckerModule.checkForUpdates('5.4.0', true, 'npm', 'dev'); await updateCheckerModule.checkForUpdates('5.4.0', true, 'npm', 'dev');
// Check cache was updated with dev version // Check cache was updated with dev version
const cachePath = path.join(os.homedir(), '.ccs', 'cache', 'update-check.json'); const cachePath = path.join(getCcsDir(), 'cache', 'update-check.json');
const cacheData = JSON.parse(mockFileSystem[cachePath]); const cacheData = JSON.parse(mockFileSystem[cachePath]);
// Dev versions are now stored in dev_version field (not latest_version) // Dev versions are now stored in dev_version field (not latest_version)
@@ -371,7 +371,7 @@ describe('Beta Channel Implementation (Phase 3)', function () {
dev_version: '5.5.0', dev_version: '5.5.0',
dismissed_version: null dismissed_version: null
}; };
mockFileSystem[path.join(os.homedir(), '.ccs', 'cache', 'update-check.json')] = JSON.stringify(cacheData); mockFileSystem[path.join(getCcsDir(), 'cache', 'update-check.json')] = JSON.stringify(cacheData);
// Call with force=false to use cache // Call with force=false to use cache
const result = await updateCheckerModule.checkForUpdates('5.4.0', false, 'npm', 'dev'); const result = await updateCheckerModule.checkForUpdates('5.4.0', false, 'npm', 'dev');
@@ -460,7 +460,7 @@ describe('Beta Channel Implementation (Phase 3)', function () {
describe('Cache functionality', function () { describe('Cache functionality', function () {
it('should create cache directory if not exists', async function () { it('should create cache directory if not exists', async function () {
// Ensure no cache exists // Ensure no cache exists
const cacheDir = path.join(os.homedir(), '.ccs', 'cache'); const cacheDir = path.join(getCcsDir(), 'cache');
delete mockFileSystem[cacheDir]; delete mockFileSystem[cacheDir];
await updateCheckerModule.checkForUpdates('5.4.0', true, 'npm', 'latest'); await updateCheckerModule.checkForUpdates('5.4.0', true, 'npm', 'latest');
@@ -477,7 +477,7 @@ describe('Beta Channel Implementation (Phase 3)', function () {
dev_version: '5.5.0', dev_version: '5.5.0',
dismissed_version: '5.5.0' dismissed_version: '5.5.0'
}; };
mockFileSystem[path.join(os.homedir(), '.ccs', 'cache', 'update-check.json')] = JSON.stringify(cacheData); mockFileSystem[path.join(getCcsDir(), 'cache', 'update-check.json')] = JSON.stringify(cacheData);
const result = await updateCheckerModule.checkForUpdates('5.4.1', false, 'npm', 'dev'); const result = await updateCheckerModule.checkForUpdates('5.4.1', false, 'npm', 'dev');
@@ -488,7 +488,7 @@ describe('Beta Channel Implementation (Phase 3)', function () {
it('should handle corrupted cache gracefully', async function () { it('should handle corrupted cache gracefully', async function () {
// Set up corrupted cache // Set up corrupted cache
mockFileSystem[path.join(os.homedir(), '.ccs', 'cache', 'update-check.json')] = 'invalid json'; mockFileSystem[path.join(getCcsDir(), 'cache', 'update-check.json')] = 'invalid json';
// Should not throw error // Should not throw error
const result = await updateCheckerModule.checkForUpdates('5.4.0', true, 'npm', 'latest'); const result = await updateCheckerModule.checkForUpdates('5.4.0', true, 'npm', 'latest');