mirror of
https://github.com/tiennm99/ccs.git
synced 2026-08-06 18:22:08 +00:00
fix(docker): address review findings — test, docs, bcrypt path
- Add test assertion for --host auth reminder message - Use Node module resolution for bcrypt in README (not hardcoded path) - Replace cat|grep with direct grep in verification commands
This commit is contained in:
+6
-5
@@ -65,10 +65,11 @@ environment:
|
|||||||
Generate a bcrypt hash:
|
Generate a bcrypt hash:
|
||||||
|
|
||||||
```bash
|
```bash
|
||||||
docker exec ccs-cliproxy node -e "
|
docker exec ccs-cliproxy npx -y bcryptjs -e "
|
||||||
const bcrypt = require('/usr/local/lib/node_modules/@kaitranntt/ccs/node_modules/bcrypt');
|
const b = require('bcryptjs'); console.log(b.hashSync('your-password', 10));
|
||||||
console.log(bcrypt.hashSync('your-password', 10));
|
|
||||||
"
|
"
|
||||||
|
# Or if bcrypt is available in the container's CCS install:
|
||||||
|
docker exec ccs-cliproxy node -e "console.log(require('bcrypt').hashSync('your-password', 10))"
|
||||||
```
|
```
|
||||||
|
|
||||||
After configuring auth, restart the dashboard:
|
After configuring auth, restart the dashboard:
|
||||||
@@ -129,7 +130,7 @@ docker exec ccs-cliproxy curl -fsS http://127.0.0.1:3000/api/health \
|
|||||||
| python3 -c "import sys,json; d=json.load(sys.stdin); print(f'{d[\"summary\"][\"passed\"]} passed, {d[\"summary\"][\"errors\"]} errors')"
|
| python3 -c "import sys,json; d=json.load(sys.stdin); print(f'{d[\"summary\"][\"passed\"]} passed, {d[\"summary\"][\"errors\"]} errors')"
|
||||||
|
|
||||||
# 4. Verify auth tokens loaded (check client count)
|
# 4. Verify auth tokens loaded (check client count)
|
||||||
docker exec ccs-cliproxy cat /var/log/ccs/cliproxy.log | grep "client load complete"
|
docker exec ccs-cliproxy grep "client load complete" /var/log/ccs/cliproxy.log
|
||||||
|
|
||||||
# 5. Test dashboard API (from remote -- requires auth)
|
# 5. Test dashboard API (from remote -- requires auth)
|
||||||
curl -fsS -X POST http://<host>:3000/api/auth/login \
|
curl -fsS -X POST http://<host>:3000/api/auth/login \
|
||||||
@@ -340,7 +341,7 @@ If CLIProxy logs show "0 clients" after copying auth tokens:
|
|||||||
docker exec ccs-cliproxy supervisorctl -c /etc/supervisord.conf restart cliproxy
|
docker exec ccs-cliproxy supervisorctl -c /etc/supervisord.conf restart cliproxy
|
||||||
|
|
||||||
# Verify tokens loaded
|
# Verify tokens loaded
|
||||||
docker exec ccs-cliproxy cat /var/log/ccs/cliproxy.log | grep "client load complete"
|
docker exec ccs-cliproxy grep "client load complete" /var/log/ccs/cliproxy.log
|
||||||
```
|
```
|
||||||
|
|
||||||
### ETXTBSY Error on First Boot
|
### ETXTBSY Error on First Boot
|
||||||
|
|||||||
@@ -38,6 +38,7 @@ describe('docker up subcommand', () => {
|
|||||||
expect(rendered).toContain('Docker stack is running on docker-box.');
|
expect(rendered).toContain('Docker stack is running on docker-box.');
|
||||||
expect(rendered).toContain('Dashboard port: 4000');
|
expect(rendered).toContain('Dashboard port: 4000');
|
||||||
expect(rendered).toContain('CLIProxy port: 9317');
|
expect(rendered).toContain('CLIProxy port: 9317');
|
||||||
|
expect(rendered).toContain('Remote access requires dashboard auth');
|
||||||
expect(capture.errorLines).toEqual([]);
|
expect(capture.errorLines).toEqual([]);
|
||||||
expect(process.exitCode).toBe(0);
|
expect(process.exitCode).toBe(0);
|
||||||
} finally {
|
} finally {
|
||||||
|
|||||||
Reference in New Issue
Block a user