From d79e35b0c836ed625e04547b090187509b7f60fe Mon Sep 17 00:00:00 2001 From: Tam Nhu Tran Date: Fri, 22 May 2026 11:14:51 -0400 Subject: [PATCH] chore(ci): clarify Docker curl retry intent --- .github/workflows/docker-release.yml | 4 ++++ .github/workflows/smoke-test-compose-url.yml | 2 ++ 2 files changed, 6 insertions(+) diff --git a/.github/workflows/docker-release.yml b/.github/workflows/docker-release.yml index 84b6829b..22834fd5 100644 --- a/.github/workflows/docker-release.yml +++ b/.github/workflows/docker-release.yml @@ -376,6 +376,8 @@ jobs: - name: Probe dashboard port 3000 run: | + # Single-shot probe by design: healthcheck and network-contract already + # handle readiness waits, and curl --retry would not retry HTTP errors. HTTP_CODE=$(curl -o /dev/null -s -w "%{http_code}" --max-time 10 http://127.0.0.1:13000/ || echo "000") if [[ "${HTTP_CODE}" == "000" ]]; then echo "[X] Could not reach dashboard on :3000 (connection failed)" @@ -385,6 +387,8 @@ jobs: - name: Probe CLIProxy port 8317 run: | + # Single-shot probe by design: healthcheck and network-contract already + # handle readiness waits, and curl --retry would not retry HTTP errors. HTTP_CODE=$(curl -o /dev/null -s -w "%{http_code}" --max-time 10 http://127.0.0.1:18317/ || echo "000") if [[ "${HTTP_CODE}" == "000" ]]; then echo "[X] Could not reach CLIProxy on :8317 (connection failed)" diff --git a/.github/workflows/smoke-test-compose-url.yml b/.github/workflows/smoke-test-compose-url.yml index 35c232a3..d6a8a163 100644 --- a/.github/workflows/smoke-test-compose-url.yml +++ b/.github/workflows/smoke-test-compose-url.yml @@ -31,6 +31,8 @@ jobs: - name: Download compose from canonical URL run: | + # Keep this as a plain fetch. curl --retry only covers transport-like + # failures by default and can overstate HTTP 5xx resilience. curl -fsSL https://ccs.kaitran.ca/docker-compose.yaml -o /tmp/ccs-compose.yaml echo "--- downloaded compose ---" cat /tmp/ccs-compose.yaml