tiennm99/ccs
1
0
Fork 0
mirror of https://github.com/tiennm99/ccs.git synced 2026-07-16 20:17:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(dashboard): address code review feedback for PR #336

Browse Source 
- Fix documentation: config.yaml -> settings.json in backups-section
- Wrap restoreBackup in useCallback for callback stability
- Auth middleware verified: inherited from app.use(authMiddleware)
This commit is contained in:
kaitranntt
2026-01-14 16:51:56 -05:00
parent 623a3146d7
commit e808972df0
1 changed files with 35 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ui/src/pages/settings/sections/backups-section.tsx
+35 -32
View File
@@ -1,6 +1,6 @@
/**
* Backups Section
* Settings section for managing config.yaml backups (list and restore)
* Settings section for managing settings.json backups (list and restore)
*/
import { useEffect, useState, useCallback, useRef } from 'react';
@@ -73,38 +73,41 @@ export default function BackupsSection() {
}
}, []);
// Restore backup
const restoreBackup = async (timestamp: string) => {
// Abort previous restore request
restoreAbortControllerRef.current?.abort();
restoreAbortControllerRef.current = new AbortController();
// Restore backup (wrapped in useCallback for callback stability)
const restoreBackup = useCallback(
async (timestamp: string) => {
// Abort previous restore request
restoreAbortControllerRef.current?.abort();
restoreAbortControllerRef.current = new AbortController();
try {
setRestoring(timestamp);
setError(null);
const response = await fetch('/api/persist/restore', {
method: 'POST',
headers: { 'Content-Type': 'application/json' },
body: JSON.stringify({ timestamp }),
signal: restoreAbortControllerRef.current.signal,
});
try {
setRestoring(timestamp);
setError(null);
const response = await fetch('/api/persist/restore', {
method: 'POST',
headers: { 'Content-Type': 'application/json' },
body: JSON.stringify({ timestamp }),
signal: restoreAbortControllerRef.current.signal,
});
if (!response.ok) {
const data = await response.json();
throw new Error(data.error || 'Failed to restore backup');
if (!response.ok) {
const data = await response.json();
throw new Error(data.error || 'Failed to restore backup');
}
setSuccess('Backup restored successfully');
await fetchBackups();
await fetchRawConfig();
} catch (err) {
// Ignore abort errors
if (err instanceof Error && err.name === 'AbortError') return;
setError(err instanceof Error ? err.message : 'Unknown error');
} finally {
setRestoring(null);
}
setSuccess('Backup restored successfully');
await fetchBackups();
await fetchRawConfig();
} catch (err) {
// Ignore abort errors
if (err instanceof Error && err.name === 'AbortError') return;
setError(err instanceof Error ? err.message : 'Unknown error');
} finally {
setRestoring(null);
}
};
},
[fetchBackups, fetchRawConfig]
);
// Load on mount
useEffect(() => {
@@ -199,8 +202,8 @@ export default function BackupsSection() {
<h2 className="text-lg font-semibold">Settings Backups</h2>
</div>
<p className="text-sm text-muted-foreground">
Restore previous versions of your config.yaml file. Backups are created automatically
when settings are modified.
Restore previous versions of your settings.json file. Backups are created
automatically when settings are modified.
</p>
</div>