mirror of
https://github.com/tiennm99/ccs.git
synced 2026-07-17 00:16:46 +00:00
Kai (Tam Nhu) TranandGitHub
adf5a836fc
* fix(docker): parameterize image with CCS_IMAGE env so smoke-test exercises new digest
docker/compose.yaml hardcoded image: ghcr.io/kaitranntt/ccs:latest, causing
network-contract.sh to always use the old published image regardless of what
IMAGE_OVERRIDE was passed. Switching to \${CCS_IMAGE:-ghcr.io/kaitranntt/ccs:latest}
lets CI pass CCS_IMAGE=<digest> so the smoke-test actually exercises the
just-built image. Default end-user behaviour is unchanged.
Resolves REV4 (reviewer loop 2, PR #1261).
* fix(test): image-size.sh fails loudly on manifest inspection failure
The --platform branch previously exited 0 when imagetools inspect returned
empty or zero bytes, silently passing the budget check. A broken image
could reach production undetected if buildx had any inspection issue.
Changed to exit 1 with a clear diagnostic message explaining possible causes
(old buildx, manifest format mismatch, image not yet pushed). No --allow-inspect-failure
escape hatch is provided; CI must fix the root cause.
Resolves REV5 (reviewer loop 2, PR #1261).
* test(docker): cover --platform branch in image-size-logic tests
Prior tests only exercised the local docker image inspect path. The
--platform branch (imagetools inspect) had zero coverage, meaning the
REV5 silent-pass regression would not have been caught by CI.
Added 5 mock-based test cases for the --platform branch:
- pass when platform-scoped compressed size < budget
- fail when platform-scoped compressed size > budget
- fail (exit 1) when imagetools inspect errors (REV5 guard)
- fail (exit 1) when reported size is "0" (REV5 guard)
- fail (exit 1) when size output is empty (REV5 guard)
Mocks follow the existing pattern (override docker in PATH with a temp
wrapper), extended to handle buildx imagetools inspect subcommand.
Resolves REV6 (reviewer loop 2, PR #1261).
* fix(test): compose-parity image_name() handles \${VAR:-default} syntax
After parameterizing compose.yaml's image field with \${CCS_IMAGE:-...},
the image_name() sed pipeline cut at the first colon in the shell variable
syntax (:-) instead of the tag separator, returning '\${CCS_IMAGE' and
failing the kaitranntt/ccs grep.
Added a sed step to unwrap \${VAR:-default} by extracting just the default
value before stripping the tag. Existing plain image: name:tag references
are unaffected.
214 lines
6.4 KiB
Bash
Executable File
214 lines
6.4 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# Unit tests for image-size.sh pass/fail logic using mock docker output.
|
|
# Does NOT require a real Docker daemon or pulled images.
|
|
# Run: bash tests/docker/image-size-logic.test.sh
|
|
set -euo pipefail
|
|
|
|
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
|
|
SCRIPT="${SCRIPT_DIR}/image-size.sh"
|
|
|
|
PASS=0
|
|
FAIL=0
|
|
|
|
run_test() {
|
|
local name="$1"
|
|
local expected_exit="$2"
|
|
shift 2
|
|
# Remaining args: env vars to set before calling the script
|
|
local actual_exit=0
|
|
(
|
|
# Override docker with a mock that returns a fixed size
|
|
eval "$@"
|
|
bash "$SCRIPT" "mock-image:tag" "$MAX_BYTES" > /dev/null 2>&1
|
|
) || actual_exit=$?
|
|
|
|
if [[ "$actual_exit" -eq "$expected_exit" ]]; then
|
|
echo "[OK] ${name}"
|
|
(( PASS++ )) || true
|
|
else
|
|
echo "[X] ${name}: expected exit ${expected_exit}, got ${actual_exit}"
|
|
(( FAIL++ )) || true
|
|
fi
|
|
}
|
|
|
|
# ------------------------------------------------------------------
|
|
# We mock docker by injecting a wrapper into PATH that echoes a fixed
|
|
# size value for `docker image inspect` and pretends inspect succeeds.
|
|
# ------------------------------------------------------------------
|
|
|
|
MOCK_DIR="$(mktemp -d)"
|
|
trap 'rm -rf "$MOCK_DIR"' EXIT
|
|
|
|
make_mock_docker() {
|
|
local size="$1"
|
|
cat > "${MOCK_DIR}/docker" <<EOF
|
|
#!/usr/bin/env bash
|
|
# Mock docker for image-size.sh tests
|
|
if [[ "\$1" == "image" && "\$2" == "inspect" ]]; then
|
|
echo "${size}"
|
|
exit 0
|
|
fi
|
|
# pull / other sub-commands: succeed silently
|
|
exit 0
|
|
EOF
|
|
chmod +x "${MOCK_DIR}/docker"
|
|
}
|
|
|
|
run_mock_test() {
|
|
local name="$1"
|
|
local expected_exit="$2"
|
|
local mock_size="$3"
|
|
local max_bytes="$4"
|
|
|
|
make_mock_docker "$mock_size"
|
|
|
|
local actual_exit=0
|
|
PATH="${MOCK_DIR}:${PATH}" bash "$SCRIPT" "mock-image:tag" "$max_bytes" > /dev/null 2>&1 || actual_exit=$?
|
|
|
|
if [[ "$actual_exit" -eq "$expected_exit" ]]; then
|
|
echo "[OK] ${name}"
|
|
(( PASS++ )) || true
|
|
else
|
|
echo "[X] ${name}: expected exit ${expected_exit}, got ${actual_exit}"
|
|
(( FAIL++ )) || true
|
|
fi
|
|
}
|
|
|
|
# ------------------------------------------------------------------
|
|
# Tests
|
|
# ------------------------------------------------------------------
|
|
|
|
echo ""
|
|
echo "Running image-size.sh unit tests..."
|
|
echo ""
|
|
|
|
# Pass: actual < budget
|
|
run_mock_test "pass when actual size < budget" 0 \
|
|
"300000000" "367001600"
|
|
|
|
# Pass: actual == budget (boundary)
|
|
run_mock_test "pass when actual size == budget (boundary)" 0 \
|
|
"367001600" "367001600"
|
|
|
|
# Fail: actual > budget by 1 byte
|
|
run_mock_test "fail when actual size exceeds budget by 1 byte" 1 \
|
|
"367001601" "367001600"
|
|
|
|
# Fail: actual is much larger than budget
|
|
run_mock_test "fail when actual size greatly exceeds budget" 1 \
|
|
"900000000" "629145600"
|
|
|
|
# Error: wrong arg count (no args)
|
|
actual_exit=0
|
|
bash "$SCRIPT" > /dev/null 2>&1 || actual_exit=$?
|
|
if [[ "$actual_exit" -ne 0 ]]; then
|
|
echo "[OK] fail when called with no args"
|
|
(( PASS++ )) || true
|
|
else
|
|
echo "[X] fail when called with no args: expected non-zero exit"
|
|
(( FAIL++ )) || true
|
|
fi
|
|
|
|
# Error: non-integer max-bytes
|
|
actual_exit=0
|
|
PATH="${MOCK_DIR}:${PATH}" bash "$SCRIPT" "mock-image:tag" "not-a-number" > /dev/null 2>&1 || actual_exit=$?
|
|
if [[ "$actual_exit" -ne 0 ]]; then
|
|
echo "[OK] fail when max-bytes is not an integer"
|
|
(( PASS++ )) || true
|
|
else
|
|
echo "[X] fail when max-bytes is not an integer: expected non-zero exit"
|
|
(( FAIL++ )) || true
|
|
fi
|
|
|
|
# ------------------------------------------------------------------
|
|
# --platform branch tests (multi-arch via imagetools)
|
|
# ------------------------------------------------------------------
|
|
# Mock docker that handles `docker buildx imagetools inspect` by echoing
|
|
# a fixed layer-size string (space-separated byte counts as imagetools does).
|
|
# The mock ignores the --format flag and just prints precomputed sizes.
|
|
# ------------------------------------------------------------------
|
|
|
|
make_mock_docker_platform() {
|
|
local layer_output="$1" # space-separated byte values, e.g. "100000000 50000000"
|
|
cat > "${MOCK_DIR}/docker" <<'MOCK_EOF'
|
|
#!/usr/bin/env bash
|
|
# Mock docker for --platform branch tests
|
|
if [[ "$1" == "buildx" && "$2" == "imagetools" && "$3" == "inspect" ]]; then
|
|
MOCK_EOF
|
|
# Inject the layer_output value into the mock script
|
|
printf ' echo "%s"\n' "$layer_output" >> "${MOCK_DIR}/docker"
|
|
cat >> "${MOCK_DIR}/docker" <<'MOCK_EOF'
|
|
exit 0
|
|
fi
|
|
# image inspect / pull / other sub-commands: succeed silently
|
|
exit 0
|
|
MOCK_EOF
|
|
chmod +x "${MOCK_DIR}/docker"
|
|
}
|
|
|
|
make_mock_docker_platform_fail() {
|
|
# imagetools inspect returns nothing (simulates buildx incompatibility)
|
|
cat > "${MOCK_DIR}/docker" <<'MOCK_EOF'
|
|
#!/usr/bin/env bash
|
|
if [[ "$1" == "buildx" && "$2" == "imagetools" && "$3" == "inspect" ]]; then
|
|
exit 1
|
|
fi
|
|
exit 0
|
|
MOCK_EOF
|
|
chmod +x "${MOCK_DIR}/docker"
|
|
}
|
|
|
|
run_platform_test() {
|
|
local name="$1"
|
|
local expected_exit="$2"
|
|
local max_bytes="$3"
|
|
# mock docker already set by caller
|
|
|
|
local actual_exit=0
|
|
PATH="${MOCK_DIR}:${PATH}" bash "$SCRIPT" "mock-image:tag" "$max_bytes" \
|
|
--platform linux/amd64 > /dev/null 2>&1 || actual_exit=$?
|
|
|
|
if [[ "$actual_exit" -eq "$expected_exit" ]]; then
|
|
echo "[OK] ${name}"
|
|
(( PASS++ )) || true
|
|
else
|
|
echo "[X] ${name}: expected exit ${expected_exit}, got ${actual_exit}"
|
|
(( FAIL++ )) || true
|
|
fi
|
|
}
|
|
|
|
echo ""
|
|
echo "Running --platform branch tests..."
|
|
echo ""
|
|
|
|
# --platform pass: two layers summing to 150 MB, budget 200 MB
|
|
make_mock_docker_platform "100000000 57671680"
|
|
run_platform_test "--platform: pass when platform-scoped size < budget" 0 "209715200"
|
|
|
|
# --platform fail: two layers summing to 250 MB, budget 200 MB
|
|
make_mock_docker_platform "150000000 112000000"
|
|
run_platform_test "--platform: fail when platform-scoped size > budget" 1 "209715200"
|
|
|
|
# --platform inspect failure → must exit 1 (REV5 regression guard)
|
|
make_mock_docker_platform_fail
|
|
run_platform_test "--platform: fail loudly when imagetools inspect fails (REV5 guard)" 1 "209715200"
|
|
|
|
# --platform returns "0" → must exit 1 (REV5 guard for zero-byte output)
|
|
make_mock_docker_platform "0"
|
|
run_platform_test "--platform: fail loudly when reported size is 0 (REV5 guard)" 1 "209715200"
|
|
|
|
# --platform returns empty string → must exit 1 (REV5 guard for empty output)
|
|
make_mock_docker_platform ""
|
|
run_platform_test "--platform: fail loudly when size output is empty (REV5 guard)" 1 "209715200"
|
|
|
|
# ------------------------------------------------------------------
|
|
# Summary
|
|
# ------------------------------------------------------------------
|
|
echo ""
|
|
echo "Results: ${PASS} passed, ${FAIL} failed"
|
|
echo ""
|
|
|
|
if [[ "$FAIL" -gt 0 ]]; then
|
|
exit 1
|
|
fi
|