mirror of
https://github.com/tiennm99/ccs.git
synced 2026-07-16 20:17:45 +00:00
Sergey Galuza
a7871283d4
Bun's `mock.module()` is process-wide and is NOT undone by `mock.restore()`. Two test files used module-level mocks that leaked across test runs, silently breaking unrelated suites that imported the mocked modules transitively: - tests/unit/cliproxy/version-checker-stale-cache.test.ts mocked binary/version-checker, contaminating cliproxy-stats-routes-install and cliproxy-stats-routes-model-update suites that import a route module which transitively imports version-checker. - tests/unit/cliproxy/service-manager-startup.test.ts mocked 8 modules at top level (binary-manager, stats-fetcher, etc.), contaminating any later file that imports them. CI happens to be green because file ordering on the GitHub runner places victim files BEFORE contaminators in `bun test`. On Linux locally the order is reversed, producing 6 reproducible test failures on every `bun run test:fast` run. A change in OS, bun version, or new test files that import the mocked modules could silently flip the CI runner's order and surface these failures unexpectedly. Replaced module-level mocks with explicit dependency-injection seams in production code, following the existing pattern in version-checker.ts and version-cache.ts (`fetchJsonFn?`, `fetchLatestVersionFn?`): - src/cliproxy/types.ts: `BinaryManagerConfig.checkForUpdatesFn` (optional) - src/cliproxy/binary/lifecycle.ts: route through new fn with default - src/cliproxy/service-manager.ts: `ensureCliproxyService(deps?)` with optional `ensureBinaryFn`, `detectRunningProxyFn`, `configNeedsRegenerationFn`, `withStartupLockFn` All deps fields are optional with real-implementation defaults, so production callers are unchanged. Tests now inject deterministic stubs through call-site parameters instead of module-level mocks. Verified locally: \`bun run validate\` is now 2540 pass / 0 fail (previously 2534 pass / 6 fail at the same upstream/main HEAD). Built [OnSteroids](https://onsteroids.ai)
CCS Test Suite
Organization
tests/
├── unit/ # Module unit tests (Mocha)
│ ├── glmt/ # Legacy GLMT transformer/internal compatibility tests
│ └── delegation/ # Delegation module tests
├── npm/ # npm package tests (Mocha)
├── native/ # Native installation tests (bash/PowerShell)
│ ├── unix/ # Unix/Linux/macOS tests
│ └── windows/ # Windows PowerShell tests
├── integration/ # Integration + smoke tests
└── shared/ # Shared utilities
├── fixtures/ # Test configuration and environment
├── unit/ # Helper function tests
├── helpers.sh # Bash test utilities
└── test-data.js # Test data for npm tests
Running Tests
bun run test # All automated tests (unit + integration + npm)
bun run test:unit # Unit tests only
bun run test:npm # npm package tests
bun run test:native # Native Unix tests (bash)
Test Categories
Unit Tests (unit/)
Module-level tests using Mocha framework:
unit/glmt/- Legacy transformer internals kept for Cursor translation compatibilityunit/delegation/- Permission mode, session manager, result formatter
npm Tests (npm/)
npm package functionality tests using Mocha:
postinstall.test.js- Postinstall behaviorcli.test.js- CLI argument parsingcross-platform.test.js- Cross-platform compatibilityspecial-commands.test.js- Integration tests
Native Tests (native/)
Installation tests for curl|bash (Unix) and irm|iex (Windows):
native/unix/edge-cases.sh- Unix edge case testsnative/windows/edge-cases.ps1- Windows edge case tests
Integration Tests (integration/)
Integration and smoke coverage for scenarios that exercise multiple layers:
- Automated
*.test.tsfiles run as part ofbun run test:alland CI - Shell and standalone probe scripts remain on-demand for targeted debugging
cursor-daemon-lifecycle.test.ts- local daemon process + HTTP smoke coverageimage-analyzer-hook.test.ts- hook integration coverageglmt-integration-test.sh- legacy GLMT compatibility smoke probesymlink-chain-test.sh- Symlink chain handlingux-integration-test.sh- CLI UX integration
Adding New Tests
- Unit tests: Add to
unit/<module>/for isolated module behavior - npm tests: Add to
npm/for package behavior - Native tests: Add to
native/unix/ornative/windows/ - Integration tests: Add automated cross-layer smoke coverage to
integration/*.test.ts