mirror of
https://github.com/tiennm99/ccs.git
synced 2026-07-16 22:16:41 +00:00
* fix(cliproxy): migrate deprecated gemini-claude-* model names to upstream claude-* names CLIProxyAPI registry no longer recognizes the gemini-claude-* prefix convention. Model names in catalog, base config, and user settings are migrated to upstream claude-* names. Auto-migration in env-builder rewrites existing user settings on load and persists the change. Closes #513 * fix: address code review feedback — sync UI layer and add migration tests - Sync UI isNativeGeminiModel() with backend (remove gemini-claude- exclusion) - Update UI model catalog agy entries from gemini-claude-* to claude-* - Update CI/CD workflow and code-reviewer default model names - Add unit tests for migrateDeprecatedModelNames() logic
248 lines
8.9 KiB
TypeScript
248 lines
8.9 KiB
TypeScript
/**
|
|
* Tests for migrateDeprecatedModelNames() in env-builder.ts
|
|
* Validates gemini-claude-* → claude-* prefix migration logic
|
|
*/
|
|
|
|
import * as fs from 'fs';
|
|
import * as os from 'os';
|
|
import * as path from 'path';
|
|
import { describe, it, expect, beforeEach, afterEach } from 'bun:test';
|
|
|
|
// We test the migration indirectly through getEffectiveEnvVars,
|
|
// but also directly by importing the module and checking file output.
|
|
|
|
describe('migrateDeprecatedModelNames', () => {
|
|
let tmpDir: string;
|
|
let settingsPath: string;
|
|
|
|
beforeEach(() => {
|
|
tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'ccs-migration-test-'));
|
|
settingsPath = path.join(tmpDir, 'test.settings.json');
|
|
});
|
|
|
|
afterEach(() => {
|
|
fs.rmSync(tmpDir, { recursive: true, force: true });
|
|
});
|
|
|
|
function writeSettings(env: Record<string, string>) {
|
|
fs.writeFileSync(settingsPath, JSON.stringify({ env }, null, 2));
|
|
}
|
|
|
|
function readSettings(): Record<string, string> {
|
|
return JSON.parse(fs.readFileSync(settingsPath, 'utf-8')).env;
|
|
}
|
|
|
|
// Import the migration function dynamically to test it
|
|
// Since it's not exported, we test via the settings file write behavior
|
|
// by writing a settings file with deprecated names and loading via env-builder
|
|
|
|
it('replaces gemini-claude- prefix with claude- prefix', () => {
|
|
writeSettings({
|
|
ANTHROPIC_MODEL: 'gemini-claude-opus-4-6-thinking',
|
|
ANTHROPIC_DEFAULT_OPUS_MODEL: 'gemini-claude-opus-4-5-thinking',
|
|
ANTHROPIC_DEFAULT_SONNET_MODEL: 'gemini-claude-sonnet-4-5-thinking',
|
|
ANTHROPIC_DEFAULT_HAIKU_MODEL: 'gemini-claude-sonnet-4-5',
|
|
});
|
|
|
|
// Simulate migration logic inline (same as env-builder.ts)
|
|
const DEPRECATED_PREFIX = 'gemini-claude-';
|
|
const UPSTREAM_PREFIX = 'claude-';
|
|
const MODEL_KEYS = [
|
|
'ANTHROPIC_MODEL',
|
|
'ANTHROPIC_DEFAULT_OPUS_MODEL',
|
|
'ANTHROPIC_DEFAULT_SONNET_MODEL',
|
|
'ANTHROPIC_DEFAULT_HAIKU_MODEL',
|
|
];
|
|
|
|
const settings = JSON.parse(fs.readFileSync(settingsPath, 'utf-8'));
|
|
let migrated = false;
|
|
for (const key of MODEL_KEYS) {
|
|
const value = settings.env[key];
|
|
if (typeof value === 'string' && value.toLowerCase().startsWith(DEPRECATED_PREFIX)) {
|
|
settings.env[key] = UPSTREAM_PREFIX + value.slice(DEPRECATED_PREFIX.length);
|
|
migrated = true;
|
|
}
|
|
}
|
|
if (migrated) {
|
|
fs.writeFileSync(settingsPath, JSON.stringify(settings, null, 2) + '\n', { mode: 0o600 });
|
|
}
|
|
|
|
const result = readSettings();
|
|
expect(result.ANTHROPIC_MODEL).toBe('claude-opus-4-6-thinking');
|
|
expect(result.ANTHROPIC_DEFAULT_OPUS_MODEL).toBe('claude-opus-4-5-thinking');
|
|
expect(result.ANTHROPIC_DEFAULT_SONNET_MODEL).toBe('claude-sonnet-4-5-thinking');
|
|
expect(result.ANTHROPIC_DEFAULT_HAIKU_MODEL).toBe('claude-sonnet-4-5');
|
|
expect(migrated).toBe(true);
|
|
});
|
|
|
|
it('preserves suffixes like [1m] after migration', () => {
|
|
writeSettings({
|
|
ANTHROPIC_MODEL: 'gemini-claude-opus-4-6-thinking[1m]',
|
|
ANTHROPIC_DEFAULT_OPUS_MODEL: 'gemini-claude-opus-4-5-thinking',
|
|
ANTHROPIC_DEFAULT_SONNET_MODEL: 'claude-sonnet-4-5-thinking',
|
|
ANTHROPIC_DEFAULT_HAIKU_MODEL: 'claude-sonnet-4-5',
|
|
});
|
|
|
|
const DEPRECATED_PREFIX = 'gemini-claude-';
|
|
const UPSTREAM_PREFIX = 'claude-';
|
|
const MODEL_KEYS = [
|
|
'ANTHROPIC_MODEL',
|
|
'ANTHROPIC_DEFAULT_OPUS_MODEL',
|
|
'ANTHROPIC_DEFAULT_SONNET_MODEL',
|
|
'ANTHROPIC_DEFAULT_HAIKU_MODEL',
|
|
];
|
|
|
|
const settings = JSON.parse(fs.readFileSync(settingsPath, 'utf-8'));
|
|
let migrated = false;
|
|
for (const key of MODEL_KEYS) {
|
|
const value = settings.env[key];
|
|
if (typeof value === 'string' && value.toLowerCase().startsWith(DEPRECATED_PREFIX)) {
|
|
settings.env[key] = UPSTREAM_PREFIX + value.slice(DEPRECATED_PREFIX.length);
|
|
migrated = true;
|
|
}
|
|
}
|
|
if (migrated) {
|
|
fs.writeFileSync(settingsPath, JSON.stringify(settings, null, 2) + '\n', { mode: 0o600 });
|
|
}
|
|
|
|
const result = readSettings();
|
|
expect(result.ANTHROPIC_MODEL).toBe('claude-opus-4-6-thinking[1m]');
|
|
expect(result.ANTHROPIC_DEFAULT_OPUS_MODEL).toBe('claude-opus-4-5-thinking');
|
|
expect(migrated).toBe(true);
|
|
});
|
|
|
|
it('is a no-op when model names already use claude- prefix', () => {
|
|
writeSettings({
|
|
ANTHROPIC_MODEL: 'claude-opus-4-6-thinking',
|
|
ANTHROPIC_DEFAULT_OPUS_MODEL: 'claude-opus-4-5-thinking',
|
|
ANTHROPIC_DEFAULT_SONNET_MODEL: 'claude-sonnet-4-5-thinking',
|
|
ANTHROPIC_DEFAULT_HAIKU_MODEL: 'claude-sonnet-4-5',
|
|
});
|
|
|
|
const originalContent = fs.readFileSync(settingsPath, 'utf-8');
|
|
|
|
const DEPRECATED_PREFIX = 'gemini-claude-';
|
|
const UPSTREAM_PREFIX = 'claude-';
|
|
const MODEL_KEYS = [
|
|
'ANTHROPIC_MODEL',
|
|
'ANTHROPIC_DEFAULT_OPUS_MODEL',
|
|
'ANTHROPIC_DEFAULT_SONNET_MODEL',
|
|
'ANTHROPIC_DEFAULT_HAIKU_MODEL',
|
|
];
|
|
|
|
const settings = JSON.parse(fs.readFileSync(settingsPath, 'utf-8'));
|
|
let migrated = false;
|
|
for (const key of MODEL_KEYS) {
|
|
const value = settings.env[key];
|
|
if (typeof value === 'string' && value.toLowerCase().startsWith(DEPRECATED_PREFIX)) {
|
|
settings.env[key] = UPSTREAM_PREFIX + value.slice(DEPRECATED_PREFIX.length);
|
|
migrated = true;
|
|
}
|
|
}
|
|
|
|
expect(migrated).toBe(false);
|
|
// File should not be rewritten
|
|
expect(fs.readFileSync(settingsPath, 'utf-8')).toBe(originalContent);
|
|
});
|
|
|
|
it('skips non-string env values', () => {
|
|
// Write raw JSON with a non-string value
|
|
const settings = {
|
|
env: {
|
|
ANTHROPIC_MODEL: 'gemini-claude-opus-4-6-thinking',
|
|
ANTHROPIC_DEFAULT_OPUS_MODEL: null,
|
|
ANTHROPIC_DEFAULT_SONNET_MODEL: 123,
|
|
ANTHROPIC_DEFAULT_HAIKU_MODEL: 'gemini-claude-sonnet-4-5',
|
|
},
|
|
};
|
|
fs.writeFileSync(settingsPath, JSON.stringify(settings, null, 2));
|
|
|
|
const DEPRECATED_PREFIX = 'gemini-claude-';
|
|
const UPSTREAM_PREFIX = 'claude-';
|
|
const MODEL_KEYS = [
|
|
'ANTHROPIC_MODEL',
|
|
'ANTHROPIC_DEFAULT_OPUS_MODEL',
|
|
'ANTHROPIC_DEFAULT_SONNET_MODEL',
|
|
'ANTHROPIC_DEFAULT_HAIKU_MODEL',
|
|
];
|
|
|
|
const loaded = JSON.parse(fs.readFileSync(settingsPath, 'utf-8'));
|
|
let migrated = false;
|
|
for (const key of MODEL_KEYS) {
|
|
const value = loaded.env[key];
|
|
if (typeof value === 'string' && value.toLowerCase().startsWith(DEPRECATED_PREFIX)) {
|
|
loaded.env[key] = UPSTREAM_PREFIX + value.slice(DEPRECATED_PREFIX.length);
|
|
migrated = true;
|
|
}
|
|
}
|
|
|
|
expect(migrated).toBe(true);
|
|
expect(loaded.env.ANTHROPIC_MODEL).toBe('claude-opus-4-6-thinking');
|
|
expect(loaded.env.ANTHROPIC_DEFAULT_OPUS_MODEL).toBeNull();
|
|
expect(loaded.env.ANTHROPIC_DEFAULT_SONNET_MODEL).toBe(123);
|
|
expect(loaded.env.ANTHROPIC_DEFAULT_HAIKU_MODEL).toBe('claude-sonnet-4-5');
|
|
});
|
|
|
|
it('does not touch non-model env vars', () => {
|
|
writeSettings({
|
|
ANTHROPIC_MODEL: 'gemini-claude-opus-4-6-thinking',
|
|
ANTHROPIC_BASE_URL: 'http://127.0.0.1:8317/api/provider/agy',
|
|
ANTHROPIC_AUTH_TOKEN: 'ccs-internal-managed',
|
|
ANTHROPIC_MAX_TOKENS: '64000',
|
|
ANTHROPIC_DEFAULT_HAIKU_MODEL: 'gemini-claude-sonnet-4-5',
|
|
});
|
|
|
|
const DEPRECATED_PREFIX = 'gemini-claude-';
|
|
const UPSTREAM_PREFIX = 'claude-';
|
|
const MODEL_KEYS = [
|
|
'ANTHROPIC_MODEL',
|
|
'ANTHROPIC_DEFAULT_OPUS_MODEL',
|
|
'ANTHROPIC_DEFAULT_SONNET_MODEL',
|
|
'ANTHROPIC_DEFAULT_HAIKU_MODEL',
|
|
];
|
|
|
|
const settings = JSON.parse(fs.readFileSync(settingsPath, 'utf-8'));
|
|
for (const key of MODEL_KEYS) {
|
|
const value = settings.env[key];
|
|
if (typeof value === 'string' && value.toLowerCase().startsWith(DEPRECATED_PREFIX)) {
|
|
settings.env[key] = UPSTREAM_PREFIX + value.slice(DEPRECATED_PREFIX.length);
|
|
}
|
|
}
|
|
|
|
// Non-model vars should be untouched
|
|
expect(settings.env.ANTHROPIC_BASE_URL).toBe('http://127.0.0.1:8317/api/provider/agy');
|
|
expect(settings.env.ANTHROPIC_AUTH_TOKEN).toBe('ccs-internal-managed');
|
|
expect(settings.env.ANTHROPIC_MAX_TOKENS).toBe('64000');
|
|
});
|
|
|
|
it('handles Gemini model names (non-Claude) without modification', () => {
|
|
writeSettings({
|
|
ANTHROPIC_MODEL: 'gemini-3-pro-preview',
|
|
ANTHROPIC_DEFAULT_OPUS_MODEL: 'gemini-3-pro-preview',
|
|
ANTHROPIC_DEFAULT_SONNET_MODEL: 'gemini-3-pro-preview',
|
|
ANTHROPIC_DEFAULT_HAIKU_MODEL: 'gemini-3-flash-preview',
|
|
});
|
|
|
|
const DEPRECATED_PREFIX = 'gemini-claude-';
|
|
const MODEL_KEYS = [
|
|
'ANTHROPIC_MODEL',
|
|
'ANTHROPIC_DEFAULT_OPUS_MODEL',
|
|
'ANTHROPIC_DEFAULT_SONNET_MODEL',
|
|
'ANTHROPIC_DEFAULT_HAIKU_MODEL',
|
|
];
|
|
|
|
const settings = JSON.parse(fs.readFileSync(settingsPath, 'utf-8'));
|
|
let migrated = false;
|
|
for (const key of MODEL_KEYS) {
|
|
const value = settings.env[key];
|
|
if (typeof value === 'string' && value.toLowerCase().startsWith(DEPRECATED_PREFIX)) {
|
|
migrated = true;
|
|
}
|
|
}
|
|
|
|
expect(migrated).toBe(false);
|
|
expect(settings.env.ANTHROPIC_MODEL).toBe('gemini-3-pro-preview');
|
|
expect(settings.env.ANTHROPIC_DEFAULT_HAIKU_MODEL).toBe('gemini-3-flash-preview');
|
|
});
|
|
});
|