tiennm99/coolify
1
0
Fork 0
mirror of https://github.com/tiennm99/coolify.git synced 2026-04-17 19:21:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(validation): update git:// URL validation to support port numbers and tilde characters in paths

Browse Source
This commit is contained in:
Andras Bacsai
2025-09-29 12:21:15 +02:00
parent a8bdc3bbfe
commit 502dd72a34
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/Rules/ValidGitRepositoryUrl.php
View File

@@ -142,8 +142,8 @@ class ValidGitRepositoryUrl implements ValidationRule
return; return;
} }
} elseif (str_starts_with($value, 'git://')) { } elseif (str_starts_with($value, 'git://')) {
// Validate git:// protocol URL // Validate git:// protocol URL (supports both git://host/path and git://host:port/path with tilde)
if (! preg_match('/^git:\/\/[a-zA-Z0-9\.\-]+\/[a-zA-Z0-9\-_\/\.]+$/', $value)) { if (! preg_match('/^git:\/\/[a-zA-Z0-9\.\-]+(:[0-9]+)?[:\/][a-zA-Z0-9\-_\/\.~]+$/', $value)) {
$fail('The :attribute is not a valid git:// URL.'); $fail('The :attribute is not a valid git:// URL.');
return; return;

1
tests/Unit/ValidGitRepositoryUrlTest.php
View File

@@ -136,6 +136,7 @@ it('validates git:// protocol URLs', function () {
$validUrls = [ $validUrls = [
'git://github.com/user/repo.git', 'git://github.com/user/repo.git',
'git://gitlab.com/user/repo.git', 'git://gitlab.com/user/repo.git',
'git://git.sr.ht:~user/repo.git',
]; ];
foreach ($validUrls as $url) { foreach ($validUrls as $url) {