tiennm99/coolify
1
0
Fork 0
mirror of https://github.com/tiennm99/coolify.git synced 2026-04-29 00:20:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: streamline allowed IPs validation and enhance UI warnings for API access

Browse Source
This commit is contained in:
Andras Bacsai
2025-10-26 10:57:24 +01:00
parent b678242780
commit 6e74317cb5
2 changed files with 89 additions and 88 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/Livewire/Settings/Advanced.php
+2 -17
View File
@@ -85,14 +85,8 @@ class Advanced extends Component
// Handle allowed IPs with subnet support and 0.0.0.0 special case
$this->allowed_ips = str($this->allowed_ips)->replaceEnd(',', '')->trim();
// Check if user entered 0.0.0.0 or left field empty (both allow access from anywhere)
$allowsFromAnywhere = false;
if (empty($this->allowed_ips)) {
$allowsFromAnywhere = true;
} elseif (in_array('0.0.0.0', array_map('trim', explode(',', $this->allowed_ips)))) {
$allowsFromAnywhere = true;
} else {
// Validate and clean up the entries
// Only validate and clean up if we have IPs and it's not 0.0.0.0 (allow all)
if (! empty($this->allowed_ips) && ! in_array('0.0.0.0', array_map('trim', explode(',', $this->allowed_ips)))) {
$invalidEntries = [];
$validEntries = str($this->allowed_ips)->trim()->explode(',')->map(function ($entry) use (&$invalidEntries) {
$entry = str($entry)->trim()->toString();
@@ -128,7 +122,6 @@ class Advanced extends Component
return;
}
// Also check if we have no valid entries after filtering
if ($validEntries->isEmpty()) {
$this->dispatch('error', 'No valid IP addresses or subnets provided');
@@ -139,14 +132,6 @@ class Advanced extends Component
}
$this->instantSave();
// Show security warning if allowing access from anywhere
if ($allowsFromAnywhere) {
$message = empty($this->allowed_ips)
? 'Empty IP allowlist allows API access from anywhere.<br><br>This is not recommended for production environments!'
: 'Using 0.0.0.0 allows API access from anywhere.<br><br>This is not recommended for production environments!';
$this->dispatch('warning', $message);
}
} catch (\Exception $e) {
return handleError($e, $this);
}