refactor(railpack): extract static image build, fix port logic, bump to v0.22.0

Extract build_railpack_static_image() into its own method, prevent port
override when is_static is set, bump Railpack to 0.22.0, and improve
test setup with beforeEach and correct polymorphic env var fields.

tests/Feature/ApplicationBuildpackCleanupTest.php

@@ -78,26 +78,29 @@ describe('Application Model Buildpack Cleanup', function () {
 
         // Add environment variables that should be deleted
         EnvironmentVariable::create([
-            'application_id' => $application->id,
+            'resourceable_type' => Application::class,
+            'resourceable_id' => $application->id,
             'key' => 'SERVICE_FQDN_APP',
             'value' => 'app.example.com',
-            'is_build_time' => false,
+            'is_buildtime' => false,
             'is_preview' => false,
         ]);
 
         EnvironmentVariable::create([
-            'application_id' => $application->id,
+            'resourceable_type' => Application::class,
+            'resourceable_id' => $application->id,
             'key' => 'SERVICE_URL_APP',
             'value' => 'http://app.example.com',
-            'is_build_time' => false,
+            'is_buildtime' => false,
             'is_preview' => false,
         ]);
 
         EnvironmentVariable::create([
-            'application_id' => $application->id,
+            'resourceable_type' => Application::class,
+            'resourceable_id' => $application->id,
             'key' => 'REGULAR_VAR',
             'value' => 'should_remain',
-            'is_build_time' => false,
+            'is_buildtime' => false,
             'is_preview' => false,
         ]);
 
@@ -154,6 +157,34 @@ describe('Application Model Buildpack Cleanup', function () {
             'docker_compose_raw' => 'version: "3.8"\nservices:\n  app:\n    image: nginx',
         ]);
 
+        // Add environment variables that should be deleted
+        EnvironmentVariable::create([
+            'resourceable_type' => Application::class,
+            'resourceable_id' => $application->id,
+            'key' => 'SERVICE_FQDN_APP',
+            'value' => 'app.example.com',
+            'is_buildtime' => false,
+            'is_preview' => false,
+        ]);
+
+        EnvironmentVariable::create([
+            'resourceable_type' => Application::class,
+            'resourceable_id' => $application->id,
+            'key' => 'SERVICE_URL_APP',
+            'value' => 'http://app.example.com',
+            'is_buildtime' => false,
+            'is_preview' => false,
+        ]);
+
+        EnvironmentVariable::create([
+            'resourceable_type' => Application::class,
+            'resourceable_id' => $application->id,
+            'key' => 'REGULAR_VAR',
+            'value' => 'should_remain',
+            'is_buildtime' => false,
+            'is_preview' => false,
+        ]);
+
         $application->build_pack = 'railpack';
         $application->save();
         $application->refresh();
@@ -161,6 +192,13 @@ describe('Application Model Buildpack Cleanup', function () {
         expect($application->build_pack)->toBe('railpack');
         expect($application->docker_compose_domains)->toBeNull();
         expect($application->docker_compose_raw)->toBeNull();
+
+        // Verify SERVICE_FQDN_* and SERVICE_URL_* were deleted
+        expect($application->environment_variables()->where('key', 'SERVICE_FQDN_APP')->count())->toBe(0);
+        expect($application->environment_variables()->where('key', 'SERVICE_URL_APP')->count())->toBe(0);
+
+        // Verify regular variables remain
+        expect($application->environment_variables()->where('key', 'REGULAR_VAR')->count())->toBe(1);
     });
 
     test('model does not clear dockerfile fields when switching to dockerfile', function () {

tests/Feature/ApplicationRailpackTest.php

@@ -10,13 +10,15 @@ use Illuminate\Foundation\Testing\RefreshDatabase;
 uses(RefreshDatabase::class);
 
 describe('Application Railpack Support', function () {
-    test('could_set_build_commands returns true for railpack', function () {
+    beforeEach(function () {
         $team = Team::factory()->create();
         $project = Project::factory()->create(['team_id' => $team->id]);
-        $environment = Environment::factory()->create(['project_id' => $project->id]);
+        $this->environment = Environment::factory()->create(['project_id' => $project->id]);
+    });
 
+    test('could_set_build_commands returns true for railpack', function () {
         $application = Application::factory()->create([
-            'environment_id' => $environment->id,
+            'environment_id' => $this->environment->id,
             'build_pack' => 'railpack',
         ]);
 
@@ -24,12 +26,8 @@ describe('Application Railpack Support', function () {
     });
 
     test('could_set_build_commands returns true for nixpacks', function () {
-        $team = Team::factory()->create();
-        $project = Project::factory()->create(['team_id' => $team->id]);
-        $environment = Environment::factory()->create(['project_id' => $project->id]);
-
         $application = Application::factory()->create([
-            'environment_id' => $environment->id,
+            'environment_id' => $this->environment->id,
             'build_pack' => 'nixpacks',
         ]);
 
@@ -37,12 +35,8 @@ describe('Application Railpack Support', function () {
     });
 
     test('could_set_build_commands returns false for dockerfile', function () {
-        $team = Team::factory()->create();
-        $project = Project::factory()->create(['team_id' => $team->id]);
-        $environment = Environment::factory()->create(['project_id' => $project->id]);
-
         $application = Application::factory()->create([
-            'environment_id' => $environment->id,
+            'environment_id' => $this->environment->id,
             'build_pack' => 'dockerfile',
         ]);
 
@@ -50,12 +44,8 @@ describe('Application Railpack Support', function () {
     });
 
     test('railpack_environment_variables returns only RAILPACK_ prefixed vars', function () {
-        $team = Team::factory()->create();
-        $project = Project::factory()->create(['team_id' => $team->id]);
-        $environment = Environment::factory()->create(['project_id' => $project->id]);
-
         $application = Application::factory()->create([
-            'environment_id' => $environment->id,
+            'environment_id' => $this->environment->id,
             'build_pack' => 'railpack',
         ]);
 
@@ -92,12 +82,8 @@ describe('Application Railpack Support', function () {
     });
 
     test('runtime_environment_variables excludes RAILPACK_ and NIXPACKS_ prefixed vars', function () {
-        $team = Team::factory()->create();
-        $project = Project::factory()->create(['team_id' => $team->id]);
-        $environment = Environment::factory()->create(['project_id' => $project->id]);
-
         $application = Application::factory()->create([
-            'environment_id' => $environment->id,
+            'environment_id' => $this->environment->id,
             'build_pack' => 'railpack',
         ]);
 
@@ -134,12 +120,8 @@ describe('Application Railpack Support', function () {
     });
 
     test('railpack_environment_variables_preview returns only RAILPACK_ prefixed preview vars', function () {
-        $team = Team::factory()->create();
-        $project = Project::factory()->create(['team_id' => $team->id]);
-        $environment = Environment::factory()->create(['project_id' => $project->id]);
-
         $application = Application::factory()->create([
-            'environment_id' => $environment->id,
+            'environment_id' => $this->environment->id,
             'build_pack' => 'railpack',
         ]);