tiennm99/coolify
1
0
Fork 0
mirror of https://github.com/tiennm99/coolify.git synced 2026-08-22 22:23:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(storage): use escapeshellarg for volume names in shell commands

Browse Source 
Add proper shell escaping for persistent volume names when used in
docker volume rm commands. Also add volume name validation pattern
to ValidationPatterns for consistent input checking.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Andras Bacsai
2026-03-26 11:06:30 +01:00
co-authored by Claude Opus 4.6
parent d77e4c864f
commit d2064dd499
14 changed files with 149 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/Models/ApplicationPreview.php
+1 -1
View File
@@ -37,7 +37,7 @@ class ApplicationPreview extends BaseModel
$persistentStorages = $preview->persistentStorages()->get() ?? collect();
if ($persistentStorages->count() > 0) {
foreach ($persistentStorages as $storage) {
instant_remote_process(["docker volume rm -f $storage->name"], $server, false);
instant_remote_process(['docker volume rm -f '.escapeshellarg($storage->name)], $server, false);
}
}
}