mirror of
https://github.com/tiennm99/coolify.git
synced 2026-08-20 02:27:57 +00:00
Mike ChongandAndras Bacsai
a26091de0a
Adds self-hosted GitLab OAuth sources so Coolify can connect to a self-managed GitLab instance, list private repositories, clone over an OAuth token, and deploy (the GitLab counterpart to GitHub Apps). Hardening: authenticated, one-time team-bound OAuth callback state; token redaction in deploy logs; custom host port/path kept in clone and ls-remote URLs; submodule OAuth auth; system-wide source selection. Covered by unit and feature tests. cosigned by OpenAI Codex at M1 Max
52 lines
1.6 KiB
PHP
52 lines
1.6 KiB
PHP
<?php
|
|
|
|
use App\Models\GitlabApp;
|
|
use App\Models\Team;
|
|
use App\Models\User;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
beforeEach(function () {
|
|
$this->team = Team::factory()->create();
|
|
$this->user = User::factory()->create();
|
|
$this->team->members()->attach($this->user->id, ['role' => 'owner']);
|
|
|
|
$this->actingAs($this->user);
|
|
session(['currentTeam' => $this->team]);
|
|
});
|
|
|
|
test('ownedByCurrentTeam resolves a system-wide GitLab source owned by another team', function () {
|
|
$otherTeam = Team::factory()->create();
|
|
|
|
$systemWide = GitlabApp::create([
|
|
'name' => 'Shared GitLab',
|
|
'api_url' => 'https://gitlab.example.com/api/v4',
|
|
'html_url' => 'https://gitlab.example.com',
|
|
'team_id' => $otherTeam->id,
|
|
'is_system_wide' => true,
|
|
'is_public' => false,
|
|
]);
|
|
|
|
// Mirrors Source::changeSource() resolution; before the fix this returned null for system-wide sources (404).
|
|
$resolved = GitlabApp::ownedByCurrentTeam()->find($systemWide->id);
|
|
|
|
expect($resolved)->not->toBeNull();
|
|
expect($resolved->id)->toBe($systemWide->id);
|
|
});
|
|
|
|
test('ownedByCurrentTeam still excludes other teams private (non system-wide) sources', function () {
|
|
$otherTeam = Team::factory()->create();
|
|
|
|
$foreign = GitlabApp::create([
|
|
'name' => 'Foreign GitLab',
|
|
'api_url' => 'https://gitlab.example.com/api/v4',
|
|
'html_url' => 'https://gitlab.example.com',
|
|
'team_id' => $otherTeam->id,
|
|
'is_system_wide' => false,
|
|
'is_public' => false,
|
|
]);
|
|
|
|
expect(GitlabApp::ownedByCurrentTeam()->find($foreign->id))->toBeNull();
|
|
});
|