mirror of
https://github.com/tiennm99/ghstats.git
synced 2026-09-03 04:18:10 +00:00
feat: let commits-per-repo 0 mean every commit
The pagination guard broke on seen >= maxPerRepo, so a cap of 0 stopped before the first page and rendered empty productive-time, productive-weekday and most-commit-language cards. That inverted the meaning 0 carries for top-repos, where it already means unlimited. Treat a cap of 0 or less as no cap. Verified against a real repo: a cap of 100 still stops at 100, while 500 and 0 both walk the full 382-commit history.
This commit is contained in:
@@ -0,0 +1,27 @@
|
||||
package github
|
||||
|
||||
import "testing"
|
||||
|
||||
func TestReachedCommitCap(t *testing.T) {
|
||||
cases := []struct {
|
||||
name string
|
||||
seen int
|
||||
maxPerRepo int
|
||||
want bool
|
||||
}{
|
||||
{"under the cap", 100, 500, false},
|
||||
{"at the cap", 500, 500, true},
|
||||
{"past the cap", 700, 500, true},
|
||||
// Zero means unlimited, so even a fresh repo keeps paginating. The
|
||||
// old behavior stopped here and rendered empty commit-derived cards.
|
||||
{"zero cap, nothing seen yet", 0, 0, false},
|
||||
{"zero cap, deep into history", 100_000, 0, false},
|
||||
{"negative cap treated as unlimited", 10, -1, false},
|
||||
}
|
||||
for _, tc := range cases {
|
||||
if got := reachedCommitCap(tc.seen, tc.maxPerRepo); got != tc.want {
|
||||
t.Errorf("%s: reachedCommitCap(%d, %d) = %v, want %v",
|
||||
tc.name, tc.seen, tc.maxPerRepo, got, tc.want)
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -30,9 +30,21 @@ type productiveGQL struct {
|
||||
// magnitude is irrelevant because the card renders percentages.
|
||||
const scaleFactor = 10_000
|
||||
|
||||
// reachedCommitCap reports whether a repo has given up enough commits to stop
|
||||
// paginating. A cap of zero or less means no cap — keep going until the
|
||||
// history runs out — matching how -top-repos treats zero. Without the guard a
|
||||
// zero cap would stop before the first page and quietly empty every
|
||||
// commit-derived card.
|
||||
func reachedCommitCap(seen, maxPerRepo int) bool {
|
||||
if maxPerRepo <= 0 {
|
||||
return false
|
||||
}
|
||||
return seen >= maxPerRepo
|
||||
}
|
||||
|
||||
// FetchProductive paginates the default-branch commit history (authored by
|
||||
// the target user) for each repo up to maxPerRepo commits, and fills two
|
||||
// parallel sets of aggregates on the Profile:
|
||||
// the target user) for each repo up to maxPerRepo commits (0 = all), and
|
||||
// fills two parallel sets of aggregates on the Profile:
|
||||
//
|
||||
// - Last-year: p.Productive (24h histogram) and p.CommitsByLanguage
|
||||
// - All-time: p.ProductiveAllTime and p.CommitsByLanguageAllTime
|
||||
@@ -62,7 +74,7 @@ func (c *Client) FetchProductive(ctx context.Context, p *Profile, repos []RepoIn
|
||||
var cursor *string
|
||||
seen := 0
|
||||
for {
|
||||
if seen >= maxPerRepo {
|
||||
if reachedCommitCap(seen, maxPerRepo) {
|
||||
break
|
||||
}
|
||||
owner := repo.Owner
|
||||
|
||||
Reference in New Issue
Block a user