tiennm99/github-readme-stats
1
0
Fork 0
mirror of https://github.com/tiennm99/github-readme-stats.git synced 2026-08-08 22:24:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: change confusing behavior of showing 0 commints when upstream API fails (#3238)

Browse Source
This commit is contained in:
Alexandr Garbuzov
2023-09-17 11:14:40 +02:00
committed by GitHub
parent 518747e99d
commit 64f56e88b4
2 changed files with 19 additions and 60 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/fetchers/stats-fetcher.js
+11 -10
View File
@@ -153,8 +153,8 @@ const statsFetcher = async (username) => {
*/
const totalCommitsFetcher = async (username) => {
if (!githubUsernameRegex.test(username)) {
logger.log("Invalid username");
return 0;
logger.log("Invalid username provided.");
throw new Error("Invalid username provided.");
}
// https://developer.github.com/v3/search/#search-commits
@@ -170,18 +170,19 @@ const totalCommitsFetcher = async (username) => {
});
};
let res;
try {
let res = await retryer(fetchTotalCommits, { login: username });
let total_count = res.data.total_count;
if (!!total_count && !isNaN(total_count)) {
return res.data.total_count;
}
res = await retryer(fetchTotalCommits, { login: username });
} catch (err) {
logger.log(err);
throw new Error(err);
}
// just return 0 if there is something wrong so that
// we don't break the whole app
return 0;
const totalCount = res.data.total_count;
if (!totalCount || isNaN(totalCount)) {
throw new Error("Could not fetch total commits.");
}
return totalCount;
};
/**