mirror of
https://github.com/tiennm99/goclaw.git
synced 2026-08-10 16:22:13 +00:00
viettranx
b7592bcacf
Wave 1 Phase 03. Wires the Phase 02 Goja handler into the dispatcher, widens
the DB schema for script + builtin sources, and refactors Dispatcher.Fire to
return a FireResult so builtin-source hooks can mutate event input.
Dispatcher:
- FireResult{Decision, UpdatedToolInput, UpdatedRawInput} replaces the plain
Decision return. stdDispatcher.runSync keeps a local evMut copy so a
builtin-source hook's updatedInput flows to downstream hooks in the chain
and to the caller; non-builtin (source=ui) script mutations are dropped +
WARN-logged (defense-in-depth; source tier enforced at the dispatcher, not
only at the handler).
- applyBuiltinMutation + placeholder builtinAllowlistFor (rawInput, toolInput)
— Phase 04 overrides the allowlist from builtins.yaml.
- noopDispatcher returns FireResult{DecisionAllow}.
- Script mutation tests: TestDispatcher_ScriptMutation_BuiltinSourceApplies,
TestDispatcher_ScriptMutation_UISourceDenied.
Pipeline + callers (14 Fire sites refactored):
- FireHook wrapper returns FireResult; context_stage.go:52 applies
UpdatedRawInput → state.Input.Message; tool_stage.go:52 applies
UpdatedToolInput → tc.Arguments before ExecuteToolCall.
- delegate_bridge + delegate_tool keep the Decision branch; Updated* ignored.
- dispatcher_test / delegate_bridge_test / delegate_tool_hooks_test /
integration test helpers updated for the new shape.
Validation:
- edition_gate allows HandlerScript on every edition (sandboxed, no shell
escape surface).
- config.validateHandler rejects empty source, source > 32 KiB, goja compile
error; validateTimeout rejects on_timeout=ask|defer (reserved).
- Six new config tests cover the script path.
Migrations:
- PG migration 000053 relaxes handler_type + source CHECKs and drops
uq_hooks_{global,tenant,agent} — scripts routinely want many small hooks
per event. RequiredSchemaVersion → 53.
- SQLite SchemaVersion → 21; patch 20 is a SELECT 1 placeholder because
SQLite can't ALTER a CHECK — rebuildAgentHooksV21 runs outside the
migration tx (parallel to backfillV16) to rename/recreate the table with
widened CHECKs. schema.sql fresh-DB path matches.
- H9 fix: PGHookStore.Create + SqliteHookStore.Create honor caller-provided
cfg.ID (uuid.Nil falls back to UUIDv7), unblocking Phase 04 idempotent
UUIDv5 seed. TestCreateHonorsFixedID on both stores.
Config:
- config.HooksConfig{ScriptConcurrency, ScriptPerTenantConcurrency,
ScriptCacheSize, BuiltinDisable}; buildHookHandlers wires the script
handler with the caps from appCfg.Hooks.
Gates green: go build ./... + sqliteonly, go test -race -count=1 across
hooks/pipeline/sqlitestore.
31 lines
1.2 KiB
Go
31 lines
1.2 KiB
Go
package hooks
|
|
|
|
import "github.com/nextlevelbuilder/goclaw/internal/edition"
|
|
|
|
// HookEditionPolicy is a pure-function policy gate applied at BOTH config
|
|
// validation time AND at dispatcher fire time (defense-in-depth).
|
|
//
|
|
// Rule: the `command` handler executes arbitrary shell; it is only safe in
|
|
// the Lite edition where the operator physically owns the host. On Standard
|
|
// (multi-tenant managed hosting), `command` is blocked across every scope
|
|
// (C2 drop decision). `http` and `prompt` are allowed on both editions.
|
|
type HookEditionPolicy struct{}
|
|
|
|
// Allow returns (ok, reason). reason is only set when ok=false.
|
|
// reason is a stable string suitable for audit rows and i18n key lookup.
|
|
func (HookEditionPolicy) Allow(ht HandlerType, _ Scope, ed edition.Edition) (bool, string) {
|
|
switch ht {
|
|
case HandlerHTTP, HandlerPrompt, HandlerScript:
|
|
// Script hooks run in a sandboxed goja runtime — no shell escape surface.
|
|
// Allowed on every edition for tenant admin + operator authors alike.
|
|
return true, ""
|
|
case HandlerCommand:
|
|
if ed.Name == edition.Lite.Name {
|
|
return true, ""
|
|
}
|
|
return false, "hook.command_disabled_standard"
|
|
default:
|
|
return false, "hook.unknown_handler_type"
|
|
}
|
|
}
|