mirror of
https://github.com/tiennm99/goclaw.git
synced 2026-08-16 22:23:42 +00:00
read_image and read_document failed when only claude-cli was configured because the fallback chains only listed 'anthropic'. Adding claude-cli as fallback (PR #802) surfaced a deeper bug: buildStreamJSONInput hardcoded 'type: image' for every content block, so PDFs routed through claude-cli were rejected by the Anthropic API with a MIME mismatch. - providers/claude_cli_session.go: buildStreamJSONInput now picks the Anthropic block type from MIME — application/pdf -> document, image/* -> image. - tools/read_image.go, read_document.go: add claude-cli to the fallback priority and model defaults (empty string lets the provider pick its own default model). - tools/read_image.go, read_document_resolve.go: scope disable_tools to claude-cli only instead of leaking a CLI-specific flag into the shared Options map every provider in the chain receives. - providers/claude_cli_session_test.go: table test covering png/pdf/ mixed/unknown MIME routing plus the empty-text edge case. Closes #801.
126 lines
3.5 KiB
Go
126 lines
3.5 KiB
Go
package providers
|
|
|
|
import (
|
|
"encoding/json"
|
|
"io"
|
|
"testing"
|
|
)
|
|
|
|
// TestBuildStreamJSONInput_MimeRouting verifies that buildStreamJSONInput
|
|
// picks the correct Anthropic content block type based on MIME:
|
|
// - application/pdf → "document"
|
|
// - image/* → "image"
|
|
//
|
|
// Regression guard: earlier versions hardcoded "image" for every block,
|
|
// causing PDF passthrough to fail because the Anthropic API rejects
|
|
// image blocks with non-image MIME types.
|
|
func TestBuildStreamJSONInput_MimeRouting(t *testing.T) {
|
|
cases := []struct {
|
|
name string
|
|
images []ImageContent
|
|
wantTypes []string
|
|
}{
|
|
{
|
|
name: "png image → image block",
|
|
images: []ImageContent{
|
|
{MimeType: "image/png", Data: "abc"},
|
|
},
|
|
wantTypes: []string{"image"},
|
|
},
|
|
{
|
|
name: "pdf → document block",
|
|
images: []ImageContent{
|
|
{MimeType: "application/pdf", Data: "abc"},
|
|
},
|
|
wantTypes: []string{"document"},
|
|
},
|
|
{
|
|
name: "mixed png + pdf → image then document",
|
|
images: []ImageContent{
|
|
{MimeType: "image/jpeg", Data: "xxx"},
|
|
{MimeType: "application/pdf", Data: "yyy"},
|
|
},
|
|
wantTypes: []string{"image", "document"},
|
|
},
|
|
{
|
|
name: "unknown MIME falls back to image",
|
|
images: []ImageContent{
|
|
{MimeType: "application/octet-stream", Data: "zzz"},
|
|
},
|
|
wantTypes: []string{"image"},
|
|
},
|
|
}
|
|
|
|
for _, tc := range cases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
r := buildStreamJSONInput("describe", tc.images)
|
|
raw, err := io.ReadAll(r)
|
|
if err != nil {
|
|
t.Fatalf("read stdin: %v", err)
|
|
}
|
|
|
|
var msg struct {
|
|
Message struct {
|
|
Content []map[string]any `json:"content"`
|
|
} `json:"message"`
|
|
}
|
|
if err := json.Unmarshal(raw, &msg); err != nil {
|
|
t.Fatalf("parse stream-json: %v\nraw: %s", err, raw)
|
|
}
|
|
|
|
// Expect N media blocks + 1 trailing text block.
|
|
wantLen := len(tc.wantTypes) + 1
|
|
if got := len(msg.Message.Content); got != wantLen {
|
|
t.Fatalf("content blocks = %d, want %d\nraw: %s", got, wantLen, raw)
|
|
}
|
|
|
|
for i, wantType := range tc.wantTypes {
|
|
gotType, _ := msg.Message.Content[i]["type"].(string)
|
|
if gotType != wantType {
|
|
t.Errorf("block[%d].type = %q, want %q", i, gotType, wantType)
|
|
}
|
|
source, _ := msg.Message.Content[i]["source"].(map[string]any)
|
|
if source == nil {
|
|
t.Errorf("block[%d].source is nil", i)
|
|
continue
|
|
}
|
|
if gotMime, _ := source["media_type"].(string); gotMime != tc.images[i].MimeType {
|
|
t.Errorf("block[%d].source.media_type = %q, want %q", i, gotMime, tc.images[i].MimeType)
|
|
}
|
|
}
|
|
|
|
// Trailing text block.
|
|
last := msg.Message.Content[wantLen-1]
|
|
if last["type"] != "text" {
|
|
t.Errorf("trailing block type = %v, want text", last["type"])
|
|
}
|
|
if last["text"] != "describe" {
|
|
t.Errorf("trailing block text = %v, want describe", last["text"])
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
// TestBuildStreamJSONInput_NoText covers the edge case where the caller
|
|
// passes images with an empty prompt — no text block should be emitted.
|
|
func TestBuildStreamJSONInput_NoText(t *testing.T) {
|
|
r := buildStreamJSONInput("", []ImageContent{
|
|
{MimeType: "image/png", Data: "abc"},
|
|
})
|
|
raw, err := io.ReadAll(r)
|
|
if err != nil {
|
|
t.Fatalf("read stdin: %v", err)
|
|
}
|
|
var msg struct {
|
|
Message struct {
|
|
Content []map[string]any `json:"content"`
|
|
} `json:"message"`
|
|
}
|
|
if err := json.Unmarshal(raw, &msg); err != nil {
|
|
t.Fatalf("parse stream-json: %v", err)
|
|
}
|
|
if len(msg.Message.Content) != 1 {
|
|
t.Errorf("content blocks = %d, want 1 (image only)", len(msg.Message.Content))
|
|
}
|
|
}
|