Files
goclaw/internal/http/api_keys.go
T
Goon 75c570e951 feat(security): credentialed exec + HTTP RBAC + API key cache (#197)
- Secure CLI credential injection via AES-256-GCM encrypted env vars
- API key management with fine-grained RBAC scopes
- resolveAuth/requireAuth middleware across all 25+ HTTP handlers
- In-memory API key cache with TTL, negative caching, pubsub invalidation
- Sandbox-first execution (fails if unavailable, no silent fallback)
- Credential scrubbing, constant-time token comparison, Admin-only CLI creds
- SQL migration 000020: secure_cli_binaries + api_keys tables
- 14 unit tests for cache and RBAC with race detector

Closes #197
2026-03-15 20:13:18 +07:00

163 lines
5.2 KiB
Go

package http
import (
"encoding/json"
"log/slog"
"net/http"
"time"
"github.com/google/uuid"
"github.com/nextlevelbuilder/goclaw/internal/bus"
"github.com/nextlevelbuilder/goclaw/internal/crypto"
"github.com/nextlevelbuilder/goclaw/internal/i18n"
"github.com/nextlevelbuilder/goclaw/internal/permissions"
"github.com/nextlevelbuilder/goclaw/internal/store"
"github.com/nextlevelbuilder/goclaw/pkg/protocol"
)
// APIKeysHandler handles API key management endpoints.
type APIKeysHandler struct {
apiKeys store.APIKeyStore
token string // gateway token for admin auth
msgBus *bus.MessageBus // for cache invalidation events
}
// NewAPIKeysHandler creates a handler for API key management endpoints.
func NewAPIKeysHandler(apiKeys store.APIKeyStore, token string, msgBus *bus.MessageBus) *APIKeysHandler {
return &APIKeysHandler{apiKeys: apiKeys, token: token, msgBus: msgBus}
}
// RegisterRoutes registers all API key management routes on the given mux.
func (h *APIKeysHandler) RegisterRoutes(mux *http.ServeMux) {
mux.HandleFunc("GET /v1/api-keys", h.adminAuth(h.handleList))
mux.HandleFunc("POST /v1/api-keys", h.adminAuth(h.handleCreate))
mux.HandleFunc("POST /v1/api-keys/{id}/revoke", h.adminAuth(h.handleRevoke))
}
// adminAuth ensures the caller has admin access (gateway token or API key with admin scope).
func (h *APIKeysHandler) adminAuth(next http.HandlerFunc) http.HandlerFunc {
return requireAuth(h.token, permissions.RoleAdmin, next)
}
func (h *APIKeysHandler) handleList(w http.ResponseWriter, r *http.Request) {
locale := extractLocale(r)
keys, err := h.apiKeys.List(r.Context())
if err != nil {
slog.Error("api_keys.list failed", "error", err)
writeJSON(w, http.StatusInternalServerError, map[string]string{"error": i18n.T(locale, i18n.MsgFailedToList, "API keys")})
return
}
if keys == nil {
keys = []store.APIKeyData{}
}
writeJSON(w, http.StatusOK, keys)
}
func (h *APIKeysHandler) handleCreate(w http.ResponseWriter, r *http.Request) {
locale := extractLocale(r)
var input struct {
Name string `json:"name"`
Scopes []string `json:"scopes"`
ExpiresIn *int `json:"expires_in"` // seconds; nil = never
}
if err := json.NewDecoder(r.Body).Decode(&input); err != nil {
writeJSON(w, http.StatusBadRequest, map[string]string{"error": i18n.T(locale, i18n.MsgInvalidJSON)})
return
}
if input.Name == "" {
writeJSON(w, http.StatusBadRequest, map[string]string{"error": i18n.T(locale, i18n.MsgRequired, "name")})
return
}
if len(input.Name) > 100 {
writeJSON(w, http.StatusBadRequest, map[string]string{"error": i18n.T(locale, i18n.MsgInvalidRequest, "name must be 100 characters or less")})
return
}
if len(input.Scopes) == 0 {
writeJSON(w, http.StatusBadRequest, map[string]string{"error": i18n.T(locale, i18n.MsgRequired, "scopes")})
return
}
// Validate scopes
for _, s := range input.Scopes {
if !permissions.ValidScope(s) {
writeJSON(w, http.StatusBadRequest, map[string]string{"error": i18n.T(locale, i18n.MsgInvalidRequest, "invalid scope: "+s)})
return
}
}
raw, hash, prefix, err := crypto.GenerateAPIKey()
if err != nil {
slog.Error("api_keys.generate failed", "error", err)
writeJSON(w, http.StatusInternalServerError, map[string]string{"error": i18n.T(locale, i18n.MsgInternalError, "key generation")})
return
}
now := time.Now()
key := &store.APIKeyData{
ID: store.GenNewID(),
Name: input.Name,
Prefix: prefix,
KeyHash: hash,
Scopes: input.Scopes,
CreatedBy: extractUserID(r),
CreatedAt: now,
UpdatedAt: now,
}
if input.ExpiresIn != nil && *input.ExpiresIn > 0 {
exp := now.Add(time.Duration(*input.ExpiresIn) * time.Second)
key.ExpiresAt = &exp
}
if err := h.apiKeys.Create(r.Context(), key); err != nil {
slog.Error("api_keys.create failed", "error", err)
writeJSON(w, http.StatusInternalServerError, map[string]string{"error": i18n.T(locale, i18n.MsgFailedToCreate, "API key", "internal error")})
return
}
h.emitCacheInvalidate("api_keys", key.ID.String())
// Return key with raw secret (shown only once)
writeJSON(w, http.StatusCreated, map[string]any{
"id": key.ID,
"name": key.Name,
"prefix": key.Prefix,
"key": raw, // shown only once!
"scopes": key.Scopes,
"expires_at": key.ExpiresAt,
"created_at": key.CreatedAt,
})
}
func (h *APIKeysHandler) handleRevoke(w http.ResponseWriter, r *http.Request) {
locale := extractLocale(r)
idStr := r.PathValue("id")
id, err := uuid.Parse(idStr)
if err != nil {
writeJSON(w, http.StatusBadRequest, map[string]string{"error": i18n.T(locale, i18n.MsgInvalidID, "API key")})
return
}
if err := h.apiKeys.Revoke(r.Context(), id); err != nil {
slog.Error("api_keys.revoke failed", "error", err, "id", idStr)
writeJSON(w, http.StatusNotFound, map[string]string{"error": i18n.T(locale, i18n.MsgNotFound, "API key", idStr)})
return
}
h.emitCacheInvalidate("api_keys", idStr)
writeJSON(w, http.StatusOK, map[string]string{"status": "revoked"})
}
func (h *APIKeysHandler) emitCacheInvalidate(kind, key string) {
if h.msgBus == nil {
return
}
h.msgBus.Broadcast(bus.Event{
Name: protocol.EventCacheInvalidate,
Payload: bus.CacheInvalidatePayload{Kind: kind, Key: key},
})
}