mirror of
https://github.com/tiennm99/goclaw.git
synced 2026-06-11 12:10:58 +00:00
Viet Tran
ace07509b7
* feat(infra): add runtime package support for skills Install nodejs, npm, pandoc, github-cli + pre-install Python packages (openpyxl, pandas, python-pptx, markitdown) and Node packages (docx, pptxgenjs). Configure runtime dirs for agent pip/npm installs with PIP_TARGET, NPM_CONFIG_PREFIX, NODE_PATH to enable dynamic package installation in read-only container environment. * feat(infra): add bundled skills with runtime package support - Add 5 bundled skills: docx, pdf, pptx, xlsx, skill-creator from container skills-store - Wire GOCLAW_BUILTIN_SKILLS_DIR env var in gateway and CLI - Support optional runtime packages alongside dynamic skill loading - Update Dockerfile to COPY bundled-skills at /app/bundled-skills/ - Add PIP_CACHE_DIR in docker-entrypoint.sh for clean pip installs - Document bundled skills in 14-skills-runtime.md section 6 * feat(infra): remove ai-multimodal skill directory from bundled skills Remove the ai-multimodal skill package as part of consolidating runtime package support for bundled skills. This directory is no longer needed in the bundled skills structure. * feat(ci): add semantic release and Docker Hub publishing Add go-semantic-release workflow to auto-create semver tags on merge to main. Extend docker-publish to push all variants to both GHCR and Docker Hub (digitop/goclaw). * feat(skills): add system skills infrastructure with is_system column, dep scanning, and seeder - Migration 000017: add is_system boolean column with partial index - Store layer: UpsertSystemSkill, delete protection, IsSystemSkill - ListAccessible auto-includes system skills (no grants needed) - ListWithGrantStatus returns is_system field - Dependency scanner: auto-detect deps from scripts/ or skill-manifest.json - Dependency checker: verify system binaries, Python/Node packages - Seeder: seed bundled skills into DB on startup (idempotent via hash) - Gateway wiring: GOCLAW_BUNDLED_SKILLS_DIR env for bundled skills - HTTP: delete guard (403), slug conflict check (409), rescan-deps endpoint - UI: System badge, hide delete for system skills, rescan deps button - Agent skills tab: "Always available" for system skills - i18n: en/vi/zh keys for system skills, deps scanning * feat(skills): conditional system prompt, skill manifests, and Zip Slip fix - System prompt: only show package list when python3/node are available - Add skill-manifest.json for pdf, docx, xlsx, pptx bundled skills - Fix Zip Slip vulnerability in office/unpack.py (all 3 copies) * refactor(skills): extract shared office code to _shared/ and deduplicate Move office scripts (pack, unpack, validate, schemas, validators) from duplicated copies in docx/xlsx/pptx to skills/_shared/office/ with symlinks. Remove soffice.py (non-functional in containers) and update SKILL.md references to use soffice binary directly. Update seeder copyDir to follow symlinks. Removes ~45K lines of duplicate code across 3 skills. * fix(skills): address code review findings for system skills integration - H1: Remove dead symlink branch in copyDir (filepath.Walk follows symlinks) - H3: Fix rescan-deps to query ALL skills (including archived) and re-activate when deps become available; add ListAllSkills() + Status field to SkillInfo - H4: Add Status field to SkillCreateParams, stop overloading Visibility - M1: Batch Python/Node dep checks into single subprocess per runtime - M4: Add rows.Err() check in ListSkills to prevent caching partial results * feat(skills): async dep checking with realtime WS events Split Seed() into sync DB upsert + async CheckDepsAsync() goroutine. Gateway startup no longer blocks on Python/Node subprocess dep checks. - Seed() returns seeded skills list, all initially status="active" - CheckDepsAsync() runs in background, emits skill.deps.checked per-skill - skill.deps.complete event emitted when all checks finish - Each failed dep check: archives skill + BumpVersion() for immediate cache invalidation so next agent turn picks up the change - UI: use-query-invalidation listens to skill.deps.* events → auto-refresh skills list in realtime * feat(skills): system skills integration with toggle, dep checking, and per-item install - Add is_system, deps, enabled columns to skills table (migration 017) - Seed bundled core skills (pdf, docx, pptx, xlsx, skill-creator) on startup - PYTHONPATH-based dep detection — eliminates false positives from local modules - Per-item dep install UI with individual status (installing/success/error) - Enable/disable toggle for core and custom skills (independent of dep status) - Re-run dep check when skill is toggled back on - Inline skill thresholds: 40 skills / 5000 tokens before switching to search mode - Fix UpsertSystemSkill: backfill null file_hash without bumping DB version - Remove redundant skill-manifest.json files (replaced by deps JSONB column) - Show author from frontmatter in custom skills tab - Runtime checker for python3/pip3/node/npm availability - WS events for dep checking/installing progress - docs: add 15-core-skills-system.md, 16-skill-publishing.md --------- Co-authored-by: Goon <duy@wearetopgroup.com>
64 lines
2.1 KiB
Go
64 lines
2.1 KiB
Go
package store
|
|
|
|
import (
|
|
"context"
|
|
|
|
"github.com/google/uuid"
|
|
)
|
|
|
|
// SkillInfo describes a discovered skill.
|
|
type SkillInfo struct {
|
|
ID string `json:"id,omitempty"` // DB UUID
|
|
Name string `json:"name"`
|
|
Slug string `json:"slug"`
|
|
Path string `json:"path"`
|
|
BaseDir string `json:"baseDir"`
|
|
Source string `json:"source"`
|
|
Description string `json:"description"`
|
|
Visibility string `json:"visibility,omitempty"`
|
|
Tags []string `json:"tags,omitempty"`
|
|
Version int `json:"version,omitempty"`
|
|
IsSystem bool `json:"is_system,omitempty"`
|
|
Status string `json:"status,omitempty"`
|
|
Enabled bool `json:"enabled"`
|
|
Author string `json:"author,omitempty"`
|
|
MissingDeps []string `json:"missing_deps,omitempty"`
|
|
}
|
|
|
|
// SkillSearchResult is a scored skill returned from embedding search.
|
|
type SkillSearchResult struct {
|
|
Name string `json:"name"`
|
|
Slug string `json:"slug"`
|
|
Description string `json:"description"`
|
|
Path string `json:"path"`
|
|
Score float64 `json:"score"`
|
|
}
|
|
|
|
// SkillStore manages skill discovery and loading.
|
|
// Backed by Postgres (PGSkillStore) or filesystem (FileSkillStore).
|
|
type SkillStore interface {
|
|
ListSkills() []SkillInfo
|
|
LoadSkill(name string) (string, bool)
|
|
LoadForContext(allowList []string) string
|
|
BuildSummary(allowList []string) string
|
|
GetSkill(name string) (*SkillInfo, bool)
|
|
FilterSkills(allowList []string) []SkillInfo
|
|
Version() int64
|
|
BumpVersion()
|
|
Dirs() []string
|
|
}
|
|
|
|
// SkillAccessStore is an optional interface for stores that support
|
|
// per-agent skill access filtering.
|
|
type SkillAccessStore interface {
|
|
ListAccessible(ctx context.Context, agentID uuid.UUID, userID string) ([]SkillInfo, error)
|
|
}
|
|
|
|
// EmbeddingSkillSearcher is an optional interface for stores that support
|
|
// vector-based skill search. PGSkillStore implements this; FileSkillStore does not.
|
|
type EmbeddingSkillSearcher interface {
|
|
SearchByEmbedding(ctx context.Context, embedding []float32, limit int) ([]SkillSearchResult, error)
|
|
SetEmbeddingProvider(provider EmbeddingProvider)
|
|
BackfillSkillEmbeddings(ctx context.Context) (int, error)
|
|
}
|