mirror of
https://github.com/tiennm99/goclaw.git
synced 2026-07-31 18:20:25 +00:00
Wire AgentToolPolicy from agent spec through loop creation and resolver, passing it to PolicyEngine.FilterTools for per-agent tool restrictions (nil = no restrictions). Set RestrictToWorkspace=true for default agent in managed mode seeding. Clean up thinking/placeholder messages in Discord and Telegram when agent suppresses empty/NO_REPLY responses by publishing empty outbound and deleting placeholders without sending messages.
656 lines
21 KiB
Go
656 lines
21 KiB
Go
package agent
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
"log/slog"
|
|
"sort"
|
|
"strings"
|
|
"sync"
|
|
"sync/atomic"
|
|
"time"
|
|
|
|
"github.com/google/uuid"
|
|
|
|
"github.com/nextlevelbuilder/goclaw/internal/bootstrap"
|
|
"github.com/nextlevelbuilder/goclaw/internal/bus"
|
|
"github.com/nextlevelbuilder/goclaw/internal/config"
|
|
"github.com/nextlevelbuilder/goclaw/internal/providers"
|
|
"github.com/nextlevelbuilder/goclaw/internal/skills"
|
|
"github.com/nextlevelbuilder/goclaw/internal/store"
|
|
"github.com/nextlevelbuilder/goclaw/internal/tools"
|
|
"github.com/nextlevelbuilder/goclaw/internal/tracing"
|
|
)
|
|
|
|
// EnsureUserFilesFunc seeds per-user context files on first chat (managed mode).
|
|
type EnsureUserFilesFunc func(ctx context.Context, agentID uuid.UUID, userID, agentType, workspace string) error
|
|
|
|
// ContextFileLoaderFunc loads context files dynamically per-request (managed mode).
|
|
type ContextFileLoaderFunc func(ctx context.Context, agentID uuid.UUID, userID, agentType string) []bootstrap.ContextFile
|
|
|
|
// Loop is the agent execution loop for one agent instance.
|
|
// Think → Act → Observe cycle with tool execution.
|
|
type Loop struct {
|
|
id string
|
|
agentUUID uuid.UUID // set in managed mode for context propagation
|
|
agentType string // "open" or "predefined" (managed mode)
|
|
provider providers.Provider
|
|
model string
|
|
contextWindow int
|
|
maxIterations int
|
|
workspace string
|
|
|
|
eventPub bus.EventPublisher // currently unused by Loop; kept for future use
|
|
sessions store.SessionStore
|
|
tools *tools.Registry
|
|
toolPolicy *tools.PolicyEngine // optional: filters tools sent to LLM
|
|
agentToolPolicy *config.ToolPolicySpec // per-agent tool policy from DB (nil = no restrictions)
|
|
running atomic.Bool
|
|
mu sync.Mutex // protects concurrent runs
|
|
|
|
// Bootstrap/persona context (loaded at startup, injected into system prompt)
|
|
ownerIDs []string
|
|
skillsLoader *skills.Loader
|
|
skillAllowList []string // nil = all, [] = none, ["x","y"] = filter
|
|
hasMemory bool
|
|
contextFiles []bootstrap.ContextFile
|
|
|
|
// Per-user file seeding + dynamic context loading (managed mode)
|
|
ensureUserFiles EnsureUserFilesFunc
|
|
contextFileLoader ContextFileLoaderFunc
|
|
seededUsers sync.Map // userID → true, avoid re-check per request
|
|
|
|
// Compaction config (memory flush settings)
|
|
compactionCfg *config.CompactionConfig
|
|
|
|
// Context pruning config (trim old tool results in-memory)
|
|
contextPruningCfg *config.ContextPruningConfig
|
|
|
|
// Sandbox info
|
|
sandboxEnabled bool
|
|
sandboxContainerDir string
|
|
sandboxWorkspaceAccess string
|
|
|
|
// Event callback for broadcasting agent events (run.started, chunk, tool.call, etc.)
|
|
onEvent func(event AgentEvent)
|
|
|
|
// Tracing collector (nil in standalone mode)
|
|
traceCollector *tracing.Collector
|
|
|
|
// Security: input scanning and message size limit
|
|
inputGuard *InputGuard
|
|
injectionAction string // "log", "warn" (default), "block", "off"
|
|
maxMessageChars int // 0 = use default (32000)
|
|
}
|
|
|
|
// AgentEvent is emitted during agent execution for WS broadcasting.
|
|
type AgentEvent struct {
|
|
Type string `json:"type"` // "run.started", "run.completed", "run.failed", "chunk", "tool.call", "tool.result"
|
|
AgentID string `json:"agentId"`
|
|
RunID string `json:"runId"`
|
|
Payload interface{} `json:"payload,omitempty"`
|
|
}
|
|
|
|
// LoopConfig configures a new Loop.
|
|
type LoopConfig struct {
|
|
ID string
|
|
Provider providers.Provider
|
|
Model string
|
|
ContextWindow int
|
|
MaxIterations int
|
|
Workspace string
|
|
Bus bus.EventPublisher
|
|
Sessions store.SessionStore
|
|
Tools *tools.Registry
|
|
ToolPolicy *tools.PolicyEngine // optional: filters tools sent to LLM
|
|
AgentToolPolicy *config.ToolPolicySpec // per-agent tool policy from DB (nil = no restrictions)
|
|
OnEvent func(AgentEvent)
|
|
|
|
// Bootstrap/persona context
|
|
OwnerIDs []string
|
|
SkillsLoader *skills.Loader
|
|
SkillAllowList []string // nil = all, [] = none, ["x","y"] = filter
|
|
HasMemory bool
|
|
ContextFiles []bootstrap.ContextFile
|
|
|
|
// Compaction config
|
|
CompactionCfg *config.CompactionConfig
|
|
|
|
// Context pruning (trim old tool results to save context window)
|
|
ContextPruningCfg *config.ContextPruningConfig
|
|
|
|
// Sandbox info (injected into system prompt)
|
|
SandboxEnabled bool
|
|
SandboxContainerDir string // e.g. "/workspace"
|
|
SandboxWorkspaceAccess string // "none", "ro", "rw"
|
|
|
|
// Managed mode: agent UUID for context propagation to tools
|
|
AgentUUID uuid.UUID
|
|
AgentType string // "open" or "predefined" (managed mode)
|
|
|
|
// Per-user file seeding + dynamic context loading (managed mode)
|
|
EnsureUserFiles EnsureUserFilesFunc
|
|
ContextFileLoader ContextFileLoaderFunc
|
|
|
|
// Tracing collector (nil = no tracing)
|
|
TraceCollector *tracing.Collector
|
|
|
|
// Security: input guard for injection detection, max message size
|
|
InputGuard *InputGuard // nil = auto-create when InjectionAction != "off"
|
|
InjectionAction string // "log", "warn" (default), "block", "off"
|
|
MaxMessageChars int // 0 = use default (32000)
|
|
}
|
|
|
|
func NewLoop(cfg LoopConfig) *Loop {
|
|
if cfg.MaxIterations <= 0 {
|
|
cfg.MaxIterations = 20
|
|
}
|
|
if cfg.ContextWindow <= 0 {
|
|
cfg.ContextWindow = 200000
|
|
}
|
|
|
|
// Normalize injection action (default: "warn")
|
|
action := cfg.InjectionAction
|
|
switch action {
|
|
case "log", "warn", "block", "off":
|
|
// valid
|
|
default:
|
|
action = "warn"
|
|
}
|
|
|
|
// Auto-create InputGuard unless explicitly disabled
|
|
guard := cfg.InputGuard
|
|
if guard == nil && action != "off" {
|
|
guard = NewInputGuard()
|
|
}
|
|
|
|
return &Loop{
|
|
id: cfg.ID,
|
|
agentUUID: cfg.AgentUUID,
|
|
agentType: cfg.AgentType,
|
|
provider: cfg.Provider,
|
|
model: cfg.Model,
|
|
contextWindow: cfg.ContextWindow,
|
|
maxIterations: cfg.MaxIterations,
|
|
workspace: cfg.Workspace,
|
|
eventPub: cfg.Bus,
|
|
sessions: cfg.Sessions,
|
|
tools: cfg.Tools,
|
|
toolPolicy: cfg.ToolPolicy,
|
|
agentToolPolicy: cfg.AgentToolPolicy,
|
|
onEvent: cfg.OnEvent,
|
|
ownerIDs: cfg.OwnerIDs,
|
|
skillsLoader: cfg.SkillsLoader,
|
|
skillAllowList: cfg.SkillAllowList,
|
|
hasMemory: cfg.HasMemory,
|
|
contextFiles: cfg.ContextFiles,
|
|
ensureUserFiles: cfg.EnsureUserFiles,
|
|
contextFileLoader: cfg.ContextFileLoader,
|
|
compactionCfg: cfg.CompactionCfg,
|
|
contextPruningCfg: cfg.ContextPruningCfg,
|
|
sandboxEnabled: cfg.SandboxEnabled,
|
|
sandboxContainerDir: cfg.SandboxContainerDir,
|
|
sandboxWorkspaceAccess: cfg.SandboxWorkspaceAccess,
|
|
traceCollector: cfg.TraceCollector,
|
|
inputGuard: guard,
|
|
injectionAction: action,
|
|
maxMessageChars: cfg.MaxMessageChars,
|
|
}
|
|
}
|
|
|
|
// RunRequest is the input for processing a message through the agent.
|
|
type RunRequest struct {
|
|
SessionKey string // composite key: agent:{agentId}:{channel}:{peerKind}:{chatId}
|
|
Message string // user message
|
|
Channel string // source channel
|
|
ChatID string // source chat ID
|
|
PeerKind string // "direct" or "group" (for session key building and tool context)
|
|
RunID string // unique run identifier
|
|
UserID string // external user ID (TEXT, free-form) for multi-tenant scoping
|
|
SenderID string // original individual sender ID (preserved in group chats for permission checks)
|
|
Stream bool // whether to stream response chunks
|
|
ExtraSystemPrompt string // optional: injected into system prompt (skills, subagent context, etc.)
|
|
HistoryLimit int // max user turns to keep in context (0=unlimited, from channel config)
|
|
ParentTraceID uuid.UUID // if set, reuse parent trace instead of creating new (announce runs)
|
|
ParentRootSpanID uuid.UUID // if set, nest announce agent span under this parent span
|
|
}
|
|
|
|
// RunResult is the output of a completed agent run.
|
|
type RunResult struct {
|
|
Content string `json:"content"`
|
|
RunID string `json:"runId"`
|
|
Iterations int `json:"iterations"`
|
|
Usage *providers.Usage `json:"usage,omitempty"`
|
|
}
|
|
|
|
// Run processes a single message through the agent loop.
|
|
// It blocks until completion and returns the final response.
|
|
func (l *Loop) Run(ctx context.Context, req RunRequest) (*RunResult, error) {
|
|
l.mu.Lock()
|
|
defer l.mu.Unlock()
|
|
|
|
l.emit(AgentEvent{Type: "run.started", AgentID: l.id, RunID: req.RunID})
|
|
|
|
// Create trace (managed mode only)
|
|
var traceID uuid.UUID
|
|
isChildTrace := req.ParentTraceID != uuid.Nil && l.traceCollector != nil
|
|
|
|
if isChildTrace {
|
|
// Announce run: reuse parent trace, don't create new trace record.
|
|
// Spans will be added to the parent trace with proper nesting.
|
|
traceID = req.ParentTraceID
|
|
ctx = tracing.WithTraceID(ctx, traceID)
|
|
ctx = tracing.WithCollector(ctx, l.traceCollector)
|
|
ctx = tracing.WithParentSpanID(ctx, store.GenNewID())
|
|
if req.ParentRootSpanID != uuid.Nil {
|
|
ctx = tracing.WithAnnounceParentSpanID(ctx, req.ParentRootSpanID)
|
|
}
|
|
} else if l.traceCollector != nil {
|
|
traceID = store.GenNewID()
|
|
now := time.Now().UTC()
|
|
trace := &store.TraceData{
|
|
ID: traceID,
|
|
RunID: req.RunID,
|
|
SessionKey: req.SessionKey,
|
|
UserID: req.UserID,
|
|
Channel: req.Channel,
|
|
Name: "chat " + l.id,
|
|
InputPreview: truncateStr(req.Message, 500),
|
|
Status: "running",
|
|
StartTime: now,
|
|
CreatedAt: now,
|
|
}
|
|
if l.agentUUID != uuid.Nil {
|
|
trace.AgentID = &l.agentUUID
|
|
}
|
|
if err := l.traceCollector.CreateTrace(ctx, trace); err != nil {
|
|
slog.Warn("tracing: failed to create trace", "error", err)
|
|
} else {
|
|
ctx = tracing.WithTraceID(ctx, traceID)
|
|
ctx = tracing.WithCollector(ctx, l.traceCollector)
|
|
|
|
// Pre-generate root "agent" span ID so LLM/tool spans can reference it as parent.
|
|
// The span itself is emitted after runLoop completes (with full timing data).
|
|
ctx = tracing.WithParentSpanID(ctx, store.GenNewID())
|
|
}
|
|
}
|
|
|
|
runStart := time.Now().UTC()
|
|
result, err := l.runLoop(ctx, req)
|
|
|
|
// Emit root "agent" span with full timing (parent for all LLM/tool spans).
|
|
if l.traceCollector != nil && traceID != uuid.Nil {
|
|
l.emitAgentSpan(ctx, runStart, result, err)
|
|
}
|
|
|
|
if err != nil {
|
|
l.emit(AgentEvent{
|
|
Type: "run.failed",
|
|
AgentID: l.id,
|
|
RunID: req.RunID,
|
|
Payload: map[string]string{"error": err.Error()},
|
|
})
|
|
// Only finish trace for root runs; child traces don't own the trace lifecycle.
|
|
if !isChildTrace && l.traceCollector != nil && traceID != uuid.Nil {
|
|
l.traceCollector.FinishTrace(ctx, traceID, "error", err.Error(), "")
|
|
}
|
|
return nil, err
|
|
}
|
|
|
|
l.emit(AgentEvent{Type: "run.completed", AgentID: l.id, RunID: req.RunID})
|
|
if !isChildTrace && l.traceCollector != nil && traceID != uuid.Nil {
|
|
l.traceCollector.FinishTrace(ctx, traceID, "completed", "", truncateStr(result.Content, 500))
|
|
}
|
|
return result, nil
|
|
}
|
|
|
|
func (l *Loop) runLoop(ctx context.Context, req RunRequest) (*RunResult, error) {
|
|
// Inject agent UUID into context for tool routing (managed mode)
|
|
if l.agentUUID != uuid.Nil {
|
|
ctx = store.WithAgentID(ctx, l.agentUUID)
|
|
}
|
|
// Inject user ID into context for per-user scoping (memory, context files, etc.)
|
|
if req.UserID != "" {
|
|
ctx = store.WithUserID(ctx, req.UserID)
|
|
}
|
|
// Inject agent type into context for interceptor routing (managed mode)
|
|
if l.agentType != "" {
|
|
ctx = store.WithAgentType(ctx, l.agentType)
|
|
}
|
|
// Inject original sender ID for group file writer permission checks
|
|
if req.SenderID != "" {
|
|
ctx = store.WithSenderID(ctx, req.SenderID)
|
|
}
|
|
|
|
// Ensure per-user context files exist (first-chat seeding, managed mode)
|
|
if l.ensureUserFiles != nil && req.UserID != "" {
|
|
if _, loaded := l.seededUsers.LoadOrStore(req.UserID, true); !loaded {
|
|
if err := l.ensureUserFiles(ctx, l.agentUUID, req.UserID, l.agentType, l.workspace); err != nil {
|
|
slog.Warn("failed to ensure user context files", "error", err)
|
|
}
|
|
}
|
|
}
|
|
|
|
// Persist agent UUID + user ID on the session (for querying/tracing)
|
|
if l.agentUUID != uuid.Nil || req.UserID != "" {
|
|
l.sessions.SetAgentInfo(req.SessionKey, l.agentUUID, req.UserID)
|
|
}
|
|
|
|
// Security: scan user message for injection patterns.
|
|
// Action is configurable: "log" (info), "warn" (default), "block" (reject message).
|
|
if l.inputGuard != nil {
|
|
if matches := l.inputGuard.Scan(req.Message); len(matches) > 0 {
|
|
matchStr := strings.Join(matches, ",")
|
|
switch l.injectionAction {
|
|
case "block":
|
|
slog.Warn("security.injection_blocked",
|
|
"agent", l.id, "user", req.UserID,
|
|
"patterns", matchStr, "message_len", len(req.Message),
|
|
)
|
|
return nil, fmt.Errorf("message blocked: potential prompt injection detected (%s)", matchStr)
|
|
case "log":
|
|
slog.Info("security.injection_detected",
|
|
"agent", l.id, "user", req.UserID,
|
|
"patterns", matchStr, "message_len", len(req.Message),
|
|
)
|
|
default: // "warn"
|
|
slog.Warn("security.injection_detected",
|
|
"agent", l.id, "user", req.UserID,
|
|
"patterns", matchStr, "message_len", len(req.Message),
|
|
)
|
|
}
|
|
}
|
|
}
|
|
|
|
// Security: truncate oversized user messages gracefully (feed truncation notice into LLM)
|
|
maxChars := l.maxMessageChars
|
|
if maxChars <= 0 {
|
|
maxChars = 32_000 // default ~8-10K tokens
|
|
}
|
|
if len(req.Message) > maxChars {
|
|
originalLen := len(req.Message)
|
|
req.Message = req.Message[:maxChars] +
|
|
fmt.Sprintf("\n\n[System: Message was truncated from %d to %d characters due to size limit. "+
|
|
"Please ask the user to send shorter messages or use the read_file tool for large content.]",
|
|
originalLen, maxChars)
|
|
slog.Warn("security.message_truncated",
|
|
"agent", l.id, "user", req.UserID,
|
|
"original_len", originalLen, "truncated_to", maxChars,
|
|
)
|
|
}
|
|
|
|
// 1. Build messages from session history
|
|
history := l.sessions.GetHistory(req.SessionKey)
|
|
summary := l.sessions.GetSummary(req.SessionKey)
|
|
|
|
messages := l.buildMessages(ctx, history, summary, req.Message, req.ExtraSystemPrompt, req.SessionKey, req.Channel, req.UserID, req.HistoryLimit)
|
|
|
|
// 2. Save user message to session
|
|
l.sessions.AddMessage(req.SessionKey, providers.Message{
|
|
Role: "user",
|
|
Content: req.Message,
|
|
})
|
|
|
|
// 3. Run LLM iteration loop
|
|
var totalUsage providers.Usage
|
|
iteration := 0
|
|
var finalContent string
|
|
var asyncToolCalls []string // track async spawn tool names for fallback
|
|
|
|
for iteration < l.maxIterations {
|
|
iteration++
|
|
|
|
slog.Debug("agent iteration", "agent", l.id, "iteration", iteration, "messages", len(messages))
|
|
|
|
// Build provider request with policy-filtered tools
|
|
var toolDefs []providers.ToolDefinition
|
|
if l.toolPolicy != nil {
|
|
toolDefs = l.toolPolicy.FilterTools(l.tools, l.id, l.provider.Name(), l.agentToolPolicy, nil, false, false)
|
|
} else {
|
|
toolDefs = l.tools.ProviderDefs()
|
|
}
|
|
|
|
chatReq := providers.ChatRequest{
|
|
Messages: messages,
|
|
Tools: toolDefs,
|
|
Model: l.model,
|
|
Options: map[string]interface{}{
|
|
"max_tokens": 8192,
|
|
"temperature": 0.7,
|
|
},
|
|
}
|
|
|
|
// Call LLM (streaming or non-streaming)
|
|
var resp *providers.ChatResponse
|
|
var err error
|
|
|
|
llmSpanStart := time.Now().UTC()
|
|
|
|
if req.Stream {
|
|
resp, err = l.provider.ChatStream(ctx, chatReq, func(chunk providers.StreamChunk) {
|
|
if chunk.Content != "" {
|
|
l.emit(AgentEvent{
|
|
Type: "chunk",
|
|
AgentID: l.id,
|
|
RunID: req.RunID,
|
|
Payload: map[string]string{"content": chunk.Content},
|
|
})
|
|
}
|
|
})
|
|
} else {
|
|
resp, err = l.provider.Chat(ctx, chatReq)
|
|
}
|
|
|
|
if err != nil {
|
|
l.emitLLMSpan(ctx, llmSpanStart, iteration, messages, nil, err)
|
|
return nil, fmt.Errorf("LLM call failed (iteration %d): %w", iteration, err)
|
|
}
|
|
|
|
l.emitLLMSpan(ctx, llmSpanStart, iteration, messages, resp, nil)
|
|
|
|
if resp.Usage != nil {
|
|
totalUsage.PromptTokens += resp.Usage.PromptTokens
|
|
totalUsage.CompletionTokens += resp.Usage.CompletionTokens
|
|
totalUsage.TotalTokens += resp.Usage.TotalTokens
|
|
}
|
|
|
|
// No tool calls → done
|
|
if len(resp.ToolCalls) == 0 {
|
|
finalContent = resp.Content
|
|
break
|
|
}
|
|
|
|
// Build assistant message with tool calls
|
|
assistantMsg := providers.Message{
|
|
Role: "assistant",
|
|
Content: resp.Content,
|
|
ToolCalls: resp.ToolCalls,
|
|
}
|
|
messages = append(messages, assistantMsg)
|
|
l.sessions.AddMessage(req.SessionKey, assistantMsg)
|
|
|
|
// Execute tool calls (parallel when multiple, sequential when single)
|
|
if len(resp.ToolCalls) == 1 {
|
|
// Single tool: sequential — no goroutine overhead
|
|
tc := resp.ToolCalls[0]
|
|
l.emit(AgentEvent{
|
|
Type: "tool.call",
|
|
AgentID: l.id,
|
|
RunID: req.RunID,
|
|
Payload: map[string]interface{}{"name": tc.Name, "id": tc.ID},
|
|
})
|
|
|
|
argsJSON, _ := json.Marshal(tc.Arguments)
|
|
slog.Info("tool call", "agent", l.id, "tool", tc.Name, "args_len", len(argsJSON))
|
|
|
|
toolSpanStart := time.Now().UTC()
|
|
result := l.tools.ExecuteWithContext(ctx, tc.Name, tc.Arguments, req.Channel, req.ChatID, req.PeerKind, req.SessionKey, nil)
|
|
|
|
l.emitToolSpan(ctx, toolSpanStart, tc.Name, tc.ID, string(argsJSON), result.ForLLM, result.IsError)
|
|
|
|
if result.Async {
|
|
asyncToolCalls = append(asyncToolCalls, tc.Name)
|
|
}
|
|
|
|
if result.IsError {
|
|
errMsg := result.ForLLM
|
|
if len(errMsg) > 200 {
|
|
errMsg = errMsg[:200] + "..."
|
|
}
|
|
slog.Warn("tool error", "agent", l.id, "tool", tc.Name, "error", errMsg)
|
|
}
|
|
|
|
l.emit(AgentEvent{
|
|
Type: "tool.result",
|
|
AgentID: l.id,
|
|
RunID: req.RunID,
|
|
Payload: map[string]interface{}{
|
|
"name": tc.Name,
|
|
"id": tc.ID,
|
|
"is_error": result.IsError,
|
|
},
|
|
})
|
|
|
|
toolMsg := providers.Message{
|
|
Role: "tool",
|
|
Content: result.ForLLM,
|
|
ToolCallID: tc.ID,
|
|
}
|
|
messages = append(messages, toolMsg)
|
|
l.sessions.AddMessage(req.SessionKey, toolMsg)
|
|
} else {
|
|
// Multiple tools: parallel execution via goroutines.
|
|
// Tool instances are immutable (context-based) so concurrent access is safe.
|
|
// Results are collected then processed sequentially for deterministic ordering.
|
|
type indexedResult struct {
|
|
idx int
|
|
tc providers.ToolCall
|
|
result *tools.Result
|
|
argsJSON string
|
|
spanStart time.Time
|
|
}
|
|
|
|
// 1. Emit all tool.call events upfront (client sees all calls starting)
|
|
for _, tc := range resp.ToolCalls {
|
|
l.emit(AgentEvent{
|
|
Type: "tool.call",
|
|
AgentID: l.id,
|
|
RunID: req.RunID,
|
|
Payload: map[string]interface{}{"name": tc.Name, "id": tc.ID},
|
|
})
|
|
}
|
|
|
|
// 2. Execute all tools in parallel
|
|
resultCh := make(chan indexedResult, len(resp.ToolCalls))
|
|
var wg sync.WaitGroup
|
|
|
|
for i, tc := range resp.ToolCalls {
|
|
wg.Add(1)
|
|
go func(idx int, tc providers.ToolCall) {
|
|
defer wg.Done()
|
|
argsJSON, _ := json.Marshal(tc.Arguments)
|
|
slog.Info("tool call", "agent", l.id, "tool", tc.Name, "args_len", len(argsJSON), "parallel", true)
|
|
spanStart := time.Now().UTC()
|
|
result := l.tools.ExecuteWithContext(ctx, tc.Name, tc.Arguments, req.Channel, req.ChatID, req.PeerKind, req.SessionKey, nil)
|
|
resultCh <- indexedResult{idx: idx, tc: tc, result: result, argsJSON: string(argsJSON), spanStart: spanStart}
|
|
}(i, tc)
|
|
}
|
|
|
|
// Close channel after all goroutines complete (run in separate goroutine to avoid deadlock)
|
|
go func() { wg.Wait(); close(resultCh) }()
|
|
|
|
// 3. Collect results
|
|
collected := make([]indexedResult, 0, len(resp.ToolCalls))
|
|
for r := range resultCh {
|
|
collected = append(collected, r)
|
|
}
|
|
|
|
// 4. Sort by original index → deterministic message ordering
|
|
sort.Slice(collected, func(i, j int) bool {
|
|
return collected[i].idx < collected[j].idx
|
|
})
|
|
|
|
// 5. Process results sequentially: emit events, append messages, save to session
|
|
for _, r := range collected {
|
|
l.emitToolSpan(ctx, r.spanStart, r.tc.Name, r.tc.ID, r.argsJSON, r.result.ForLLM, r.result.IsError)
|
|
|
|
if r.result.Async {
|
|
asyncToolCalls = append(asyncToolCalls, r.tc.Name)
|
|
}
|
|
|
|
if r.result.IsError {
|
|
errMsg := r.result.ForLLM
|
|
if len(errMsg) > 200 {
|
|
errMsg = errMsg[:200] + "..."
|
|
}
|
|
slog.Warn("tool error", "agent", l.id, "tool", r.tc.Name, "error", errMsg)
|
|
}
|
|
|
|
l.emit(AgentEvent{
|
|
Type: "tool.result",
|
|
AgentID: l.id,
|
|
RunID: req.RunID,
|
|
Payload: map[string]interface{}{
|
|
"name": r.tc.Name,
|
|
"id": r.tc.ID,
|
|
"is_error": r.result.IsError,
|
|
},
|
|
})
|
|
|
|
toolMsg := providers.Message{
|
|
Role: "tool",
|
|
Content: r.result.ForLLM,
|
|
ToolCallID: r.tc.ID,
|
|
}
|
|
messages = append(messages, toolMsg)
|
|
l.sessions.AddMessage(req.SessionKey, toolMsg)
|
|
}
|
|
}
|
|
}
|
|
|
|
// 4. Full sanitization pipeline (matching TS extractAssistantText + sanitizeUserFacingText)
|
|
finalContent = SanitizeAssistantContent(finalContent)
|
|
|
|
// 5. Handle NO_REPLY: save to session for context but mark as silent.
|
|
// Matching TS: NO_REPLY is saved (via resolveSilentReplyFallbackText) but
|
|
// filtered at the payload level before delivery.
|
|
isSilent := IsSilentReply(finalContent)
|
|
|
|
// 6. Fallback for empty content
|
|
if finalContent == "" {
|
|
if len(asyncToolCalls) > 0 {
|
|
finalContent = "..."
|
|
} else {
|
|
finalContent = "..."
|
|
}
|
|
}
|
|
|
|
l.sessions.AddMessage(req.SessionKey, providers.Message{
|
|
Role: "assistant",
|
|
Content: finalContent,
|
|
})
|
|
|
|
// Write session metadata (matching TS session entry updates)
|
|
l.sessions.UpdateMetadata(req.SessionKey, l.model, l.provider.Name(), req.Channel)
|
|
l.sessions.AccumulateTokens(req.SessionKey, int64(totalUsage.PromptTokens), int64(totalUsage.CompletionTokens))
|
|
l.sessions.Save(req.SessionKey)
|
|
|
|
// If silent, return empty content so gateway suppresses delivery.
|
|
if isSilent {
|
|
slog.Info("agent loop: NO_REPLY detected, suppressing delivery",
|
|
"agent", l.id, "session", req.SessionKey)
|
|
finalContent = ""
|
|
}
|
|
|
|
// 5. Maybe summarize
|
|
l.maybeSummarize(ctx, req.SessionKey)
|
|
|
|
return &RunResult{
|
|
Content: finalContent,
|
|
RunID: req.RunID,
|
|
Iterations: iteration,
|
|
Usage: &totalUsage,
|
|
}, nil
|
|
}
|