mirror of
https://github.com/tiennm99/goclaw.git
synced 2026-07-31 22:22:06 +00:00
Duy /zuey/andGitHub
4472c607b8
* feat(packages): add update flow for GitHub binaries (#900) Closes #900. Proactive update-check + atomic swap for GitHub-installed binaries on the Runtime & Packages page. Interfaces prepared for pip/npm/apk extension in Phase 2. - UpdateCache + UpdateRegistry + PackageLocker (ctx-aware keyed mutex) - GitHubUpdateChecker: ETag-aware, distinct /latest vs /list ETag keys, semver-correct ordering via golang.org/x/mod/semver, non-semver fallback that refuses to downgrade, pre-release + stable candidate fusion for the v1.0.0-rc.1 -> v1.0.0 transition - GitHubUpdateExecutor: two-phase .bak swap with hadBackup-aware rollback, manifest save retry (3x, 100ms/500ms/1s backoff), nil-safe meta access, explicit ScratchDir, 0755 set pre-rename - HTTP: GET /v1/packages/updates (SWR), POST /v1/packages/updates/refresh, POST /v1/packages/update, POST /v1/packages/updates/apply-all (always 200, failed[] is error source). Master-scope gated. - WS events package.update.{checked,started,succeeded,failed} forwarded to owner clients via event_filter.go - Frontend: useUpdates hook + 3 components (summary bar, update-all modal, row button), master-scope-gated disabled state - i18n: 8 backend keys + 17 frontend keys x en/vi/zh - Config: packages.github_token (reserved), updates_check_ttl, scratch_dir - 45+ new tests, race-clean, BenchmarkCheckAll10Packages ~1.1ms/op warm * docs(packages): document update flow + Phase 1 completion - packages-github.md: "Updating Installed Packages" section with UI + API contract, troubleshooting runbook (corrupt cache, rate-limit, scratch dir, mid-swap recovery) - 17-changelog.md + CHANGELOG.md: Phase 1 entry - 14-skills-runtime.md: cross-ref to update flow - journal entry capturing CRIT fixes (double-write, lock-key mismatch, rollback false-alarm) + design wins (keyed locks, red-team pre-flight) * feat(workstation): remote workstation runtime — SSH exec + security + audit Adds generic Remote Workstation Runtime enabling agents to execute commands on user-owned SSH workstations. Includes registry (DB + API + UI), SSH backend with connection pool and circuit breaker, workstation.exec + claude_remote tools, NFKC + binary-name allowlist security, and audit logging. Standard edition only. Closes #941. * fix(workstation): address 3 critical + 5 important code review findings - C1: Add json:"-" to Metadata/DefaultEnv fields; use SanitizedView() in all API responses to prevent SSH private key leakage - C2: Wire CheckEnv into PermCheckFn; LD_PRELOAD/PATH injection now blocked - C3: SSH Setenv fallback — prepend `export K=V;` when server rejects Setenv - I1: BackendCache sync.RWMutex → sync.Mutex (fix data race on lastUsed) - I2: Validate metadata shape in handleUpdate before store write - I3: Include command in exec-done event; activity sink uses actual cmd hash - I4: Wrap pool release in sync.Once (idempotent double-call safety) - I5: Verify workstation tenant ownership before adding permissions * fix(packages): bypass HTTPS+IP validation in update executor tests Test httptest servers bind to http://127.0.0.1 which fails both the HTTPS scheme check and literal-IP SSRF guard. Add testSkipDownloadValidation flag (same pattern as existing withTestDownloadHosts) to skip full URL validation in test context. * fix(workstation): address Claude review findings — tenant isolation + pool leak + dead code - Activity list: add workstation ownership check before listing (prevents cross-tenant activity enumeration via known UUID) - SSH pool: clean up p.sem + p.circuits maps in CloseWorkstation, prune, and Close to prevent unbounded map growth - RPC handlers: return ErrInvalidRequest on JSON unmarshal failure instead of silently using zero-value params - Remove unused containsControlChars function in normalize.go - HTTP tests: add 10s context timeout to prevent CI package timeout * fix(workstation): DefaultEnv JSON parse, backend cache leak, perm ownership check - DefaultEnv: replace KEY=VALUE text parse with json.Unmarshal (stored as JSON by HTTP handler, was silently ignored) - BackendCache: close losing backend on concurrent cache miss to prevent pruneLoop goroutine leak - Backend interface: add Close() error method; SSHBackend delegates to pool.Close() - handlePermList: add wsStore.GetByID ownership check (prevents cross-tenant UUID enumeration returning empty array vs 404) - scanRows: log scan errors instead of silently skipping * fix(workstation): wire activity sink shutdown + remove misleading comment - WireActivitySink: capture cleanup func, register in gateway shutdown (was discarded → retention goroutine leaked + buffered rows lost) - Add Stop() to WorkstationActivityStore interface (PG+SQLite already had it) - wireWorkstationTools returns cleanup func; gateway.go defers it - Remove misleading "re-validate env" comment in allowlist.go Check() * ci: bump unit test timeout from 90s to 120s hooks/handlers package (goja script tests) consumes ~85s on cold CI runners, leaving insufficient headroom for HTTP retry tests with 1s backoff. 120s provides adequate breathing room without masking real deadlocks. * fix: compile errors in integration tests + allowlist docstring - packages_update_test: add missing lockKey arg to registry.Apply - mcp_grant_revoke_test: remove unused fakeMCPClient struct - allowlist.go: fix Check() docstring to match actual 3-step pipeline * fix(test): relax mcp grant revoke assertion for pre-Phase02 state Execute-time grant checking not yet wired — test correctly gets an error but the message is "no active client" (nil clientPtr) rather than "grant revoked". Accept any error as valid regression guard. * chore: trigger CI on digitopvn/goclaw fork * ci: retrigger workflows * fix(permissions): classify workstation methods in RBAC policy
145 lines
5.6 KiB
Go
145 lines
5.6 KiB
Go
package protocol
|
|
|
|
// WebSocket event names pushed from server to client.
|
|
const (
|
|
EventAgent = "agent"
|
|
EventChat = "chat"
|
|
EventHealth = "health"
|
|
EventCron = "cron"
|
|
EventHeartbeat = "heartbeat"
|
|
EventExecApprovalReq = "exec.approval.requested"
|
|
EventExecApprovalRes = "exec.approval.resolved"
|
|
EventPresence = "presence"
|
|
EventTick = "tick"
|
|
EventShutdown = "shutdown"
|
|
EventNodePairRequested = "node.pair.requested"
|
|
EventNodePairResolved = "node.pair.resolved"
|
|
EventDevicePairReq = "device.pair.requested"
|
|
EventDevicePairRes = "device.pair.resolved"
|
|
EventVoicewakeChanged = "voicewake.changed"
|
|
EventConnectChallenge = "connect.challenge"
|
|
EventTalkMode = "talk.mode"
|
|
|
|
// Agent summoning events (predefined agent setup via LLM).
|
|
EventAgentSummoning = "agent.summoning"
|
|
|
|
// Team activity events (real-time team workflow visibility).
|
|
EventTeamTaskCreated = "team.task.created"
|
|
EventTeamTaskCompleted = "team.task.completed"
|
|
EventTeamMessageSent = "team.message.sent"
|
|
EventDelegationStarted = "delegation.started"
|
|
EventDelegationCompleted = "delegation.completed"
|
|
|
|
// Delegation lifecycle events.
|
|
EventDelegationFailed = "delegation.failed"
|
|
EventDelegationCancelled = "delegation.cancelled"
|
|
EventDelegationProgress = "delegation.progress"
|
|
EventDelegationAccumulated = "delegation.accumulated"
|
|
EventDelegationAnnounce = "delegation.announce"
|
|
|
|
// Team task lifecycle events.
|
|
EventTeamTaskClaimed = "team.task.claimed"
|
|
EventTeamTaskCancelled = "team.task.cancelled"
|
|
EventTeamTaskFailed = "team.task.failed"
|
|
EventTeamTaskReviewed = "team.task.reviewed"
|
|
EventTeamTaskApproved = "team.task.approved"
|
|
EventTeamTaskRejected = "team.task.rejected"
|
|
EventTeamTaskProgress = "team.task.progress"
|
|
EventTeamTaskCommented = "team.task.commented"
|
|
EventTeamTaskAssigned = "team.task.assigned"
|
|
EventTeamTaskDispatched = "team.task.dispatched"
|
|
EventTeamTaskUpdated = "team.task.updated"
|
|
EventTeamTaskDeleted = "team.task.deleted"
|
|
EventTeamTaskStale = "team.task.stale"
|
|
EventTeamTaskAttachmentAdded = "team.task.attachment_added"
|
|
|
|
// Emitted when leader starts processing completed team task results (before announce run).
|
|
EventTeamLeaderProcessing = "team.leader.processing"
|
|
|
|
// Team CRUD events (admin operations).
|
|
EventTeamCreated = "team.created"
|
|
EventTeamUpdated = "team.updated"
|
|
EventTeamDeleted = "team.deleted"
|
|
EventTeamMemberAdded = "team.member.added"
|
|
EventTeamMemberRemoved = "team.member.removed"
|
|
|
|
// Workspace events (team file changes).
|
|
EventWorkspaceFileChanged = "workspace.file.changed"
|
|
|
|
// Agent link events (admin operations).
|
|
EventAgentLinkCreated = "agent_link.created"
|
|
EventAgentLinkUpdated = "agent_link.updated"
|
|
EventAgentLinkDeleted = "agent_link.deleted"
|
|
|
|
// Trace lifecycle events (realtime trace/span updates).
|
|
EventTraceUpdated = "trace.updated"
|
|
// Immediate status change event (not flush-buffered; fired on every status write).
|
|
EventTraceStatusChanged = "trace.status"
|
|
|
|
// Skill dependency check events (realtime progress during startup/rescan).
|
|
EventSkillDepsChecked = "skill.deps.checked"
|
|
EventSkillDepsComplete = "skill.deps.complete"
|
|
|
|
// Skill dependency install events (triggered by POST /v1/skills/install-deps).
|
|
EventSkillDepsInstalling = "skill.deps.installing"
|
|
EventSkillDepsInstalled = "skill.deps.installed"
|
|
|
|
// Per-item install events (triggered by POST /v1/skills/install-dep).
|
|
EventSkillDepItemInstalling = "skill.dep.item.installing" // payload: {dep: "pip:openpyxl"}
|
|
EventSkillDepItemInstalled = "skill.dep.item.installed" // payload: {dep, ok: bool, error?: string}
|
|
|
|
// Cache invalidation events (internal, not forwarded to WS clients).
|
|
EventCacheInvalidate = "cache.invalidate"
|
|
|
|
// Audit log event (internal, not forwarded to WS clients).
|
|
EventAuditLog = "audit.log"
|
|
|
|
// Session lifecycle events.
|
|
EventSessionUpdated = "session.updated"
|
|
|
|
// Zalo Personal QR login events (client-scoped, not broadcast).
|
|
EventZaloPersonalQRCode = "zalo.personal.qr.code"
|
|
EventZaloPersonalQRDone = "zalo.personal.qr.done"
|
|
|
|
// WhatsApp QR login events (client-scoped, not broadcast).
|
|
EventWhatsAppQRCode = "whatsapp.qr.code"
|
|
EventWhatsAppQRDone = "whatsapp.qr.done"
|
|
|
|
// Tenant access revocation — forces affected user's UI to logout.
|
|
EventTenantAccessRevoked = "tenant.access.revoked"
|
|
|
|
// Vault enrichment pipeline progress.
|
|
EventVaultEnrichProgress = "vault.enrich.progress"
|
|
|
|
// Background worker alerts (non-retryable LLM errors).
|
|
EventBackgroundError = "background.error"
|
|
|
|
// Workstation exec streaming events.
|
|
// EventWorkstationExecChunk is emitted for each stdout/stderr chunk during remote exec.
|
|
// Payload: WorkstationExecChunkPayload.
|
|
EventWorkstationExecChunk = "workstation.exec.chunk"
|
|
// EventWorkstationExecDone is emitted when a remote exec command finishes.
|
|
// Payload: WorkstationExecDonePayload.
|
|
EventWorkstationExecDone = "workstation.exec.done"
|
|
)
|
|
|
|
// Agent event subtypes (in payload.type)
|
|
const (
|
|
AgentEventRunStarted = "run.started"
|
|
AgentEventRunCompleted = "run.completed"
|
|
AgentEventRunFailed = "run.failed"
|
|
AgentEventRunCancelled = "run.cancelled"
|
|
AgentEventRunRetrying = "run.retrying"
|
|
AgentEventToolCall = "tool.call"
|
|
AgentEventToolResult = "tool.result"
|
|
AgentEventBlockReply = "block.reply"
|
|
AgentEventActivity = "activity" // agent phase transitions: thinking, tool_exec, compacting
|
|
)
|
|
|
|
// Chat event subtypes (in payload.type)
|
|
const (
|
|
ChatEventChunk = "chunk"
|
|
ChatEventMessage = "message"
|
|
ChatEventThinking = "thinking"
|
|
)
|