mirror of
https://github.com/tiennm99/goclaw.git
synced 2026-07-13 01:04:38 +00:00
viettranx
dc482ff169
Integration tests were running locally only — CI never exercised the 29 v3_*_test.go files under tests/integration/. This left the session tenant-isolation + vault scan-arity bugs undetected until a manual run this session. Changes: - tests/integration/v3_test_helper.go: testDB() now calls pg.InitSqlx(db) inside sharedDBOnce. Previously the test suite relied on whichever test ran first happening to call InitSqlx, so running with `-run <filter>` could segfault with a nil pkgSqlxDB. Removes the ordering-dependency land mine. - .github/workflows/ci.yaml: add services.pg block running pgvector/pgvector:pg18 with pg_isready healthcheck, set TEST_DATABASE_URL at job level, and add a new "Integration tests" step after unit tests. Uses -timeout=180s (vs 90s unit) because the first test runs migrations from scratch. Local integration suite: 2.9s. CI cold start expected ~30-60s with image pull + migrations.
77 lines
2.5 KiB
YAML
77 lines
2.5 KiB
YAML
name: CI
|
|
|
|
on:
|
|
push:
|
|
branches: [main]
|
|
pull_request:
|
|
branches: [main, dev]
|
|
|
|
permissions:
|
|
contents: read
|
|
|
|
jobs:
|
|
go:
|
|
runs-on: ubuntu-latest
|
|
# Postgres service container for integration tests. pgvector/pgvector:pg18
|
|
# matches the local dev image (Makefile uses the same tag on port 5433).
|
|
# Healthcheck blocks the job until PG accepts connections, avoiding
|
|
# first-connection flakiness on cold runner starts.
|
|
services:
|
|
pg:
|
|
image: pgvector/pgvector:pg18
|
|
env:
|
|
POSTGRES_PASSWORD: test
|
|
POSTGRES_DB: goclaw_test
|
|
ports:
|
|
- 5432:5432
|
|
options: >-
|
|
--health-cmd "pg_isready -U postgres"
|
|
--health-interval 5s
|
|
--health-timeout 3s
|
|
--health-retries 10
|
|
env:
|
|
# tests/integration/v3_test_helper.go reads TEST_DATABASE_URL and runs
|
|
# migrations once via golang-migrate. Uses port 5432 (CI-clean) vs 5433
|
|
# for local dev (avoids clash with desktop Postgres installs).
|
|
TEST_DATABASE_URL: postgres://postgres:test@localhost:5432/goclaw_test?sslmode=disable
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
- uses: actions/setup-go@v5
|
|
with:
|
|
go-version-file: go.mod
|
|
cache-dependency-path: go.sum
|
|
- run: go build ./...
|
|
- run: go build -tags sqliteonly ./...
|
|
- run: go vet ./...
|
|
# -timeout=90s caps each test binary so a deadlocked test fails fast
|
|
# instead of blocking CI for the 10-minute default. Race-heavy wave C
|
|
# suites run in <20s, so 90s leaves ample breathing room.
|
|
- name: Unit tests
|
|
run: go test -race -timeout=90s -coverpkg=./... -coverprofile=coverage.out ./...
|
|
# Integration suite runs against the `pg` service container above.
|
|
# Longer -timeout=180s because the first test runs migrations from
|
|
# scratch (can take 10-30s on a cold CI runner). Local full suite
|
|
# completes in <3s against a warm DB.
|
|
- name: Integration tests
|
|
run: go test -race -timeout=180s -tags integration ./tests/integration/
|
|
- name: Coverage summary
|
|
run: go tool cover -func=coverage.out | tail -1
|
|
|
|
web:
|
|
runs-on: ubuntu-latest
|
|
defaults:
|
|
run:
|
|
working-directory: ui/web
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
- uses: pnpm/action-setup@v4
|
|
with:
|
|
version: 10
|
|
- uses: actions/setup-node@v4
|
|
with:
|
|
node-version: 22
|
|
cache: pnpm
|
|
cache-dependency-path: ui/web/pnpm-lock.yaml
|
|
- run: pnpm install --frozen-lockfile
|
|
- run: pnpm build
|