From a8c622d41fad2760786c5111e7011452ff885208 Mon Sep 17 00:00:00 2001 From: The Nerd Coder <64542454+bedantH@users.noreply.github.com> Date: Fri, 16 Apr 2021 00:36:01 +0530 Subject: [PATCH 1/5] Create bedanth.json --- domains/bedanth.json | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 domains/bedanth.json diff --git a/domains/bedanth.json b/domains/bedanth.json new file mode 100644 index 000000000..7e63dfaa8 --- /dev/null +++ b/domains/bedanth.json @@ -0,0 +1,11 @@ +{ + "description": "Bedant Hota's Portfolio", + "repo": "https://github.com/bedantH/bedantH.github.io", + "owner": { + "username": "bedantH", + "email": "mohanesh.h2003@gmail.com" + }, + "record": { + "CNAME": "bedantH.github.io" + } +} From 2c618cc117942923135c05ab048a90e3b99fc89b Mon Sep 17 00:00:00 2001 From: Charalampos Fanoulis Date: Thu, 15 Apr 2021 23:39:49 +0300 Subject: [PATCH 2/5] feat: register charalampos.is-a.dev --- domains/charalampos.json | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 domains/charalampos.json diff --git a/domains/charalampos.json b/domains/charalampos.json new file mode 100644 index 000000000..b7ff755dc --- /dev/null +++ b/domains/charalampos.json @@ -0,0 +1,11 @@ +{ + "description": "Redirection domain for my personal website", + "repo": "https://github.com/cfanoulis/fanoulis.dev", + "owner": { + "username": "cfanoulis", + "email": "domains@fanoulis.dev" + }, + "record": { + "URL": "https://fanoulis.dev" + } +} From 067900bb87dedf7d95bdcd0dcfa6651309e621f4 Mon Sep 17 00:00:00 2001 From: RoBlockHead <15642007+RoBlockHead@users.noreply.github.com> Date: Thu, 15 Apr 2021 22:16:12 -0400 Subject: [PATCH 3/5] tessa.is-a.dev --- domains/tessa.json | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 domains/tessa.json diff --git a/domains/tessa.json b/domains/tessa.json new file mode 100644 index 000000000..7fef11872 --- /dev/null +++ b/domains/tessa.json @@ -0,0 +1,11 @@ +{ + "description": "My main site :)", + "repo": "https://replit.com/@RoBlockHead/tessais-adev", + "owner": { + "username": "RoBlockHead", + "email": "tessa7551@gmail.com" + }, + "record": { + "CNAME": "06745170-24e7-4954-a619-2860f8b395c2.repl.co" + } +} From 649a11a31a53d7a4d338991e60322ec0f5caa0ce Mon Sep 17 00:00:00 2001 From: Koolwiza <72822494+Koolwiza@users.noreply.github.com> Date: Fri, 16 Apr 2021 08:45:37 -0700 Subject: [PATCH 4/5] Update koolwiza.json --- domains/koolwiza.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/domains/koolwiza.json b/domains/koolwiza.json index be0e560b3..57cd570dd 100644 --- a/domains/koolwiza.json +++ b/domains/koolwiza.json @@ -1,7 +1,7 @@ { "owner": { "username": "Koolwiza", - "email": "koowliza@gmail.com" + "email": "koolwiza@gmail.com" }, "description": "Just a cool subdomain to have :)", "repo": "https://www.github.com/Koolwiza", From 0d917155f37e444cfe192196c2f8e9a6c8ee40f3 Mon Sep 17 00:00:00 2001 From: Akshay Nair Date: Sat, 17 Apr 2021 10:58:39 +0530 Subject: [PATCH 5/5] Update pr-review.md --- docs/maintainers/pr-review.md | 48 ++++++++++++++++++++++++++++++++--- 1 file changed, 44 insertions(+), 4 deletions(-) diff --git a/docs/maintainers/pr-review.md b/docs/maintainers/pr-review.md index 2737754bd..0af094676 100644 --- a/docs/maintainers/pr-review.md +++ b/docs/maintainers/pr-review.md @@ -1,6 +1,7 @@ # Reviewing pull requests There are a few things you'll need to look out for when reviewing pull requests for domain registrations. This list is not exhaustive and will be updated. +--- ### CI errors A lot of minor issues will be caught in the CI checks @@ -9,24 +10,63 @@ A lot of minor issues will be caught in the CI checks If the CI is failing, tag the user and comment on the pr. +--- + +### Contents of the website +We need to make sure that the contents being hosted via the record being registered is used for malicious purposes. +To do this, we must try our best to verify the contents of website and if required ask some questions regarding the contents in the PR. + +--- ### Invalid email/social link A way to contact the user is important in case we need to inform the users of some changes to the project. Confirm if the email looks valid or the social user name/link works. The user should have either an email or a valid social link. +❌ `"owner": { "username": "gh-username" }` is invalid as it doesn't contain an email or any social links + +❌ `"email": "28372878+user-name@users.noreply.github.com"` is invalid as the email cannot be used + +✅ `"owner": { "username": "phenax", "twitter": "twitter-username" }` is valid as it contains a social link + +✅ `"owner": { "username": "phenax", "email": "email@gmail.com" }` is valid as it contains an email + +--- ### Invalid CNAME -CNAME has to be a hostname. Something like 'example.com'. -People tend to accidentally put a url there instead sometimes like `http://something.com` or `something.com/path`. -Both of those are invalid. +CNAME has to be a hostname. Something like `example.com`. +❌ `http://example.com` is invalid as it contains a protocol `https://` + +❌ `example.com/some/path` is invalid as it contains the path name `/some/path` + +✅ `example.com` is valid as it is the hostname of the website + +--- ### Invalid A -A record has to be an array of ips +A record has to be an array of ips. +❌ `"A": "211.211.211.211"` is invalid as it must be an array + +❌ `"A": ["example.com"]` is invalid as it is not an ip address + +✅ `"A": ["211.211.211.211", "211.211.211.212"]` is valid as it is an array of ips + +--- + +### Invalid URL +The URL must have a protocol (`http://` or `https://`) and must be something like `https://example.com` or `https://example.com/some/path`. + +❌ `example.com` is invalid as it doesn't contain the protocol + +✅ `https://example.com/some/path` is valid as it contains a protocol + +--- ### Only one record type Earlier, is-a-dev used to allow for handling https redirections along with CNAME but the way we handle requests has changed since then. This is why a record file can only contain one record type. Either `CNAME` or `A` or `URL`. +❌ `"CNAME": "example.com", "URL": "https://something.com"` is invalid as it should only contain one type of record, either CNAME or URL. +