From 6be3059bbe8a59bbf58e3b94573c764eadc43807 Mon Sep 17 00:00:00 2001 From: William Harrison Date: Mon, 1 Jul 2024 14:42:04 +0800 Subject: [PATCH 1/4] support domain key records --- tests/validations.test.js | 3 +++ utils/invalid-domains.json | 1 + utils/validations.js | 1 + 3 files changed, 5 insertions(+) diff --git a/tests/validations.test.js b/tests/validations.test.js index a102eeb73..bb2cac176 100644 --- a/tests/validations.test.js +++ b/tests/validations.test.js @@ -68,6 +68,7 @@ describe('validateDomainData', () => { { ...defaultDomain, name: '_acme-challenge' }, { ...defaultDomain, name: '_dmarc' }, { ...defaultDomain, name: '_gh-is-a-dev' }, + { ...defaultDomain, name: '_domainkey' }, ]; const validCases = [ @@ -104,6 +105,8 @@ describe('validateDomainData', () => { { ...defaultDomain, name: '_gh-phenax.akshay' }, { ...defaultDomain, name: '_gh-hello01-ga' }, { ...defaultDomain, name: '_gh-hello01_ga' }, + { ...defaultDomain, name: '_domainkey.subdomain' }, + { ...defaultDomain, name: 'mx._domainkey.subdomain' }, ]; it('should return false for invalid data', () => { diff --git a/utils/invalid-domains.json b/utils/invalid-domains.json index 1122df7fe..7c3a1ea1d 100644 --- a/utils/invalid-domains.json +++ b/utils/invalid-domains.json @@ -2,6 +2,7 @@ "_acme-challenge", "_discord", "_dmarc", + "_domainkey", "_gh-is-a-dev", "_github-challenge-is-a-dev", "_github-pages-challenge-is-a-dev", diff --git a/utils/validations.js b/utils/validations.js index a5f17eece..d68f6a546 100644 --- a/utils/validations.js +++ b/utils/validations.js @@ -42,6 +42,7 @@ const extraSupportedNames = [ R.equals('_gitlab-pages-verification-code'), R.equals('_acme-challenge'), R.equals('_dmarc'), + R.equals('_domainkey'), testRegex(/^_gh-[a-z0-9-_]+$/i), // Exception for the new github org verification records ] From 92bfc5a72ad88952ff48b6b0f59c662834984913 Mon Sep 17 00:00:00 2001 From: William Harrison Date: Mon, 1 Jul 2024 14:43:24 +0800 Subject: [PATCH 2/4] test "valid" domains --- domains/_domainkey.william.json | 9 +++++++++ domains/mx._domainkey.william.json | 9 +++++++++ 2 files changed, 18 insertions(+) create mode 100644 domains/_domainkey.william.json create mode 100644 domains/mx._domainkey.william.json diff --git a/domains/_domainkey.william.json b/domains/_domainkey.william.json new file mode 100644 index 000000000..1ff115871 --- /dev/null +++ b/domains/_domainkey.william.json @@ -0,0 +1,9 @@ +{ + "owner": { + "username": "wdhdev", + "email": "" + }, + "record": { + "TXT": "domainkey-test" + } +} diff --git a/domains/mx._domainkey.william.json b/domains/mx._domainkey.william.json new file mode 100644 index 000000000..1ff115871 --- /dev/null +++ b/domains/mx._domainkey.william.json @@ -0,0 +1,9 @@ +{ + "owner": { + "username": "wdhdev", + "email": "" + }, + "record": { + "TXT": "domainkey-test" + } +} From adabca4ad144685da280245d9cffd968d89ffea3 Mon Sep 17 00:00:00 2001 From: William Harrison Date: Mon, 1 Jul 2024 14:44:51 +0800 Subject: [PATCH 3/4] invalid test case --- domains/{_domainkey.william.json => _domainkey.json} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename domains/{_domainkey.william.json => _domainkey.json} (100%) diff --git a/domains/_domainkey.william.json b/domains/_domainkey.json similarity index 100% rename from domains/_domainkey.william.json rename to domains/_domainkey.json From 69004013760a2d8ca1aec5daf673ae667bedc527 Mon Sep 17 00:00:00 2001 From: William Harrison Date: Mon, 1 Jul 2024 14:46:03 +0800 Subject: [PATCH 4/4] delete test domains --- domains/_domainkey.json | 9 --------- domains/mx._domainkey.william.json | 9 --------- 2 files changed, 18 deletions(-) delete mode 100644 domains/_domainkey.json delete mode 100644 domains/mx._domainkey.william.json diff --git a/domains/_domainkey.json b/domains/_domainkey.json deleted file mode 100644 index 1ff115871..000000000 --- a/domains/_domainkey.json +++ /dev/null @@ -1,9 +0,0 @@ -{ - "owner": { - "username": "wdhdev", - "email": "" - }, - "record": { - "TXT": "domainkey-test" - } -} diff --git a/domains/mx._domainkey.william.json b/domains/mx._domainkey.william.json deleted file mode 100644 index 1ff115871..000000000 --- a/domains/mx._domainkey.william.json +++ /dev/null @@ -1,9 +0,0 @@ -{ - "owner": { - "username": "wdhdev", - "email": "" - }, - "record": { - "TXT": "domainkey-test" - } -}