From 779d2588885f832eaa41c75edb552ba57c5a3d00 Mon Sep 17 00:00:00 2001 From: Akshay Nair Date: Tue, 13 Sep 2022 13:00:59 +0530 Subject: [PATCH] feat(validation): adds support for org github verification --- tests/validations.test.js | 4 ++++ utils/invalid-domains.json | 3 ++- utils/validations.js | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/tests/validations.test.js b/tests/validations.test.js index 219b58a2b..e97ddbb08 100644 --- a/tests/validations.test.js +++ b/tests/validations.test.js @@ -59,6 +59,7 @@ describe('validateDomainData', () => { { ...defaultDomain, name: 'ww2.baa' }, { ...defaultDomain, name: 'help.baa' }, { ...defaultDomain, name: '_github-pages-challenge-is-a-dev' }, + { ...defaultDomain, name: '_github-challenge-is-a-dev' }, ]; const validCases = [ @@ -82,6 +83,9 @@ describe('validateDomainData', () => { { ...defaultDomain, name: '_github-pages-challenge-phenax.akshay' }, { ...defaultDomain, name: '_github-pages-challenge-hello01-ga' }, { ...defaultDomain, name: '_github-pages-challenge-hello01_ga' }, + { ...defaultDomain, name: '_github-challenge-phenax.akshay' }, + { ...defaultDomain, name: '_github-challenge-hello01-ga' }, + { ...defaultDomain, name: '_github-challenge-hello01_ga' }, ]; it('should return false for invalid data', () => { diff --git a/utils/invalid-domains.json b/utils/invalid-domains.json index 1c75c632d..55834e77a 100644 --- a/utils/invalid-domains.json +++ b/utils/invalid-domains.json @@ -12,5 +12,6 @@ "ww2", "ww3", "ww4", - "_github-pages-challenge-is-a-dev" + "_github-pages-challenge-is-a-dev", + "_github-challenge-is-a-dev" ] diff --git a/utils/validations.js b/utils/validations.js index 2a31a538a..963e8ed3d 100644 --- a/utils/validations.js +++ b/utils/validations.js @@ -37,7 +37,7 @@ const validateDomainData = validate({ R.compose( R.all(or([ and([ - testRegex(/^_github-pages-challenge-[a-z0-9-_]+$/i), // Exception for github verification records + testRegex(/^_github(-pages)?-challenge-[a-z0-9-_]+$/i), // Exception for github verification records checkRestrictedNames, ]), and([