From 6894d81a3be147e4ef16c2cf2650c93894317a5b Mon Sep 17 00:00:00 2001 From: Didien Munezero <51176044+didiermunezero@users.noreply.github.com> Date: Tue, 13 Apr 2021 10:51:33 +0200 Subject: [PATCH 01/13] Create didier.json --- domains/didier.json | 1 + 1 file changed, 1 insertion(+) create mode 100644 domains/didier.json diff --git a/domains/didier.json b/domains/didier.json new file mode 100644 index 000000000..8b1378917 --- /dev/null +++ b/domains/didier.json @@ -0,0 +1 @@ + From 2304f4c74f1334e8c8f3e37be801c61680e78d6f Mon Sep 17 00:00:00 2001 From: Didien Munezero <51176044+didiermunezero@users.noreply.github.com> Date: Tue, 13 Apr 2021 10:54:56 +0200 Subject: [PATCH 02/13] Update didier.json --- domains/didier.json | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/domains/didier.json b/domains/didier.json index 8b1378917..9b83e2b56 100644 --- a/domains/didier.json +++ b/domains/didier.json @@ -1 +1,10 @@ +{ + "description": "Add some description", + "repo": "https://github.com/github-username", + "owner": { + "username": "github-username", + "email": "any@email" + }, + "record": {} +} From 17a179125572349e2f53377bde1fc8b545877672 Mon Sep 17 00:00:00 2001 From: Didien Munezero <51176044+didiermunezero@users.noreply.github.com> Date: Tue, 13 Apr 2021 10:56:42 +0200 Subject: [PATCH 03/13] Update didier.json --- domains/didier.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/domains/didier.json b/domains/didier.json index 9b83e2b56..400de618f 100644 --- a/domains/didier.json +++ b/domains/didier.json @@ -1,10 +1,10 @@ { - "description": "Add some description", - "repo": "https://github.com/github-username", + "description": "Hello there I am Didier Munezero", + "repo": "https://github.com/didiermunezero", "owner": { - "username": "github-username", - "email": "any@email" + "username": "didiermunezero", + "email": "didiermunezer38@gmail.com" }, "record": {} } From c1f48bcfe0fade46f7d08159a2feca24d6b49dc4 Mon Sep 17 00:00:00 2001 From: Didien Munezero <51176044+didiermunezero@users.noreply.github.com> Date: Tue, 13 Apr 2021 11:00:12 +0200 Subject: [PATCH 04/13] Update didier.json --- domains/didier.json | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/domains/didier.json b/domains/didier.json index 400de618f..4d517219f 100644 --- a/domains/didier.json +++ b/domains/didier.json @@ -6,5 +6,7 @@ "username": "didiermunezero", "email": "didiermunezer38@gmail.com" }, - "record": {} + "record": { + "CNAME": "munezero.me" + } } From a8c622d41fad2760786c5111e7011452ff885208 Mon Sep 17 00:00:00 2001 From: The Nerd Coder <64542454+bedantH@users.noreply.github.com> Date: Fri, 16 Apr 2021 00:36:01 +0530 Subject: [PATCH 05/13] Create bedanth.json --- domains/bedanth.json | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 domains/bedanth.json diff --git a/domains/bedanth.json b/domains/bedanth.json new file mode 100644 index 000000000..7e63dfaa8 --- /dev/null +++ b/domains/bedanth.json @@ -0,0 +1,11 @@ +{ + "description": "Bedant Hota's Portfolio", + "repo": "https://github.com/bedantH/bedantH.github.io", + "owner": { + "username": "bedantH", + "email": "mohanesh.h2003@gmail.com" + }, + "record": { + "CNAME": "bedantH.github.io" + } +} From 2c618cc117942923135c05ab048a90e3b99fc89b Mon Sep 17 00:00:00 2001 From: Charalampos Fanoulis Date: Thu, 15 Apr 2021 23:39:49 +0300 Subject: [PATCH 06/13] feat: register charalampos.is-a.dev --- domains/charalampos.json | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 domains/charalampos.json diff --git a/domains/charalampos.json b/domains/charalampos.json new file mode 100644 index 000000000..b7ff755dc --- /dev/null +++ b/domains/charalampos.json @@ -0,0 +1,11 @@ +{ + "description": "Redirection domain for my personal website", + "repo": "https://github.com/cfanoulis/fanoulis.dev", + "owner": { + "username": "cfanoulis", + "email": "domains@fanoulis.dev" + }, + "record": { + "URL": "https://fanoulis.dev" + } +} From 067900bb87dedf7d95bdcd0dcfa6651309e621f4 Mon Sep 17 00:00:00 2001 From: RoBlockHead <15642007+RoBlockHead@users.noreply.github.com> Date: Thu, 15 Apr 2021 22:16:12 -0400 Subject: [PATCH 07/13] tessa.is-a.dev --- domains/tessa.json | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 domains/tessa.json diff --git a/domains/tessa.json b/domains/tessa.json new file mode 100644 index 000000000..7fef11872 --- /dev/null +++ b/domains/tessa.json @@ -0,0 +1,11 @@ +{ + "description": "My main site :)", + "repo": "https://replit.com/@RoBlockHead/tessais-adev", + "owner": { + "username": "RoBlockHead", + "email": "tessa7551@gmail.com" + }, + "record": { + "CNAME": "06745170-24e7-4954-a619-2860f8b395c2.repl.co" + } +} From 8671b6320f421c57990e89fb5d84515de05519b0 Mon Sep 17 00:00:00 2001 From: Avnoor-Gamerz <75054972+Avnoor-Gamerz@users.noreply.github.com> Date: Fri, 16 Apr 2021 09:25:38 +0530 Subject: [PATCH 08/13] Create avnoor-gamerz.json --- domains/avnoor-gamerz.json | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 domains/avnoor-gamerz.json diff --git a/domains/avnoor-gamerz.json b/domains/avnoor-gamerz.json new file mode 100644 index 000000000..92d607ea7 --- /dev/null +++ b/domains/avnoor-gamerz.json @@ -0,0 +1,12 @@ +{ + "description": "Official WEBSITE OF aVNOOR gAMERZ", + "repo": "https://github.com/Avnoor-Gamerz/avnoor-gamerz.github.io", + "owner": { + "username": "avnoor-gamerz", + "email": "avnoorchahal001@gmail.com", + "twitter": "avnoor-gamerz" + }, + "record": { + "CNAME": "avnoor-gamerz.github.io" + } +} From 649a11a31a53d7a4d338991e60322ec0f5caa0ce Mon Sep 17 00:00:00 2001 From: Koolwiza <72822494+Koolwiza@users.noreply.github.com> Date: Fri, 16 Apr 2021 08:45:37 -0700 Subject: [PATCH 09/13] Update koolwiza.json --- domains/koolwiza.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/domains/koolwiza.json b/domains/koolwiza.json index be0e560b3..57cd570dd 100644 --- a/domains/koolwiza.json +++ b/domains/koolwiza.json @@ -1,7 +1,7 @@ { "owner": { "username": "Koolwiza", - "email": "koowliza@gmail.com" + "email": "koolwiza@gmail.com" }, "description": "Just a cool subdomain to have :)", "repo": "https://www.github.com/Koolwiza", From 17fe7970fcc2838cfe50ae7f246e314f4ff0c076 Mon Sep 17 00:00:00 2001 From: Shuchir Jain <53063247+CoolCoderSJ@users.noreply.github.com> Date: Fri, 16 Apr 2021 13:33:25 -0400 Subject: [PATCH 10/13] Create sjcdn.json --- domains/sjcdn.json | 10 ++++++++++ 1 file changed, 10 insertions(+) create mode 100644 domains/sjcdn.json diff --git a/domains/sjcdn.json b/domains/sjcdn.json new file mode 100644 index 000000000..af8d75dd4 --- /dev/null +++ b/domains/sjcdn.json @@ -0,0 +1,10 @@ +{ + "owner": { + "username": "CoolCoderSJ", + "email": "CoolCoderSJ@gmail.com" + }, + "description": "My CDN", + "record": { + "CNAME": "09d836a5-eaca-4299-bfec-44ca0dfc6d0d.repl.co" + } +} From 753e341ca30c3e8b8ecf7d8c0ce91b3eea93d7e2 Mon Sep 17 00:00:00 2001 From: Didien Munezero <51176044+didiermunezero@users.noreply.github.com> Date: Fri, 16 Apr 2021 20:59:28 +0200 Subject: [PATCH 11/13] Update didier.json --- domains/didier.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/domains/didier.json b/domains/didier.json index 4d517219f..c041c4c8a 100644 --- a/domains/didier.json +++ b/domains/didier.json @@ -7,6 +7,6 @@ "email": "didiermunezer38@gmail.com" }, "record": { - "CNAME": "munezero.me" + "CNAME": "didiermunezero.github.io" } } From 0d917155f37e444cfe192196c2f8e9a6c8ee40f3 Mon Sep 17 00:00:00 2001 From: Akshay Nair Date: Sat, 17 Apr 2021 10:58:39 +0530 Subject: [PATCH 12/13] Update pr-review.md --- docs/maintainers/pr-review.md | 48 ++++++++++++++++++++++++++++++++--- 1 file changed, 44 insertions(+), 4 deletions(-) diff --git a/docs/maintainers/pr-review.md b/docs/maintainers/pr-review.md index 2737754bd..0af094676 100644 --- a/docs/maintainers/pr-review.md +++ b/docs/maintainers/pr-review.md @@ -1,6 +1,7 @@ # Reviewing pull requests There are a few things you'll need to look out for when reviewing pull requests for domain registrations. This list is not exhaustive and will be updated. +--- ### CI errors A lot of minor issues will be caught in the CI checks @@ -9,24 +10,63 @@ A lot of minor issues will be caught in the CI checks If the CI is failing, tag the user and comment on the pr. +--- + +### Contents of the website +We need to make sure that the contents being hosted via the record being registered is used for malicious purposes. +To do this, we must try our best to verify the contents of website and if required ask some questions regarding the contents in the PR. + +--- ### Invalid email/social link A way to contact the user is important in case we need to inform the users of some changes to the project. Confirm if the email looks valid or the social user name/link works. The user should have either an email or a valid social link. +❌ `"owner": { "username": "gh-username" }` is invalid as it doesn't contain an email or any social links + +❌ `"email": "28372878+user-name@users.noreply.github.com"` is invalid as the email cannot be used + +✅ `"owner": { "username": "phenax", "twitter": "twitter-username" }` is valid as it contains a social link + +✅ `"owner": { "username": "phenax", "email": "email@gmail.com" }` is valid as it contains an email + +--- ### Invalid CNAME -CNAME has to be a hostname. Something like 'example.com'. -People tend to accidentally put a url there instead sometimes like `http://something.com` or `something.com/path`. -Both of those are invalid. +CNAME has to be a hostname. Something like `example.com`. +❌ `http://example.com` is invalid as it contains a protocol `https://` + +❌ `example.com/some/path` is invalid as it contains the path name `/some/path` + +✅ `example.com` is valid as it is the hostname of the website + +--- ### Invalid A -A record has to be an array of ips +A record has to be an array of ips. +❌ `"A": "211.211.211.211"` is invalid as it must be an array + +❌ `"A": ["example.com"]` is invalid as it is not an ip address + +✅ `"A": ["211.211.211.211", "211.211.211.212"]` is valid as it is an array of ips + +--- + +### Invalid URL +The URL must have a protocol (`http://` or `https://`) and must be something like `https://example.com` or `https://example.com/some/path`. + +❌ `example.com` is invalid as it doesn't contain the protocol + +✅ `https://example.com/some/path` is valid as it contains a protocol + +--- ### Only one record type Earlier, is-a-dev used to allow for handling https redirections along with CNAME but the way we handle requests has changed since then. This is why a record file can only contain one record type. Either `CNAME` or `A` or `URL`. +❌ `"CNAME": "example.com", "URL": "https://something.com"` is invalid as it should only contain one type of record, either CNAME or URL. + From 17db0c3be9e666b422d5f720883a1fed7f1a03ce Mon Sep 17 00:00:00 2001 From: Akshay Nair Date: Sat, 17 Apr 2021 11:34:52 +0530 Subject: [PATCH 13/13] cleanup --- domains/avnoor-gamerz.json | 2 +- domains/bedanth.json | 2 +- domains/caleb.json | 2 +- domains/charalampos.json | 2 +- domains/daniel.json | 2 +- domains/deadshot.json | 2 +- domains/didier.json | 3 +-- domains/dwii.json | 2 +- domains/fatgrizzly.json | 2 +- domains/flexico.json | 2 +- domains/gingdev.json | 2 +- domains/json.json | 2 +- domains/koolwiza.json | 2 +- domains/lejhand.json | 2 +- domains/matthew.json | 2 +- domains/mysteriousk.json | 2 +- domains/ovillafuerte94.json | 18 +++++++++--------- domains/rahulkirangaddam.json | 4 ++-- domains/rohan.json | 2 +- domains/sjcdn.json | 2 +- domains/tessa.json | 2 +- domains/tracker-brawley.json | 3 +-- domains/verite.json | 20 ++++++++++---------- domains/wiicreation.json | 2 +- domains/yuto.json | 18 +++++++++--------- 25 files changed, 51 insertions(+), 53 deletions(-) diff --git a/domains/avnoor-gamerz.json b/domains/avnoor-gamerz.json index 92d607ea7..ddb3b8bb2 100644 --- a/domains/avnoor-gamerz.json +++ b/domains/avnoor-gamerz.json @@ -9,4 +9,4 @@ "record": { "CNAME": "avnoor-gamerz.github.io" } -} +} \ No newline at end of file diff --git a/domains/bedanth.json b/domains/bedanth.json index 7e63dfaa8..dd82ce3ee 100644 --- a/domains/bedanth.json +++ b/domains/bedanth.json @@ -8,4 +8,4 @@ "record": { "CNAME": "bedantH.github.io" } -} +} \ No newline at end of file diff --git a/domains/caleb.json b/domains/caleb.json index 615f01dd3..9b6d43d36 100644 --- a/domains/caleb.json +++ b/domains/caleb.json @@ -8,4 +8,4 @@ "record": { "URL": "https://calebden.io" } -} +} \ No newline at end of file diff --git a/domains/charalampos.json b/domains/charalampos.json index b7ff755dc..44e920564 100644 --- a/domains/charalampos.json +++ b/domains/charalampos.json @@ -8,4 +8,4 @@ "record": { "URL": "https://fanoulis.dev" } -} +} \ No newline at end of file diff --git a/domains/daniel.json b/domains/daniel.json index 651180a64..f69282aa6 100644 --- a/domains/daniel.json +++ b/domains/daniel.json @@ -8,4 +8,4 @@ "record": { "CNAME": "71bac7ca-1eac-46fe-9588-cd31d68b2e06.repl.co" } -} +} \ No newline at end of file diff --git a/domains/deadshot.json b/domains/deadshot.json index 9d4670aa4..fedfa67f5 100644 --- a/domains/deadshot.json +++ b/domains/deadshot.json @@ -9,4 +9,4 @@ "record": { "CNAME": "deadshotofficial.github.io" } -} +} \ No newline at end of file diff --git a/domains/didier.json b/domains/didier.json index c041c4c8a..0aa6c14d5 100644 --- a/domains/didier.json +++ b/domains/didier.json @@ -1,4 +1,3 @@ - { "description": "Hello there I am Didier Munezero", "repo": "https://github.com/didiermunezero", @@ -9,4 +8,4 @@ "record": { "CNAME": "didiermunezero.github.io" } -} +} \ No newline at end of file diff --git a/domains/dwii.json b/domains/dwii.json index b5cd2203d..92e8eb2da 100644 --- a/domains/dwii.json +++ b/domains/dwii.json @@ -8,4 +8,4 @@ "record": { "URL": "https://dwii.my.id/" } -} +} \ No newline at end of file diff --git a/domains/fatgrizzly.json b/domains/fatgrizzly.json index 9160aabc0..ab2840978 100644 --- a/domains/fatgrizzly.json +++ b/domains/fatgrizzly.json @@ -11,4 +11,4 @@ "89.163.215.211" ] } -} +} \ No newline at end of file diff --git a/domains/flexico.json b/domains/flexico.json index 271aa1af2..0e075ee80 100644 --- a/domains/flexico.json +++ b/domains/flexico.json @@ -8,4 +8,4 @@ "record": { "CNAME": "7xh.github.io" } -} +} \ No newline at end of file diff --git a/domains/gingdev.json b/domains/gingdev.json index eedeecd64..4ddafcf2a 100644 --- a/domains/gingdev.json +++ b/domains/gingdev.json @@ -10,4 +10,4 @@ "192.243.108.102" ] } -} +} \ No newline at end of file diff --git a/domains/json.json b/domains/json.json index a406cd7f4..e2787e675 100644 --- a/domains/json.json +++ b/domains/json.json @@ -7,4 +7,4 @@ "record": { "URL": "https://jasonaa.me/" } -} +} \ No newline at end of file diff --git a/domains/koolwiza.json b/domains/koolwiza.json index 57cd570dd..63344fe26 100644 --- a/domains/koolwiza.json +++ b/domains/koolwiza.json @@ -8,4 +8,4 @@ "record": { "CNAME": "koolwiza.github.io" } -} +} \ No newline at end of file diff --git a/domains/lejhand.json b/domains/lejhand.json index 63c679686..0ca4935ea 100644 --- a/domains/lejhand.json +++ b/domains/lejhand.json @@ -8,4 +8,4 @@ "record": { "CNAME": "dazzling-williams-9e8070.netlify.app" } -} +} \ No newline at end of file diff --git a/domains/matthew.json b/domains/matthew.json index 7909c2f1e..78b3b3ccf 100644 --- a/domains/matthew.json +++ b/domains/matthew.json @@ -8,4 +8,4 @@ "record": { "URL": "https://mattglei.ch" } -} +} \ No newline at end of file diff --git a/domains/mysteriousk.json b/domains/mysteriousk.json index 14bc1fb7e..44a853808 100644 --- a/domains/mysteriousk.json +++ b/domains/mysteriousk.json @@ -8,4 +8,4 @@ "record": { "CNAME": "lawliet.host" } -} +} \ No newline at end of file diff --git a/domains/ovillafuerte94.json b/domains/ovillafuerte94.json index 63739647b..edc251a5b 100644 --- a/domains/ovillafuerte94.json +++ b/domains/ovillafuerte94.json @@ -1,11 +1,11 @@ { - "description": "Omar Villafuerte", - "repo": "https://github.com/ovillafuerte94/ovillafuerte94.github.io", - "owner": { - "username": "ovillafuerte94", - "email": "ovillafuerte.94@gmail.com" - }, - "record": { - "CNAME": "ovillafuerte94.github.io" - } + "description": "Omar Villafuerte", + "repo": "https://github.com/ovillafuerte94/ovillafuerte94.github.io", + "owner": { + "username": "ovillafuerte94", + "email": "ovillafuerte.94@gmail.com" + }, + "record": { + "CNAME": "ovillafuerte94.github.io" + } } \ No newline at end of file diff --git a/domains/rahulkirangaddam.json b/domains/rahulkirangaddam.json index 16673d37c..6473e4784 100644 --- a/domains/rahulkirangaddam.json +++ b/domains/rahulkirangaddam.json @@ -1,6 +1,6 @@ { "description": "Rahul Kiran Gaddam Profile", - "repo":"https://github.com/rahgadda/rahgadda.github.io", + "repo": "https://github.com/rahgadda/rahgadda.github.io", "owner": { "username": "rahgadda", "email": "gaddam.rahul@gmail.com" @@ -8,4 +8,4 @@ "record": { "CNAME": "rahgadda.github.io" } -} +} \ No newline at end of file diff --git a/domains/rohan.json b/domains/rohan.json index 832a60dac..d7c83f0a2 100644 --- a/domains/rohan.json +++ b/domains/rohan.json @@ -8,4 +8,4 @@ "record": { "URL": "https://rbansal.dev" } -} +} \ No newline at end of file diff --git a/domains/sjcdn.json b/domains/sjcdn.json index af8d75dd4..54e8f0cc8 100644 --- a/domains/sjcdn.json +++ b/domains/sjcdn.json @@ -7,4 +7,4 @@ "record": { "CNAME": "09d836a5-eaca-4299-bfec-44ca0dfc6d0d.repl.co" } -} +} \ No newline at end of file diff --git a/domains/tessa.json b/domains/tessa.json index 7fef11872..461033403 100644 --- a/domains/tessa.json +++ b/domains/tessa.json @@ -8,4 +8,4 @@ "record": { "CNAME": "06745170-24e7-4954-a619-2860f8b395c2.repl.co" } -} +} \ No newline at end of file diff --git a/domains/tracker-brawley.json b/domains/tracker-brawley.json index a601a15b4..feec194ac 100644 --- a/domains/tracker-brawley.json +++ b/domains/tracker-brawley.json @@ -1,4 +1,3 @@ - { "description": "a website for my biotapi", "repo": "https://github.com/brawlie/todo", @@ -9,4 +8,4 @@ "record": { "CNAME": "aa1b3bae-e49b-4efd-8c55-28719da5f58c.repl.co" } -} +} \ No newline at end of file diff --git a/domains/verite.json b/domains/verite.json index c57038fc9..048979880 100644 --- a/domains/verite.json +++ b/domains/verite.json @@ -1,11 +1,11 @@ { - "repo": "https://github.com/makuzaverite/veritem.me", - "owner": { - "username": "makuzaverite", - "email": "mugaboverite@gmail.com", - "twitter": "makuza_mugabo_v" - }, - "record": { - "URL": "https://veritem.me" - } -} + "repo": "https://github.com/makuzaverite/veritem.me", + "owner": { + "username": "makuzaverite", + "email": "mugaboverite@gmail.com", + "twitter": "makuza_mugabo_v" + }, + "record": { + "URL": "https://veritem.me" + } +} \ No newline at end of file diff --git a/domains/wiicreation.json b/domains/wiicreation.json index f175fa206..e0726aadb 100644 --- a/domains/wiicreation.json +++ b/domains/wiicreation.json @@ -8,4 +8,4 @@ "record": { "CNAME": "C1200.github.io" } -} +} \ No newline at end of file diff --git a/domains/yuto.json b/domains/yuto.json index f5aa2bd11..e2c5faec2 100644 --- a/domains/yuto.json +++ b/domains/yuto.json @@ -1,10 +1,10 @@ { - "owner": { - "username": "starptr", - "email": "yuto@berkeley.edu" - }, - "description": "Personal website", - "record": { - "URL": "https://yart.me" - } -} + "owner": { + "username": "starptr", + "email": "yuto@berkeley.edu" + }, + "description": "Personal website", + "record": { + "URL": "https://yart.me" + } +} \ No newline at end of file