From f76dda07f0f877bdc6dd16160ffb2de658b4a645 Mon Sep 17 00:00:00 2001 From: William Harrison Date: Wed, 17 Jan 2024 09:36:55 +0800 Subject: [PATCH] feat(validation): gitlab verification --- tests/validations.test.js | 2 ++ utils/invalid-domains.json | 1 + utils/validations.js | 1 + 3 files changed, 4 insertions(+) diff --git a/tests/validations.test.js b/tests/validations.test.js index a07ccf6fa..1726affae 100644 --- a/tests/validations.test.js +++ b/tests/validations.test.js @@ -64,6 +64,7 @@ describe('validateDomainData', () => { { ...defaultDomain, record: { AAAA: '182.22.222.22' } }, { ...defaultDomain, record: { A: '::1' } }, { ...defaultDomain, name: '_discord' }, + { ...defaultDomain, name: '_gitlab-pages-verification-code' }, ]; const validCases = [ @@ -94,6 +95,7 @@ describe('validateDomainData', () => { { ...defaultDomain, record: { AAAA: ['::1', '2001:db8:3333:4444:5555:6666:7777:8888'] } }, { ...defaultDomain, record: { A: ['122.222.222.222'] } }, { ...defaultDomain, name: '_discord.subdomain' }, + { ...defaultDomain, name: '_gitlab-pages-verification-code.subdomain' }, ]; it('should return false for invalid data', () => { diff --git a/utils/invalid-domains.json b/utils/invalid-domains.json index ef66a5517..3a5369df5 100644 --- a/utils/invalid-domains.json +++ b/utils/invalid-domains.json @@ -2,6 +2,7 @@ "_acme-challenge", "_github-challenge-is-a-dev", "_github-pages-challenge-is-a-dev", + "_gitlab-pages-verification-code", "help", "no-reply", "noreply", diff --git a/utils/validations.js b/utils/validations.js index b9c851a19..c7cdd7e16 100644 --- a/utils/validations.js +++ b/utils/validations.js @@ -39,6 +39,7 @@ const checkRestrictedNames = R.complement(R.includes(R.__, INVALID_NAMES)) const extraSupportedNames = [ testRegex(/^_github(-pages)?-challenge-[a-z0-9-_]+$/i), // Exception for github verification records R.equals('_discord'), + R.equals('_gitlab-pages-verification-code'), ] const validateDomainData = validate({