From cb22c276c69c330be472c1e09f5a8422ca61f8fb Mon Sep 17 00:00:00 2001 From: William Harrison Date: Mon, 15 Apr 2024 12:18:09 +0800 Subject: [PATCH 1/2] Update invalid-domains.json --- utils/invalid-domains.json | 1 - 1 file changed, 1 deletion(-) diff --git a/utils/invalid-domains.json b/utils/invalid-domains.json index 193ee41e5..f095ac8e3 100644 --- a/utils/invalid-domains.json +++ b/utils/invalid-domains.json @@ -2,7 +2,6 @@ "_acme-challenge", "_discord", "_dmarc", - "_github-challenge-is-a-dev", "_github-pages-challenge-is-a-dev", "_gitlab-pages-verification-code", "help", From 31492ebc29f97428af086203160eb3a46bf99fe9 Mon Sep 17 00:00:00 2001 From: William Harrison Date: Mon, 15 Apr 2024 12:28:24 +0800 Subject: [PATCH 2/2] support new github org records --- domains/_gh-is-a-dev-o.www.json | 10 ++++++++++ tests/validations.test.js | 4 ++++ utils/invalid-domains.json | 2 ++ utils/validations.js | 1 + 4 files changed, 17 insertions(+) create mode 100644 domains/_gh-is-a-dev-o.www.json diff --git a/domains/_gh-is-a-dev-o.www.json b/domains/_gh-is-a-dev-o.www.json new file mode 100644 index 000000000..ea1a4d61e --- /dev/null +++ b/domains/_gh-is-a-dev-o.www.json @@ -0,0 +1,10 @@ +{ + "owner": { + "username": "is-a-dev", + "email": "" + }, + + "record": { + "TXT": "1259c184c5" + } +} diff --git a/tests/validations.test.js b/tests/validations.test.js index 6b9054a4a..a102eeb73 100644 --- a/tests/validations.test.js +++ b/tests/validations.test.js @@ -67,6 +67,7 @@ describe('validateDomainData', () => { { ...defaultDomain, name: '_gitlab-pages-verification-code' }, { ...defaultDomain, name: '_acme-challenge' }, { ...defaultDomain, name: '_dmarc' }, + { ...defaultDomain, name: '_gh-is-a-dev' }, ]; const validCases = [ @@ -100,6 +101,9 @@ describe('validateDomainData', () => { { ...defaultDomain, name: '_gitlab-pages-verification-code.subdomain' }, { ...defaultDomain, name: '_acme-challenge.subdomain' }, { ...defaultDomain, name: '_dmarc.subdomain' }, + { ...defaultDomain, name: '_gh-phenax.akshay' }, + { ...defaultDomain, name: '_gh-hello01-ga' }, + { ...defaultDomain, name: '_gh-hello01_ga' }, ]; it('should return false for invalid data', () => { diff --git a/utils/invalid-domains.json b/utils/invalid-domains.json index f095ac8e3..22c26d2b0 100644 --- a/utils/invalid-domains.json +++ b/utils/invalid-domains.json @@ -2,6 +2,8 @@ "_acme-challenge", "_discord", "_dmarc", + "_gh-is-a-dev", + "_github-challenge-is-a-dev", "_github-pages-challenge-is-a-dev", "_gitlab-pages-verification-code", "help", diff --git a/utils/validations.js b/utils/validations.js index 3731095b2..a5f17eece 100644 --- a/utils/validations.js +++ b/utils/validations.js @@ -42,6 +42,7 @@ const extraSupportedNames = [ R.equals('_gitlab-pages-verification-code'), R.equals('_acme-challenge'), R.equals('_dmarc'), + testRegex(/^_gh-[a-z0-9-_]+$/i), // Exception for the new github org verification records ] const validateDomainData = validate({