tiennm99/java-design-patterns
1
0
Fork 0
mirror of https://github.com/tiennm99/java-design-patterns.git synced 2026-05-25 15:58:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

[refactor] Remove unnecessary declarations in service-locator pattern.

Browse Source
This commit is contained in:
ruslanpa
2015-02-10 10:02:44 +02:00
parent 4b432a79d9
commit 14058082bb
6 changed files with 119 additions and 120 deletions
Download Patch File Download Diff File Expand all files Collapse all files
service-locator/src/main/java/com/iluwatar/ServiceCache.java
+32 -31
View File
@@ -5,42 +5,43 @@ import java.util.Map;
/**
* The service cache implementation which will cache services that are being created.
* On first hit, the cache will be empty and thus any service that is being requested, will be
* On first hit, the cache will be empty and thus any service that is being requested, will be
* created fresh and then placed into the cache map. On next hit, if same service name will
* be requested, it will be returned from the cache
* @author saifasif
* be requested, it will be returned from the cache
*
* @author saifasif
*/
public class ServiceCache {
private Map<String, Service> serviceCache;
public ServiceCache() {
serviceCache = new HashMap<String, Service>();
}
private final Map<String, Service> serviceCache;
/**
* Get the service from the cache. null if no service is found matching the
* name
* @param serviceName
* @return {@link Service}
*/
public Service getService(String serviceName){
Service cachedService = null;
for (String serviceJndiName : serviceCache.keySet()){
if( serviceJndiName.equals( serviceName ) ){
cachedService = serviceCache.get(serviceJndiName);
System.out.println("(cache call) Fetched service " + cachedService.getName() + "("+cachedService.getId()+") from cache... !");
}
}
return cachedService;
}
public ServiceCache() {
serviceCache = new HashMap<String, Service>();
}
/**
* Adds the service into the cache map
* @param newService
*/
public void addService(Service newService){
serviceCache.put(newService.getName(), newService);
}
/**
* Get the service from the cache. null if no service is found matching the name
*
* @param serviceName a string
* @return {@link Service}
*/
public Service getService(String serviceName) {
Service cachedService = null;
for (String serviceJndiName : serviceCache.keySet()) {
if (serviceJndiName.equals(serviceName)) {
cachedService = serviceCache.get(serviceJndiName);
System.out.println("(cache call) Fetched service " + cachedService.getName() + "(" + cachedService.getId() + ") from cache... !");
}
}
return cachedService;
}
/**
* Adds the service into the cache map
*
* @param newService a {@link Service}
*/
public void addService(Service newService) {
serviceCache.put(newService.getName(), newService);
}
}