tiennm99/java-design-patterns
1
0
Fork 0
mirror of https://github.com/tiennm99/java-design-patterns.git synced 2026-05-19 05:25:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

feature: added code refactoring changes for 2378 (#2379)

Browse Source 
* fix:added code refactoring changes for 2378

* fix:added code refactoring changes for 2378

* build fix for 2378

* fix: updated pom.xml files for 2378 issue

* fix:build fix for 2378 issue

Co-authored-by: aparna <aparna@aparnas-MacBook-Air.local>
This commit is contained in:
Aparna
2022-12-10 20:25:37 +05:30
committed by GitHub
parent 6693527485
commit 147e2e681a
32 changed files with 202 additions and 134 deletions
Download Patch File Download Diff File Expand all files Collapse all files
leader-election/src/main/java/com/iluwatar/leaderelection/AbstractMessageManager.java
+2 -4
View File
@@ -24,9 +24,7 @@
*/
package com.iluwatar.leaderelection;
import java.util.List;
import java.util.Map;
import java.util.stream.Collectors;
/**
* Abstract class of all the message manager classes.
@@ -56,13 +54,13 @@ public abstract class AbstractMessageManager implements MessageManager {
.stream()
.filter((i) -> i > currentId && instanceMap.get(i).isAlive())
.sorted()
.collect(Collectors.toList());
.toList();
if (candidateList.isEmpty()) {
var index = instanceMap.keySet()
.stream()
.filter((i) -> instanceMap.get(i).isAlive())
.sorted()
.collect(Collectors.toList())
.toList()
.get(0);
result = instanceMap.get(index);
} else {
leader-election/src/main/java/com/iluwatar/leaderelection/bully/BullyMessageManager.java
+1 -2
View File
@@ -30,7 +30,6 @@ import com.iluwatar.leaderelection.Message;
import com.iluwatar.leaderelection.MessageType;
import java.util.List;
import java.util.Map;
import java.util.stream.Collectors;
/**
* Implementation of BullyMessageManager.
@@ -115,7 +114,7 @@ public class BullyMessageManager extends AbstractMessageManager {
return instanceMap.keySet()
.stream()
.filter((i) -> i < currentId && instanceMap.get(i).isAlive())
.collect(Collectors.toList());
.toList();
}
}
leader-election/src/main/java/com/iluwatar/leaderelection/ring/RingInstance.java
+1 -2
View File
@@ -28,7 +28,6 @@ import com.iluwatar.leaderelection.AbstractInstance;
import com.iluwatar.leaderelection.Message;
import com.iluwatar.leaderelection.MessageManager;
import java.util.Arrays;
import java.util.stream.Collectors;
import lombok.extern.slf4j.Slf4j;
/**
@@ -88,7 +87,7 @@ public class RingInstance extends AbstractInstance {
var candidateList = Arrays.stream(content.trim().split(","))
.map(Integer::valueOf)
.sorted()
.collect(Collectors.toList());
.toList();
if (candidateList.contains(localId)) {
var newLeaderId = candidateList.get(0);
LOGGER.info(INSTANCE + localId + " - New leader should be " + newLeaderId + ".");