tiennm99/java-design-patterns
1
0
Fork 0
mirror of https://github.com/tiennm99/java-design-patterns.git synced 2026-08-18 00:23:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Remove deprecated method of newInstance (#2594)

Browse Source
This commit is contained in:
kongleong86
2023-10-14 13:58:15 +03:00
committed by GitHub
parent 38d28870f2
commit 1bea90ed9c
2 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
front-controller/src/main/java/com/iluwatar/front/controller/FrontController.java
+1 -1
View File
@@ -38,7 +38,7 @@ public class FrontController {
private Command getCommand(String request) { private Command getCommand(String request) {
var commandClass = getCommandClass(request); var commandClass = getCommandClass(request);
try { try {
return (Command) commandClass.newInstance(); return (Command) commandClass.getDeclaredConstructor().newInstance();
} catch (Exception e) { } catch (Exception e) {
throw new ApplicationException(e); throw new ApplicationException(e);
} }
role-object/src/main/java/com/iluwatar/roleobject/Role.java
+3 -2
View File
@@ -24,6 +24,7 @@
*/ */
package com.iluwatar.roleobject; package com.iluwatar.roleobject;
import java.lang.reflect.InvocationTargetException;
import java.util.Optional; import java.util.Optional;
import org.slf4j.Logger; import org.slf4j.Logger;
import org.slf4j.LoggerFactory; import org.slf4j.LoggerFactory;
@@ -50,8 +51,8 @@ public enum Role {
public <T extends CustomerRole> Optional<T> instance() { public <T extends CustomerRole> Optional<T> instance() {
var typeCst = this.typeCst; var typeCst = this.typeCst;
try { try {
return (Optional<T>) Optional.of(typeCst.newInstance()); return (Optional<T>) Optional.of(typeCst.getDeclaredConstructor().newInstance());
} catch (InstantiationException | IllegalAccessException e) { } catch (InstantiationException | IllegalAccessException | NoSuchMethodException | InvocationTargetException e) {
logger.error("error creating an object", e); logger.error("error creating an object", e);
} }
return Optional.empty(); return Optional.empty();