fix: Reduce High severity issues reported by SonarCloud #2865 (#3103)

* fix: add UnsupportedOperationException in KingsHand and GameLoopTest * refactor: update DatabaseService to use constant for BINARY_DATA and remove obsolete test files * refactor: update timePasses method in KingsHand * refactor CandyGame.java * refactor: simplify boundary checks in CandyGame * feat: add getters for type and points in Candy class and initialize logger in CandyGame * remove class and logger initialization in CandyGame * Modify CandyGame.java * fix Checkstyle violations * Remove generic wildcard type in ThreatAwareSystem
2026-05-16 20:59:07 +00:00 · 2024-12-07 20:31:59 +02:00
parent b375919db5
commit 297e429e5a
9 changed files with 29 additions and 21 deletions
@@ -0,0 +1,82 @@
+/*
+ * This project is licensed under the MIT license. Module model-view-viewmodel is using ZK framework licensed under LGPL (see lgpl-3.0.txt).
+ *
+ * The MIT License
+ * Copyright © 2014-2022 Ilkka Seppälä
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+ * THE SOFTWARE.
+ */
+package com.iluwatar.sessionserver;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.mockito.Mockito.when;
+
+import com.sun.net.httpserver.Headers;
+import com.sun.net.httpserver.HttpExchange;
+import java.io.ByteArrayOutputStream;
+import java.time.Instant;
+import java.util.HashMap;
+import java.util.Map;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.mockito.Mock;
+import org.mockito.MockitoAnnotations;
+
+/**
+ * LoginHandlerTest.
+ */
+public class LoginHandlerTest {
+
+  private LoginHandler loginHandler;
+  //private Headers headers;
+  private Map<String, Integer> sessions;
+  private Map<String, Instant> sessionCreationTimes;
+
+  @Mock
+  private HttpExchange exchange;
+
+  /**
+   * Setup tests.
+   */
+  @BeforeEach
+  public void setUp() {
+    MockitoAnnotations.initMocks(this);
+    sessions = new HashMap<>();
+    sessionCreationTimes = new HashMap<>();
+    loginHandler = new LoginHandler(sessions, sessionCreationTimes);
+  }
+
+  @Test
+  public void testHandle() {
+
+    //assemble
+    ByteArrayOutputStream outputStream =
+        new ByteArrayOutputStream(); //Exchange object is mocked so OutputStream must be manually created
+    when(exchange.getResponseHeaders()).thenReturn(
+        new Headers()); //Exchange object is mocked so Header object must be manually created
+    when(exchange.getResponseBody()).thenReturn(outputStream);
+
+    //act
+    loginHandler.handle(exchange);
+
+    //assert
+    String[] response = outputStream.toString().split("Session ID: ");
+    assertEquals(sessions.entrySet().toArray()[0].toString().split("=1")[0], response[1]);
+  }
+}
@@ -0,0 +1,104 @@
+/*
+ * This project is licensed under the MIT license. Module model-view-viewmodel is using ZK framework licensed under LGPL (see lgpl-3.0.txt).
+ *
+ * The MIT License
+ * Copyright © 2014-2022 Ilkka Seppälä
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+ * THE SOFTWARE.
+ */
+package com.iluwatar.sessionserver;
+
+import static org.mockito.Mockito.when;
+
+import com.sun.net.httpserver.Headers;
+import com.sun.net.httpserver.HttpExchange;
+import java.io.ByteArrayOutputStream;
+import java.time.Instant;
+import java.util.HashMap;
+import java.util.Map;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.mockito.Mock;
+import org.mockito.MockitoAnnotations;
+
+/**
+ * LogoutHandlerTest.
+ */
+public class LogoutHandlerTest {
+
+  private LogoutHandler logoutHandler;
+  private Headers headers;
+  private Map<String, Integer> sessions;
+  private Map<String, Instant> sessionCreationTimes;
+
+  @Mock
+  private HttpExchange exchange;
+
+  /**
+   * Setup tests.
+   */
+  @BeforeEach
+  public void setUp() {
+    MockitoAnnotations.initMocks(this);
+    sessions = new HashMap<>();
+    sessionCreationTimes = new HashMap<>();
+    logoutHandler = new LogoutHandler(sessions, sessionCreationTimes);
+    headers = new Headers();
+    headers.add("Cookie",
+        "sessionID=1234"); //Exchange object methods return Header Object but Exchange is mocked so Headers must be manually created
+  }
+
+  @Test
+  public void testHandler_SessionNotExpired() {
+
+    //assemble
+    sessions.put("1234", 1); //Fake login details since LoginHandler isn't called
+    sessionCreationTimes.put("1234",
+        Instant.now()); //Fake login details since LoginHandler isn't called
+    when(exchange.getRequestHeaders()).thenReturn(headers);
+    ByteArrayOutputStream outputStream = new ByteArrayOutputStream();
+    when(exchange.getResponseBody()).thenReturn(outputStream);
+
+    //act
+    logoutHandler.handle(exchange);
+
+    //assert
+    String[] response = outputStream.toString().split("Session ID: ");
+    Assertions.assertEquals("1234", response[1]);
+    Assertions.assertFalse(sessions.containsKey(response[1]));
+    Assertions.assertFalse(sessionCreationTimes.containsKey(response[1]));
+  }
+
+  @Test
+  public void testHandler_SessionExpired() {
+
+    //assemble
+    ByteArrayOutputStream outputStream = new ByteArrayOutputStream();
+    when(exchange.getRequestHeaders()).thenReturn(headers);
+    when(exchange.getResponseBody()).thenReturn(outputStream);
+
+    //act
+    logoutHandler.handle(exchange);
+
+    //assert
+    String[] response = outputStream.toString().split("Session ID: ");
+    Assertions.assertEquals("Session has already expired!", response[0]);
+  }
+}