Minor refactorings and code style changes (#807)

* Made minor changes in some patterns such as removed throws clause where not needed, changed incorrect order of arguments in assertEquals

* Minor refactorings and code style changes. 1) Removed several use of raw types 2) Removed unnecessary throws clauses 3) Used lambda expressions wherever applicable 4) Used apt assertion methods for readability 5) Use of try with resources wherever applicable 6) Corrected incorrect order of assertXXX arguments

* Removed unused import from Promise

* Addressed review comments

* Addressed checkstyle issue

data-transfer-object/src/test/java/com/iluwatar/datatransfer/CustomerResourceTest.java

@@ -30,6 +30,7 @@ import java.util.ArrayList;
 import java.util.List;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 
 /**
  * tests {@link CustomerResource}.
@@ -45,10 +46,10 @@ public class CustomerResourceTest {
 
     List<CustomerDto> allCustomers = customerResource.getAllCustomers();
 
-    assertEquals(allCustomers.size(), 1);
-    assertEquals(allCustomers.get(0).getId(), "1");
-    assertEquals(allCustomers.get(0).getFirstName(), "Melody");
-    assertEquals(allCustomers.get(0).getLastName(), "Yates");
+    assertEquals(1, allCustomers.size());
+    assertEquals("1", allCustomers.get(0).getId());
+    assertEquals("Melody", allCustomers.get(0).getFirstName());
+    assertEquals("Yates", allCustomers.get(0).getLastName());
   }
 
   @Test
@@ -59,9 +60,9 @@ public class CustomerResourceTest {
     customerResource.save(customer);
 
     List<CustomerDto> allCustomers = customerResource.getAllCustomers();
-    assertEquals(allCustomers.get(0).getId(), "1");
-    assertEquals(allCustomers.get(0).getFirstName(), "Rita");
-    assertEquals(allCustomers.get(0).getLastName(), "Reynolds");
+    assertEquals("1", allCustomers.get(0).getId());
+    assertEquals("Rita", allCustomers.get(0).getFirstName());
+    assertEquals("Reynolds", allCustomers.get(0).getLastName());
   }
 
   @Test
@@ -75,7 +76,7 @@ public class CustomerResourceTest {
     customerResource.delete(customer.getId());
 
     List<CustomerDto> allCustomers = customerResource.getAllCustomers();
-    assertEquals(allCustomers.size(), 0);
+    assertTrue(allCustomers.isEmpty());
   }
 
 }