mirror of
https://github.com/tiennm99/java-design-patterns.git
synced 2026-05-14 08:58:26 +00:00
refactor: remove code smell java:S5786 (#2159)
https://sonarcloud.io/organizations/iluwatar/rules?open=java%3AS5786&rule_key=java%3AS5786
This commit is contained in:
+1
-1
@@ -33,7 +33,7 @@ import org.junit.jupiter.api.Test;
|
||||
*
|
||||
* @author Jeroen Meulemeester
|
||||
*/
|
||||
public class ApplicationExceptionTest {
|
||||
class ApplicationExceptionTest {
|
||||
|
||||
@Test
|
||||
void testCause() {
|
||||
|
||||
@@ -38,17 +38,17 @@ import org.junit.jupiter.params.provider.MethodSource;
|
||||
*
|
||||
* @author Jeroen Meulemeester
|
||||
*/
|
||||
public class CommandTest {
|
||||
class CommandTest {
|
||||
|
||||
private InMemoryAppender appender;
|
||||
|
||||
@BeforeEach
|
||||
public void setUp() {
|
||||
void setUp() {
|
||||
appender = new InMemoryAppender();
|
||||
}
|
||||
|
||||
@AfterEach
|
||||
public void tearDown() {
|
||||
void tearDown() {
|
||||
appender.stop();
|
||||
}
|
||||
|
||||
@@ -66,7 +66,7 @@ public class CommandTest {
|
||||
*/
|
||||
@ParameterizedTest
|
||||
@MethodSource("dataProvider")
|
||||
public void testDisplay(String request, String displayMessage) {
|
||||
void testDisplay(String request, String displayMessage) {
|
||||
final var frontController = new FrontController();
|
||||
assertEquals(0, appender.getLogSize());
|
||||
frontController.handleRequest(request);
|
||||
|
||||
+4
-4
@@ -38,17 +38,17 @@ import org.junit.jupiter.params.provider.MethodSource;
|
||||
*
|
||||
* @author Jeroen Meulemeester
|
||||
*/
|
||||
public class FrontControllerTest {
|
||||
class FrontControllerTest {
|
||||
|
||||
private InMemoryAppender appender;
|
||||
|
||||
@BeforeEach
|
||||
public void setUp() {
|
||||
void setUp() {
|
||||
appender = new InMemoryAppender();
|
||||
}
|
||||
|
||||
@AfterEach
|
||||
public void tearDown() {
|
||||
void tearDown() {
|
||||
appender.stop();
|
||||
}
|
||||
|
||||
@@ -66,7 +66,7 @@ public class FrontControllerTest {
|
||||
*/
|
||||
@ParameterizedTest
|
||||
@MethodSource("dataProvider")
|
||||
public void testDisplay(Command command, String displayMessage) {
|
||||
void testDisplay(Command command, String displayMessage) {
|
||||
assertEquals(0, appender.getLogSize());
|
||||
command.process();
|
||||
assertEquals(displayMessage, appender.getLastMessage());
|
||||
|
||||
@@ -38,17 +38,17 @@ import org.junit.jupiter.params.provider.MethodSource;
|
||||
*
|
||||
* @author Jeroen Meulemeester
|
||||
*/
|
||||
public class ViewTest {
|
||||
class ViewTest {
|
||||
|
||||
private InMemoryAppender appender;
|
||||
|
||||
@BeforeEach
|
||||
public void setUp() {
|
||||
void setUp() {
|
||||
appender = new InMemoryAppender();
|
||||
}
|
||||
|
||||
@AfterEach
|
||||
public void tearDown() {
|
||||
void tearDown() {
|
||||
appender.stop();
|
||||
}
|
||||
|
||||
@@ -66,7 +66,7 @@ public class ViewTest {
|
||||
*/
|
||||
@ParameterizedTest
|
||||
@MethodSource("dataProvider")
|
||||
public void testDisplay(View view, String displayMessage) {
|
||||
void testDisplay(View view, String displayMessage) {
|
||||
assertEquals(0, appender.getLogSize());
|
||||
view.display();
|
||||
assertEquals(displayMessage, appender.getLastMessage());
|
||||
|
||||
Reference in New Issue
Block a user