refactor: remove code smell java:S5786 (#2159)

https://sonarcloud.io/organizations/iluwatar/rules?open=java%3AS5786&rule_key=java%3AS5786

observer/src/test/java/com/iluwatar/observer/HobbitsTest.java

@@ -32,7 +32,7 @@ import java.util.List;
  *
  * @author Jeroen Meulemeester
  */
-public class HobbitsTest extends WeatherObserverTest<Hobbits> {
+class HobbitsTest extends WeatherObserverTest<Hobbits> {
 
   @Override
   public Collection<Object[]> dataProvider() {

observer/src/test/java/com/iluwatar/observer/OrcsTest.java

@@ -32,7 +32,7 @@ import java.util.List;
  *
  * @author Jeroen Meulemeester
  */
-public class OrcsTest extends WeatherObserverTest<Orcs> {
+class OrcsTest extends WeatherObserverTest<Orcs> {
 
   @Override
   public Collection<Object[]> dataProvider() {

observer/src/test/java/com/iluwatar/observer/WeatherObserverTest.java

@@ -50,12 +50,12 @@ public abstract class WeatherObserverTest<O extends WeatherObserver> {
   private InMemoryAppender appender;
 
   @BeforeEach
-  public void setUp() {
+  void setUp() {
     appender = new InMemoryAppender();
   }
 
   @AfterEach
-  public void tearDown() {
+  void tearDown() {
     appender.stop();
   }
 
@@ -80,7 +80,7 @@ public abstract class WeatherObserverTest<O extends WeatherObserver> {
    */
   @ParameterizedTest
   @MethodSource("dataProvider")
-  public void testObserver(WeatherType weather, String response) {
+  void testObserver(WeatherType weather, String response) {
     final var observer = this.factory.get();
     assertEquals(0, appender.getLogSize());
 

observer/src/test/java/com/iluwatar/observer/WeatherTest.java

@@ -41,17 +41,17 @@ import org.junit.jupiter.api.Test;
  *
  * @author Jeroen Meulemeester
  */
-public class WeatherTest {
+class WeatherTest {
 
   private InMemoryAppender appender;
 
   @BeforeEach
-  public void setUp() {
+  void setUp() {
     appender = new InMemoryAppender(Weather.class);
   }
 
   @AfterEach
-  public void tearDown() {
+  void tearDown() {
     appender.stop();
   }
 

observer/src/test/java/com/iluwatar/observer/generic/GHobbitsTest.java

@@ -34,7 +34,7 @@ import java.util.List;
  *
  * @author Jeroen Meulemeester
  */
-public class GHobbitsTest extends ObserverTest<GHobbits> {
+class GHobbitsTest extends ObserverTest<GHobbits> {
 
   @Override
   public Collection<Object[]> dataProvider() {

observer/src/test/java/com/iluwatar/observer/generic/GWeatherTest.java

@@ -43,17 +43,17 @@ import org.junit.jupiter.api.Test;
  *
  * @author Jeroen Meulemeester
  */
-public class GWeatherTest {
+class GWeatherTest {
 
   private InMemoryAppender appender;
 
   @BeforeEach
-  public void setUp() {
+  void setUp() {
     appender = new InMemoryAppender(GWeather.class);
   }
 
   @AfterEach
-  public void tearDown() {
+  void tearDown() {
     appender.stop();
   }
 

observer/src/test/java/com/iluwatar/observer/generic/ObserverTest.java

@@ -49,12 +49,12 @@ public abstract class ObserverTest<O extends Observer<?, ?, WeatherType>> {
   private InMemoryAppender appender;
 
   @BeforeEach
-  public void setUp() {
+  void setUp() {
     appender = new InMemoryAppender();
   }
 
   @AfterEach
-  public void tearDown() {
+  void tearDown() {
     appender.stop();
   }
 
@@ -79,7 +79,7 @@ public abstract class ObserverTest<O extends Observer<?, ?, WeatherType>> {
    */
   @ParameterizedTest
   @MethodSource("dataProvider")
-  public void testObserver(WeatherType weather, String response) {
+  void testObserver(WeatherType weather, String response) {
     final var observer = this.factory.get();
     assertEquals(0, appender.getLogSize());
 

observer/src/test/java/com/iluwatar/observer/generic/OrcsTest.java

@@ -34,7 +34,7 @@ import java.util.List;
  *
  * @author Jeroen Meulemeester
  */
-public class OrcsTest extends ObserverTest<GOrcs> {
+class OrcsTest extends ObserverTest<GOrcs> {
 
   @Override
   public Collection<Object[]> dataProvider() {